6ac9c49773
Right now, if you model something like this box with a button: <img width="413" alt="Screenshot 2025-02-06 at 3 08 03 PM" src="https://github.com/user-attachments/assets/04818a70-7cf3-4ee3-b8c5-df5959ac10db" /> Let's say you want to pattern the button, and repeat it a second time. If you try, you'll actually pattern the entire model (box + button). <img width="486" alt="Screenshot 2025-02-06 at 3 08 52 PM" src="https://github.com/user-attachments/assets/09fc28d9-5d80-4ab3-b4dc-b8de2945fcba" /> Why? Because right now, when you sketch on a face (like the button was), both the box and the button share the same ID. All extrusions from a solid will share the same ID, because they all refer to the same composite solid. This is helpful in some ways -- arguably the solid _is_ just one big complex shape now -- but it's not helpful in other ways. What if I want to only pattern the button? Luckily there's an original ID for the button part, which is still stored. So we just need a way to tell the pattern stdlib functions whether to use the target's main ID or its original ID. This PR adds a new optional bool, `useOriginal`, to patterns. It's false by default, to keep backwards-compatibility (make sure that old KCL code doesn't change). This PR is based on https://github.com/KittyCAD/modeling-app/pull/3914. It's based on work Serena and I are doing to fix a bug (engine does not allow patterning a 3D solid which was sketched on a face of another solid). @gserena01 our test program is now: ``` w = 400 case = startSketchOn('XY') |> startProfileAt([-w, -w], %) |> line(endAbsolute = [-w, w]) |> line(endAbsolute = [w, -w]) |> line(endAbsolute = [-w, -w]) |> close() |> extrude(length = 200) bump1 = startSketchOn(case, 'end') |> circle({ center = [-50, -50], radius = 40 }, %) |> extrude(length = 20) // We pass in "bump1" here since we want to pattern just this object on the face. useOriginal = true target = bump1 transform = { axis = [1, 0, 0], instances = 3, distance = -100 } patternLinear3d(transform, target, useOriginal) ``` If you change the `useOriginal = true` to `false` you can see the difference.
448 lines
11 KiB
Plaintext
448 lines
11 KiB
Plaintext
---
|
|
source: kcl/src/simulation_tests.rs
|
|
description: Program memory after executing angled_line.kcl
|
|
snapshot_kind: text
|
|
---
|
|
{
|
|
"environments": [
|
|
{
|
|
"bindings": {
|
|
"HALF_TURN": {
|
|
"type": "Number",
|
|
"value": 180.0,
|
|
"__meta": []
|
|
},
|
|
"QUARTER_TURN": {
|
|
"type": "Number",
|
|
"value": 90.0,
|
|
"__meta": []
|
|
},
|
|
"THREE_QUARTER_TURN": {
|
|
"type": "Number",
|
|
"value": 270.0,
|
|
"__meta": []
|
|
},
|
|
"ZERO": {
|
|
"type": "Number",
|
|
"value": 0.0,
|
|
"__meta": []
|
|
},
|
|
"part001": {
|
|
"type": "Solid",
|
|
"value": {
|
|
"type": "Solid",
|
|
"id": "[uuid]",
|
|
"artifactId": "[uuid]",
|
|
"value": [
|
|
{
|
|
"faceId": "[uuid]",
|
|
"id": "[uuid]",
|
|
"sourceRange": [
|
|
73,
|
|
97,
|
|
0
|
|
],
|
|
"tag": null,
|
|
"type": "extrudePlane"
|
|
},
|
|
{
|
|
"faceId": "[uuid]",
|
|
"id": "[uuid]",
|
|
"sourceRange": [
|
|
103,
|
|
142,
|
|
0
|
|
],
|
|
"tag": {
|
|
"end": 141,
|
|
"start": 135,
|
|
"type": "TagDeclarator",
|
|
"value": "seg01"
|
|
},
|
|
"type": "extrudePlane"
|
|
},
|
|
{
|
|
"faceId": "[uuid]",
|
|
"id": "[uuid]",
|
|
"sourceRange": [
|
|
148,
|
|
174,
|
|
0
|
|
],
|
|
"tag": null,
|
|
"type": "extrudePlane"
|
|
},
|
|
{
|
|
"faceId": "[uuid]",
|
|
"id": "[uuid]",
|
|
"sourceRange": [
|
|
180,
|
|
217,
|
|
0
|
|
],
|
|
"tag": null,
|
|
"type": "extrudePlane"
|
|
},
|
|
{
|
|
"faceId": "[uuid]",
|
|
"id": "[uuid]",
|
|
"sourceRange": [
|
|
223,
|
|
250,
|
|
0
|
|
],
|
|
"tag": null,
|
|
"type": "extrudePlane"
|
|
},
|
|
{
|
|
"faceId": "[uuid]",
|
|
"id": "[uuid]",
|
|
"sourceRange": [
|
|
256,
|
|
264,
|
|
0
|
|
],
|
|
"tag": null,
|
|
"type": "extrudePlane"
|
|
}
|
|
],
|
|
"sketch": {
|
|
"type": "Sketch",
|
|
"id": "[uuid]",
|
|
"paths": [
|
|
{
|
|
"__geoMeta": {
|
|
"id": "[uuid]",
|
|
"sourceRange": [
|
|
73,
|
|
97,
|
|
0
|
|
]
|
|
},
|
|
"from": [
|
|
4.83,
|
|
12.56
|
|
],
|
|
"tag": null,
|
|
"to": [
|
|
19.93,
|
|
15.04
|
|
],
|
|
"type": "ToPoint"
|
|
},
|
|
{
|
|
"__geoMeta": {
|
|
"id": "[uuid]",
|
|
"sourceRange": [
|
|
103,
|
|
142,
|
|
0
|
|
]
|
|
},
|
|
"from": [
|
|
19.93,
|
|
15.04
|
|
],
|
|
"tag": {
|
|
"end": 141,
|
|
"start": 135,
|
|
"type": "TagDeclarator",
|
|
"value": "seg01"
|
|
},
|
|
"to": [
|
|
23.08,
|
|
5.19
|
|
],
|
|
"type": "ToPoint"
|
|
},
|
|
{
|
|
"__geoMeta": {
|
|
"id": "[uuid]",
|
|
"sourceRange": [
|
|
148,
|
|
174,
|
|
0
|
|
]
|
|
},
|
|
"from": [
|
|
23.08,
|
|
5.19
|
|
],
|
|
"tag": null,
|
|
"to": [
|
|
7.91,
|
|
1.09
|
|
],
|
|
"type": "ToPoint"
|
|
},
|
|
{
|
|
"__geoMeta": {
|
|
"id": "[uuid]",
|
|
"sourceRange": [
|
|
180,
|
|
217,
|
|
0
|
|
]
|
|
},
|
|
"from": [
|
|
7.91,
|
|
1.09
|
|
],
|
|
"tag": null,
|
|
"to": [
|
|
11.6718,
|
|
-10.6731
|
|
],
|
|
"type": "ToPoint"
|
|
},
|
|
{
|
|
"__geoMeta": {
|
|
"id": "[uuid]",
|
|
"sourceRange": [
|
|
223,
|
|
250,
|
|
0
|
|
]
|
|
},
|
|
"from": [
|
|
11.6718,
|
|
-10.6731
|
|
],
|
|
"tag": null,
|
|
"to": [
|
|
-1.3482,
|
|
-0.6431
|
|
],
|
|
"type": "ToPoint"
|
|
},
|
|
{
|
|
"__geoMeta": {
|
|
"id": "[uuid]",
|
|
"sourceRange": [
|
|
256,
|
|
264,
|
|
0
|
|
]
|
|
},
|
|
"from": [
|
|
-1.3482,
|
|
-0.6431
|
|
],
|
|
"tag": null,
|
|
"to": [
|
|
4.83,
|
|
12.56
|
|
],
|
|
"type": "ToPoint"
|
|
}
|
|
],
|
|
"on": {
|
|
"type": "plane",
|
|
"id": "[uuid]",
|
|
"artifactId": "[uuid]",
|
|
"value": "XY",
|
|
"origin": {
|
|
"x": 0.0,
|
|
"y": 0.0,
|
|
"z": 0.0
|
|
},
|
|
"xAxis": {
|
|
"x": 1.0,
|
|
"y": 0.0,
|
|
"z": 0.0
|
|
},
|
|
"yAxis": {
|
|
"x": 0.0,
|
|
"y": 1.0,
|
|
"z": 0.0
|
|
},
|
|
"zAxis": {
|
|
"x": 0.0,
|
|
"y": 0.0,
|
|
"z": 1.0
|
|
},
|
|
"units": {
|
|
"type": "Mm"
|
|
},
|
|
"__meta": []
|
|
},
|
|
"start": {
|
|
"from": [
|
|
4.83,
|
|
12.56
|
|
],
|
|
"to": [
|
|
4.83,
|
|
12.56
|
|
],
|
|
"tag": null,
|
|
"__geoMeta": {
|
|
"id": "[uuid]",
|
|
"sourceRange": [
|
|
35,
|
|
67,
|
|
0
|
|
]
|
|
}
|
|
},
|
|
"tags": {
|
|
"seg01": {
|
|
"type": "TagIdentifier",
|
|
"value": "seg01",
|
|
"info": {
|
|
"type": "TagEngineInfo",
|
|
"id": "[uuid]",
|
|
"sketch": "[uuid]",
|
|
"path": {
|
|
"__geoMeta": {
|
|
"id": "[uuid]",
|
|
"sourceRange": [
|
|
103,
|
|
142,
|
|
0
|
|
]
|
|
},
|
|
"from": [
|
|
19.93,
|
|
15.040000000000001
|
|
],
|
|
"tag": {
|
|
"end": 141,
|
|
"start": 135,
|
|
"type": "TagDeclarator",
|
|
"value": "seg01"
|
|
},
|
|
"to": [
|
|
23.08,
|
|
5.190000000000001
|
|
],
|
|
"type": "ToPoint"
|
|
},
|
|
"surface": {
|
|
"faceId": "[uuid]",
|
|
"id": "[uuid]",
|
|
"sourceRange": [
|
|
103,
|
|
142,
|
|
0
|
|
],
|
|
"tag": {
|
|
"end": 141,
|
|
"start": 135,
|
|
"type": "TagDeclarator",
|
|
"value": "seg01"
|
|
},
|
|
"type": "extrudePlane"
|
|
}
|
|
},
|
|
"__meta": [
|
|
{
|
|
"sourceRange": [
|
|
135,
|
|
141,
|
|
0
|
|
]
|
|
}
|
|
]
|
|
}
|
|
},
|
|
"artifactId": "[uuid]",
|
|
"originalId": "[uuid]",
|
|
"units": {
|
|
"type": "Mm"
|
|
},
|
|
"__meta": [
|
|
{
|
|
"sourceRange": [
|
|
35,
|
|
67,
|
|
0
|
|
]
|
|
}
|
|
]
|
|
},
|
|
"height": 4.0,
|
|
"startCapId": "[uuid]",
|
|
"endCapId": "[uuid]",
|
|
"units": {
|
|
"type": "Mm"
|
|
},
|
|
"__meta": [
|
|
{
|
|
"sourceRange": [
|
|
35,
|
|
67,
|
|
0
|
|
]
|
|
}
|
|
]
|
|
}
|
|
},
|
|
"seg01": {
|
|
"type": "TagIdentifier",
|
|
"type": "TagIdentifier",
|
|
"value": "seg01",
|
|
"info": {
|
|
"type": "TagEngineInfo",
|
|
"id": "[uuid]",
|
|
"sketch": "[uuid]",
|
|
"path": {
|
|
"__geoMeta": {
|
|
"id": "[uuid]",
|
|
"sourceRange": [
|
|
103,
|
|
142,
|
|
0
|
|
]
|
|
},
|
|
"from": [
|
|
19.93,
|
|
15.040000000000001
|
|
],
|
|
"tag": {
|
|
"end": 141,
|
|
"start": 135,
|
|
"type": "TagDeclarator",
|
|
"value": "seg01"
|
|
},
|
|
"to": [
|
|
23.08,
|
|
5.190000000000001
|
|
],
|
|
"type": "ToPoint"
|
|
},
|
|
"surface": {
|
|
"faceId": "[uuid]",
|
|
"id": "[uuid]",
|
|
"sourceRange": [
|
|
103,
|
|
142,
|
|
0
|
|
],
|
|
"tag": {
|
|
"end": 141,
|
|
"start": 135,
|
|
"type": "TagDeclarator",
|
|
"value": "seg01"
|
|
},
|
|
"type": "extrudePlane"
|
|
}
|
|
},
|
|
"__meta": [
|
|
{
|
|
"sourceRange": [
|
|
135,
|
|
141,
|
|
0
|
|
]
|
|
}
|
|
]
|
|
}
|
|
},
|
|
"parent": null
|
|
}
|
|
],
|
|
"currentEnv": 0,
|
|
"return": null
|
|
}
|