Previously in a member expression like `foo.x` or `foo[3]`, `foo` had to be an identifier. You could not do something like `f().x` (and if you tried, you got a cryptic error). Rather than make the error better, we should just accept any expression to be the LHS of a member expression (aka its 'object'). This does knock our "parse lots of function calls" from 58 to 55 calls before it stack overflows. But I think it's fine, we'll address this in https://github.com/KittyCAD/modeling-app/pull/6226 when I get back to it. Closes https://github.com/KittyCAD/modeling-app/issues/7273
		
			
				
	
	
		
			98 lines
		
	
	
		
			2.3 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
			
		
		
	
	
			98 lines
		
	
	
		
			2.3 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
---
 | 
						|
source: kcl-lib/src/simulation_tests.rs
 | 
						|
description: Result of parsing invalid_member_object_prop.kcl
 | 
						|
---
 | 
						|
{
 | 
						|
  "Ok": {
 | 
						|
    "body": [
 | 
						|
      {
 | 
						|
        "commentStart": 0,
 | 
						|
        "declaration": {
 | 
						|
          "commentStart": 0,
 | 
						|
          "end": 0,
 | 
						|
          "id": {
 | 
						|
            "commentStart": 0,
 | 
						|
            "end": 0,
 | 
						|
            "name": "b",
 | 
						|
            "start": 0,
 | 
						|
            "type": "Identifier"
 | 
						|
          },
 | 
						|
          "init": {
 | 
						|
            "commentStart": 0,
 | 
						|
            "end": 0,
 | 
						|
            "raw": "true",
 | 
						|
            "start": 0,
 | 
						|
            "type": "Literal",
 | 
						|
            "type": "Literal",
 | 
						|
            "value": true
 | 
						|
          },
 | 
						|
          "start": 0,
 | 
						|
          "type": "VariableDeclarator"
 | 
						|
        },
 | 
						|
        "end": 0,
 | 
						|
        "kind": "const",
 | 
						|
        "start": 0,
 | 
						|
        "type": "VariableDeclaration",
 | 
						|
        "type": "VariableDeclaration"
 | 
						|
      },
 | 
						|
      {
 | 
						|
        "commentStart": 0,
 | 
						|
        "declaration": {
 | 
						|
          "commentStart": 0,
 | 
						|
          "end": 0,
 | 
						|
          "id": {
 | 
						|
            "commentStart": 0,
 | 
						|
            "end": 0,
 | 
						|
            "name": "x",
 | 
						|
            "start": 0,
 | 
						|
            "type": "Identifier"
 | 
						|
          },
 | 
						|
          "init": {
 | 
						|
            "commentStart": 0,
 | 
						|
            "computed": false,
 | 
						|
            "end": 0,
 | 
						|
            "object": {
 | 
						|
              "abs_path": false,
 | 
						|
              "commentStart": 0,
 | 
						|
              "end": 0,
 | 
						|
              "name": {
 | 
						|
                "commentStart": 0,
 | 
						|
                "end": 0,
 | 
						|
                "name": "b",
 | 
						|
                "start": 0,
 | 
						|
                "type": "Identifier"
 | 
						|
              },
 | 
						|
              "path": [],
 | 
						|
              "start": 0,
 | 
						|
              "type": "Name",
 | 
						|
              "type": "Name"
 | 
						|
            },
 | 
						|
            "property": {
 | 
						|
              "commentStart": 0,
 | 
						|
              "end": 0,
 | 
						|
              "raw": "\"property\"",
 | 
						|
              "start": 0,
 | 
						|
              "type": "Literal",
 | 
						|
              "type": "Literal",
 | 
						|
              "value": "property"
 | 
						|
            },
 | 
						|
            "start": 0,
 | 
						|
            "type": "MemberExpression",
 | 
						|
            "type": "MemberExpression"
 | 
						|
          },
 | 
						|
          "start": 0,
 | 
						|
          "type": "VariableDeclarator"
 | 
						|
        },
 | 
						|
        "end": 0,
 | 
						|
        "kind": "const",
 | 
						|
        "start": 0,
 | 
						|
        "type": "VariableDeclaration",
 | 
						|
        "type": "VariableDeclaration"
 | 
						|
      }
 | 
						|
    ],
 | 
						|
    "commentStart": 0,
 | 
						|
    "end": 0,
 | 
						|
    "start": 0
 | 
						|
  }
 | 
						|
}
 |