ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
fa4b3cfd1b781c89862cda98d7f7d7bb59e1f3f3
modeling-app/rust/kcl-lib/tests
History
Adam Chalmers 85ccc6900c Do multiple chamfer/fillet in one API call (#6750) 
KCL's `fillet` function takes an array of edges to fillet. Previously this would do `n` fillet API commands, one per edge. This PR combines them all into one call, which should improve performance. You can see the effect in the  artifact_commands snapshots, e.g. `rust/kcl-lib/tests/kcl_samples/axial-fan/artifact_commands.snap` 

Besides performance, this should fix a bug where some KCL fillets would fail, when they should have succeeded. Example from @max-mrgrsk:

```kcl
sketch001 = startSketchOn(XY)
  |> startProfile(at = [-12, -6])
  |> line(end = [0, 12], tag = $seg04)
  |> line(end = [24, 0], tag = $seg03)
  |> line(end = [0, -12], tag = $seg02)
  |> line(endAbsolute = [profileStartX(%), profileStartY(%)], tag = $seg01)
  |> close()
extrude001 = extrude(
       sketch001,
       length = 12,
       tagEnd = $capEnd001,
       tagStart = $capStart001,
     )
  |> fillet(
       radius = 5,
       tags = [
         getCommonEdge(faces = [seg02, capEnd001]),
         getCommonEdge(faces = [seg01, capEnd001]),
         getCommonEdge(faces = [seg03, capEnd001]),
         getCommonEdge(faces = [seg04, capEnd001])
       ],
     )
```

This program fails on main, but succeeds on this branch.
2025-05-22 21:25:55 +00:00
..
add_lots
Display numeric units in the variables pane (#6683)
2025-05-06 03:40:18 +00:00
angled_line
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
any_type
Fix the KCL any type and array coercion incorrectly nesting (#6816)
2025-05-12 03:57:31 +00:00
argument_error
Add display of array element types in error messages (#7113)
2025-05-20 20:50:24 -04:00
array_elem_pop
Fix the KCL any type and array coercion incorrectly nesting (#6816)
2025-05-12 03:57:31 +00:00
array_elem_pop_empty_fail
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
array_elem_pop_fail
Add display of array element types in error messages (#7113)
2025-05-20 20:50:24 -04:00
array_elem_push
Fix the KCL any type and array coercion incorrectly nesting (#6816)
2025-05-12 03:57:31 +00:00
array_elem_push_fail
Kwargs: map and reduce (#6480)
2025-04-25 19:09:03 -05:00
array_index_oob
Turn on units of measure (BREAKING CHANGE) (#6343)
2025-04-22 22:58:35 +00:00
array_push_item_wrong_type
Fix the KCL any type and array coercion incorrectly nesting (#6816)
2025-05-12 03:57:31 +00:00
array_range_expr
Fix to use correct units for array range expressions (#6837)
2025-05-12 01:30:33 -04:00
array_range_mismatch_units
Fix to use correct units for array range expressions (#6837)
2025-05-12 01:30:33 -04:00
array_range_negative_expr
Fix to use correct units for array range expressions (#6837)
2025-05-12 01:30:33 -04:00
array_range_with_units
Fix to use correct units for array range expressions (#6837)
2025-05-12 01:30:33 -04:00
artifact_graph_example_code1
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
artifact_graph_example_code_no_3d
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
artifact_graph_example_code_offset_planes
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
artifact_graph_sketch_on_face_etc
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
assembly_mixed_units_cubes
Remove false positive missing messages for other module SourceRanges (#7050)
2025-05-18 06:21:10 -04:00
assembly_non_default_units
Remove false positive missing messages for other module SourceRanges (#7050)
2025-05-18 06:21:10 -04:00
bad_units_in_annotation
Remove CallExpression support (#6639)
2025-05-02 16:08:12 -05:00
basic_fillet_cube_close_opposite
Do multiple chamfer/fillet in one API call (#6750)
2025-05-22 21:25:55 +00:00
basic_fillet_cube_end
Do multiple chamfer/fillet in one API call (#6750)
2025-05-22 21:25:55 +00:00
basic_fillet_cube_next_adjacent
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
basic_fillet_cube_previous_adjacent
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
basic_fillet_cube_start
Do multiple chamfer/fillet in one API call (#6750)
2025-05-22 21:25:55 +00:00
basic_revolve_circle
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
boolean_logical_and
Turn on units of measure (BREAKING CHANGE) (#6343)
2025-04-22 22:58:35 +00:00
boolean_logical_multiple
Turn on units of measure (BREAKING CHANGE) (#6343)
2025-04-22 22:58:35 +00:00
boolean_logical_or
Turn on units of measure (BREAKING CHANGE) (#6343)
2025-04-22 22:58:35 +00:00
circle_three_point
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
circular_pattern3d_a_pattern
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
clone_w_fillets
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
clone_w_shell
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
comparisons
Turn on units of measure (BREAKING CHANGE) (#6343)
2025-04-22 22:58:35 +00:00
comparisons_multiple
Change KCL error messages to display principal type of values (#6906)
2025-05-14 10:04:51 -04:00
computed_var
Fix the KCL any type and array coercion incorrectly nesting (#6816)
2025-05-12 03:57:31 +00:00
crazy_multi_profile
turn on the revolve test (#7075)
2025-05-19 14:51:44 -07:00
cube
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
cube_with_error
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
double_map_fn
Fix to use correct units for array range expressions (#6837)
2025-05-12 01:30:33 -04:00
error_inside_fn_also_has_source_range_of_call_site_recursive
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
error_revolve_on_edge_get_edge
turn on the revolve test (#7075)
2025-05-19 14:51:44 -07:00
error_with_point_shows_numeric_units
Add display of array element types in error messages (#7113)
2025-05-20 20:50:24 -04:00
execute_engine_error_return
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
export_var_only_at_top_level
Show error when trying to export at non-top-level (#7110)
2025-05-20 12:43:11 -04:00
fillet_duplicate_tags
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
fillet-and-shell
Do multiple chamfer/fillet in one API call (#6750)
2025-05-22 21:25:55 +00:00
flush_batch_on_end
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
function_sketch
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
function_sketch_with_position
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
helix_ccw
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
helix_simple
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
i_shape
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
if_else
Turn on units of measure (BREAKING CHANGE) (#6343)
2025-04-22 22:58:35 +00:00
import_async
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
import_constant
Fix operations to reflect concurrent module import behavior (#6568)
2025-04-30 16:26:46 +00:00
import_cycle1
Remove CallExpression support (#6639)
2025-05-02 16:08:12 -05:00
import_export
Fix operations to reflect concurrent module import behavior (#6568)
2025-04-30 16:26:46 +00:00
import_file_not_exist_error
Deterministic parallelized snaps (#6527)
2025-04-29 13:38:52 +00:00
import_file_parse_error
Deterministic parallelized snaps (#6527)
2025-04-29 13:38:52 +00:00
import_foreign
fix cache and imports (#6647)
2025-05-02 17:41:14 +00:00
import_function_not_sketch
turn on the revolve test (#7075)
2025-05-19 14:51:44 -07:00
import_glob
Display numeric units in the variables pane (#6683)
2025-05-06 03:40:18 +00:00
import_mesh_clone
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
import_only_at_top_level
test: Add regression test for importing only at the top level (#7104)
2025-05-20 11:43:48 -04:00
import_side_effect
Remove false positive missing messages for other module SourceRanges (#7050)
2025-05-18 06:21:10 -04:00
import_transform
Fix sketchOnFace point&click for booleans (#6713)
2025-05-07 08:25:12 +10:00
import_whole_simple
Remove false positive missing messages for other module SourceRanges (#7050)
2025-05-18 06:21:10 -04:00
import_whole_transitive_import
Remove false positive missing messages for other module SourceRanges (#7050)
2025-05-18 06:21:10 -04:00
index_of_array
Fix the KCL any type and array coercion incorrectly nesting (#6816)
2025-05-12 03:57:31 +00:00
inputs
Move the wasm lib, and cleanup rust directory and all references (#5585)
2025-03-01 21:59:01 +00:00
intersect_cubes
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
invalid_index_fractional
Turn on units of measure (BREAKING CHANGE) (#6343)
2025-04-22 22:58:35 +00:00
invalid_index_negative
Turn on units of measure (BREAKING CHANGE) (#6343)
2025-04-22 22:58:35 +00:00
invalid_index_str
BREAKING: Change to disallow indexing KCL records/objects with strings (#6529)
2025-04-28 12:08:47 -04:00
invalid_member_object
Change KCL error messages to display principal type of values (#6906)
2025-05-14 10:04:51 -04:00
invalid_member_object_prop
BREAKING: Change to disallow indexing KCL records/objects with strings (#6529)
2025-04-28 12:08:47 -04:00
invalid_member_object_using_string
BREAKING: Change to disallow indexing KCL records/objects with strings (#6529)
2025-04-28 12:08:47 -04:00
involute_circular_units
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
kcl_samples
Do multiple chamfer/fillet in one API call (#6750)
2025-05-22 21:25:55 +00:00
kittycad_svg
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
kw_fn
Display numeric units in the variables pane (#6683)
2025-05-06 03:40:18 +00:00
kw_fn_too_few_args
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
kw_fn_unlabeled_but_has_label
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
kw_fn_with_defaults
Display numeric units in the variables pane (#6683)
2025-05-06 03:40:18 +00:00
linear_pattern3d_a_pattern
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
loop_tag
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
mike_stress_test
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
misc
Fix to cache correct PathToNode in artifact graph (#6632)
2025-05-01 23:55:12 -04:00
module_return_using_var
Remove false positive missing messages for other module SourceRanges (#7050)
2025-05-18 06:21:10 -04:00
multi_target_csg
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
multi_transform
Declare pattern transform functions in KCL (#7057)
2025-05-20 08:25:29 +12:00
multiple-foreign-imports-all-render
Fix rendered image in subtract CSG sim test (#6812)
2025-05-09 22:27:27 +00:00
neg_xz_plane
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
nested_assembly
Add KCL importing relative to where you're importing from (#7125)
2025-05-21 00:47:32 +00:00
nested_main_kcl
allow nested files imported (#7090)
2025-05-19 22:42:25 -04:00
nested_windows_main_kcl
Restrict subdirectory imports to main.kcl (#7094)
2025-05-20 18:13:17 +12:00
non_string_key_of_object
Turn on units of measure (BREAKING CHANGE) (#6343)
2025-04-22 22:58:35 +00:00
object_prop_not_found
BREAKING: Change to disallow indexing KCL records/objects with strings (#6529)
2025-04-28 12:08:47 -04:00
out_of_band_sketches
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
outputs
KCL: Absolute point bezier curves (#7172)
2025-05-22 13:06:06 -04:00
panic_repro_cube
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
parametric
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
parametric_with_tan_arc
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
pattern_circular_in_module
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
pattern_into_union
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
pattern_linear_in_module
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
pentagon_fillet_sugar
Do multiple chamfer/fillet in one API call (#6750)
2025-05-22 21:25:55 +00:00
pipe_as_arg
Display numeric units in the variables pane (#6683)
2025-05-06 03:40:18 +00:00
pipe_substitution_inside_function_called_from_pipeline
Remove CallExpression support (#6639)
2025-05-02 16:08:12 -05:00
poop_chute
turn on the revolve test (#7075)
2025-05-19 14:51:44 -07:00
revolve_about_edge
turn on the revolve test (#7075)
2025-05-19 14:51:44 -07:00
revolve-colinear
turn on the revolve test (#7075)
2025-05-19 14:51:44 -07:00
riddle_small
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
rotate_after_fillet
Do multiple chamfer/fillet in one API call (#6750)
2025-05-22 21:25:55 +00:00
scale_after_fillet
Do multiple chamfer/fillet in one API call (#6750)
2025-05-22 21:25:55 +00:00
sketch_in_object
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
sketch_on_face
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
sketch_on_face_after_fillets_referencing_face
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
sketch_on_face_circle_tagged
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
sketch_on_face_end
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
sketch_on_face_end_negative_extrude
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
sketch_on_face_start
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
sketch_on_face_union
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
sketch-on-chamfer-two-times
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
sketch-on-chamfer-two-times-different-order
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
ssi_pattern
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
subtract_cylinder_from_cube
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
subtract_doesnt_need_brackets
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
subtract_regression00
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
subtract_regression01
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
subtract_regression02
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
subtract_regression03
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
subtract_regression04
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
subtract_regression05
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
subtract_regression06
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
subtract_regression07
turn on the revolve test (#7075)
2025-05-19 14:51:44 -07:00
subtract_regression08
allow nested files imported (#7090)
2025-05-19 22:42:25 -04:00
subtract_regression09
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
subtract_regression10
Do multiple chamfer/fillet in one API call (#6750)
2025-05-22 21:25:55 +00:00
subtract_regression11
more subtract regression tests (#7123)
2025-05-20 16:02:44 -07:00
subtract_regression12
more subtract regression tests (#7123)
2025-05-20 16:02:44 -07:00
subtract_with_pattern
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
subtract_with_pattern_cut_thru
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
tag_can_be_proxied_through_parameter
KCL: Convert x/y lines to use keyword arguments (#5615)
2025-03-07 22:07:16 -06:00
tag_proxied_through_function_does_not_define_var
KCL: Convert x/y lines to use keyword arguments (#5615)
2025-03-07 22:07:16 -06:00
tan_arc_x_line
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
tangent_to_3_point_arc
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
tangential_arc
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
translate_after_fillet
Do multiple chamfer/fillet in one API call (#6750)
2025-05-22 21:25:55 +00:00
union_cubes
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
xz_plane
Type check and coerce arguments to user functions and return values from std Rust functions (#6958)
2025-05-19 16:50:15 +12:00
simtest.tmpl
update template (#5853)
2025-03-18 01:53:32 +00:00