Louder Windows codesign errors (#4762)
* WIP: Silent failure in signWin.js Fixes #4582 * Temp: force release build * Fake throw * Temp: another test * Clean up for merge
This commit is contained in:
@ -38,7 +38,7 @@ win:
|
||||
# - arm64
|
||||
signingHashAlgorithms:
|
||||
- sha256
|
||||
sign: "./sign-win.js"
|
||||
sign: "./scripts/sign-win.js"
|
||||
publisherName: "KittyCAD Inc" # needs to be exactly like on Digicert
|
||||
icon: "assets/icon.ico"
|
||||
fileAssociations:
|
||||
|
@ -24,8 +24,7 @@ exports.default = async (configuration) => {
|
||||
|
||||
try {
|
||||
execSync(
|
||||
`smctl sign --fingerprint="${
|
||||
process.env.WINDOWS_CERTIFICATE_THUMBPRINT
|
||||
`smctl sign --fingerprint="${process.env.WINDOWS_CERTIFICATE_THUMBPRINT
|
||||
}" --input "${String(configuration.path)}"`,
|
||||
{
|
||||
stdio: 'inherit',
|
||||
@ -33,6 +32,6 @@ exports.default = async (configuration) => {
|
||||
)
|
||||
console.log('Signing using signWin.js script: successful')
|
||||
} catch (error) {
|
||||
console.error('Signing using signWin.js script: failed:', error)
|
||||
throw new Error('Signing using signWin.js script: failed:', error)
|
||||
}
|
||||
}
|
Reference in New Issue
Block a user