Louder Windows codesign errors (#4762)

* WIP: Silent failure in signWin.js
Fixes #4582

* Temp: force release build

* Fake throw

* Temp: another test

* Clean up for merge
This commit is contained in:
Pierre Jacquier
2025-01-03 12:52:55 -05:00
committed by GitHub
parent da9cae98aa
commit 36957237c0
2 changed files with 3 additions and 4 deletions

View File

@ -38,7 +38,7 @@ win:
# - arm64 # - arm64
signingHashAlgorithms: signingHashAlgorithms:
- sha256 - sha256
sign: "./sign-win.js" sign: "./scripts/sign-win.js"
publisherName: "KittyCAD Inc" # needs to be exactly like on Digicert publisherName: "KittyCAD Inc" # needs to be exactly like on Digicert
icon: "assets/icon.ico" icon: "assets/icon.ico"
fileAssociations: fileAssociations:

View File

@ -24,8 +24,7 @@ exports.default = async (configuration) => {
try { try {
execSync( execSync(
`smctl sign --fingerprint="${ `smctl sign --fingerprint="${process.env.WINDOWS_CERTIFICATE_THUMBPRINT
process.env.WINDOWS_CERTIFICATE_THUMBPRINT
}" --input "${String(configuration.path)}"`, }" --input "${String(configuration.path)}"`,
{ {
stdio: 'inherit', stdio: 'inherit',
@ -33,6 +32,6 @@ exports.default = async (configuration) => {
) )
console.log('Signing using signWin.js script: successful') console.log('Signing using signWin.js script: successful')
} catch (error) { } catch (error) {
console.error('Signing using signWin.js script: failed:', error) throw new Error('Signing using signWin.js script: failed:', error)
} }
} }