Explicitly set shell to bash for retry action in CI (#5610)
* Explicitly set shell to bash for retry action in CI * Do not run tests on dep install failure * Use single quotes for string * Had the wrong name
This commit is contained in:
		
							
								
								
									
										3
									
								
								.github/workflows/build-apps.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										3
									
								
								.github/workflows/build-apps.yml
									
									
									
									
										vendored
									
									
								
							@ -134,6 +134,7 @@ jobs:
 | 
			
		||||
        # Windows is picky sometimes and fails on fetch. Step takes about ~30s
 | 
			
		||||
        uses: nick-fields/retry@v3.0.2
 | 
			
		||||
        with:
 | 
			
		||||
          shell: bash
 | 
			
		||||
          timeout_minutes: 2
 | 
			
		||||
          max_attempts: 3
 | 
			
		||||
          command: yarn install
 | 
			
		||||
@ -185,6 +186,7 @@ jobs:
 | 
			
		||||
        # TODO: Fix electron-notarize flakes. The logs above should help gather more data on failures
 | 
			
		||||
        uses: nick-fields/retry@v3.0.2
 | 
			
		||||
        with:
 | 
			
		||||
          shell: bash
 | 
			
		||||
          timeout_minutes: 10
 | 
			
		||||
          max_attempts: 3
 | 
			
		||||
          command: yarn tronb:package:prod
 | 
			
		||||
@ -246,6 +248,7 @@ jobs:
 | 
			
		||||
        # TODO: Fix electron-notarize flakes. The logs above should help gather more data on failures
 | 
			
		||||
        uses: nick-fields/retry@v3.0.2
 | 
			
		||||
        with:
 | 
			
		||||
          shell: bash
 | 
			
		||||
          timeout_minutes: 10
 | 
			
		||||
          max_attempts: 3
 | 
			
		||||
          command: yarn tronb:package:prod
 | 
			
		||||
 | 
			
		||||
							
								
								
									
										4
									
								
								.github/workflows/e2e-tests.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										4
									
								
								.github/workflows/e2e-tests.yml
									
									
									
									
										vendored
									
									
								
							@ -51,6 +51,7 @@ jobs:
 | 
			
		||||
        node-version-file: '.nvmrc'
 | 
			
		||||
        cache: 'yarn'
 | 
			
		||||
    - name: Install dependencies
 | 
			
		||||
      id: deps-install
 | 
			
		||||
      shell: bash
 | 
			
		||||
      run: yarn
 | 
			
		||||
    - name: Cache Playwright Browsers
 | 
			
		||||
@ -193,9 +194,10 @@ jobs:
 | 
			
		||||
        path: test-results/
 | 
			
		||||
    - name: Run playwright/electron flow (with retries)
 | 
			
		||||
      id: retry
 | 
			
		||||
      if: ${{ !cancelled() && (success() || failure()) }}
 | 
			
		||||
      if: ${{ !cancelled() && steps.deps-install.outcome == 'success' }}
 | 
			
		||||
      uses: nick-fields/retry@v3.0.2
 | 
			
		||||
      with:
 | 
			
		||||
        shell: bash
 | 
			
		||||
        command: .github/ci-cd-scripts/playwright-electron.sh ${{matrix.shardIndex}} ${{matrix.shardTotal}} ${{matrix.os}}
 | 
			
		||||
        timeout_minutes: 30
 | 
			
		||||
        max_attempts: 25
 | 
			
		||||
 | 
			
		||||
		Reference in New Issue
	
	Block a user