Seeing if paneOpen is part of the run order-dependent story
This commit is contained in:
		@ -112,7 +112,8 @@ test.describe('when using the file tree to', () => {
 | 
			
		||||
      })
 | 
			
		||||
 | 
			
		||||
      const {
 | 
			
		||||
        panesOpen,
 | 
			
		||||
        openKclCodePanel,
 | 
			
		||||
        openFilePanel,
 | 
			
		||||
        createAndSelectProject,
 | 
			
		||||
        pasteCodeInEditor,
 | 
			
		||||
        createNewFileAndSelect,
 | 
			
		||||
@ -124,9 +125,9 @@ test.describe('when using the file tree to', () => {
 | 
			
		||||
      await page.setViewportSize({ width: 1200, height: 500 })
 | 
			
		||||
      page.on('console', console.log)
 | 
			
		||||
 | 
			
		||||
      await panesOpen(['files', 'code'])
 | 
			
		||||
 | 
			
		||||
      await createAndSelectProject('project-000')
 | 
			
		||||
      await openKclCodePanel()
 | 
			
		||||
      await openFilePanel()
 | 
			
		||||
      // File the main.kcl with contents
 | 
			
		||||
      const kclCube = await fsp.readFile(
 | 
			
		||||
        'src/wasm-lib/tests/executor/inputs/cube.kcl',
 | 
			
		||||
 | 
			
		||||
@ -585,6 +585,15 @@ export async function getUtils(page: Page, test_?: typeof test) {
 | 
			
		||||
      })
 | 
			
		||||
    },
 | 
			
		||||
 | 
			
		||||
    /**
 | 
			
		||||
     * @deprecated Sorry I don't have time to fix this right now, but runs like
 | 
			
		||||
     * the one linked below show me that setting the open panes in this manner is not reliable.
 | 
			
		||||
     * You can either set `openPanes` as a part of the same initScript we run in setupElectron/setup,
 | 
			
		||||
     * or you can imperatively open the panes with functions like {openKclCodePanel}
 | 
			
		||||
     * (or we can make a general openPane function that takes a paneId).,
 | 
			
		||||
     * but having a separate initScript does not seem to work reliably.
 | 
			
		||||
     * @link https://github.com/KittyCAD/modeling-app/actions/runs/10731890169/job/29762700806?pr=3807#step:20:19553
 | 
			
		||||
     */
 | 
			
		||||
    panesOpen: async (paneIds: PaneId[]) => {
 | 
			
		||||
      return test?.step(`Setting ${paneIds} panes to be open`, async () => {
 | 
			
		||||
        await page.addInitScript(
 | 
			
		||||
 | 
			
		||||
@ -379,7 +379,6 @@ test.describe('Testing settings', () => {
 | 
			
		||||
      await page.setViewportSize({ width: 1200, height: 500 })
 | 
			
		||||
      page.on('console', console.log)
 | 
			
		||||
 | 
			
		||||
 | 
			
		||||
      await test.step('Precondition: No projects exist', async () => {
 | 
			
		||||
        await expect(page.getByTestId('home-section')).toBeVisible()
 | 
			
		||||
        const projectLinksPre = page.getByTestId('project-link')
 | 
			
		||||
 | 
			
		||||
		Reference in New Issue
	
	Block a user