ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Quick follow up on share link tests (#7401)

Browse Source 
* pierremtb/adhoc-quick-sharelink-follow-up

* Update snapshots

* Update snapshots

* Remove Linux from 2000 tests

* Revert "Remove Linux from 2000 tests"

This reverts commit ad9bc58dd7.

* Remove Linux from 2000 tests and guard linux in the app too

* Revert "Remove Linux from 2000 tests and guard linux in the app too"

This reverts commit e13983eb12.

* Break out test in two

* Not

* Add debug prints

* Try to force userAgent in pw config

* Revert "Try to force userAgent in pw config"

This reverts commit d1e6d7c7be.

* Clean up

* Add sad fix

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This commit is contained in:
Pierre Jacquier
2025-06-11 13:24:38 -04:00
committed by GitHub
parent 9a549ff379
commit 5f1f579d4b
2 changed files with 17 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
e2e/playwright/share-link.spec.ts
View File

@ -20,10 +20,21 @@ function getToastError(page: Page) {
test.describe('Share link tests', () => {
test(
`Open in desktop app with 2000-long code doesn't show error on non-Windows`,
`Open in desktop app with 2000-long code works non-Windows`,
{ tag: ['@web', '@macos', '@linux'] },
async ({ page }) => {
test.skip(process.platform === 'win32')
const codeLength = 2000
await navigateAndClickOpenInDesktopApp(page, codeLength)
await expect(getToastError(page)).not.toBeVisible()
}
)
test(
`Open in desktop app with 1000-long code works on Windows`,
{ tag: ['@web', '@windows'] },
async ({ page }) => {
test.skip(process.platform !== 'win32')
const codeLength = 1000
await navigateAndClickOpenInDesktopApp(page, codeLength)
await expect(getToastError(page)).not.toBeVisible()
@ -31,15 +42,11 @@ test.describe('Share link tests', () => {
)
test(
`Open in desktop app with 1000-long code works on Windows but not with 2000`,
`Open in desktop app with 2000-long code doesn't work on Windows`,
{ tag: ['@web', '@windows'] },
async ({ page }) => {
test.skip(process.platform !== 'win32')
let codeLength = 1000
await navigateAndClickOpenInDesktopApp(page, codeLength)
await expect(getToastError(page)).not.toBeVisible()
codeLength = 2000
const codeLength = 2000
await navigateAndClickOpenInDesktopApp(page, codeLength)
await expect(getToastError(page)).toBeVisible()
}

3
src/lib/utils.ts
View File

@ -261,6 +261,9 @@ export function platform(): Platform {
if (navigator.platform === 'Windows' || navigator.platform === 'Win32') {
return 'windows'
}
if (navigator.platform?.indexOf('Linux') === 0) {
return 'linux'
}
// Chrome only, but more accurate than userAgent.
let userAgentDataPlatform: unknown