ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: Remove dead code to update the artifact graph after mock execution (#5158)

Browse Source 
Remove dead code to update the artifact graph after mock execution
This commit is contained in:
Jonathan Tran
2025-02-06 12:56:19 -05:00
committed by GitHub
parent 1c0a38a1e2
commit 6c635bd70d
1 changed files with 1 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
src/lang/KclSingleton.ts
View File

@ -422,14 +422,7 @@ export class KclManager {
// NOTE: this always updates the code state and editor.
// DO NOT CALL THIS from codemirror ever.
async executeAstMock(
ast: Program = this._ast,
{
updates,
}: {
updates: 'none' | 'artifactRanges'
} = { updates: 'none' }
) {
async executeAstMock(ast: Program = this._ast) {
await this.ensureWasmInit()
const newCode = recast(ast)
@ -459,34 +452,6 @@ export class KclManager {
this.lastSuccessfulProgramMemory = execState.memory
this.lastSuccessfulOperations = execState.operations
}
if (updates !== 'artifactRanges') return
// TODO the below seems like a work around, I wish there's a comment explaining exactly what
// problem this solves, but either way we should strive to remove it.
Array.from(this.engineCommandManager.artifactGraph).forEach(
([commandId, artifact]) => {
if (!('codeRef' in artifact && artifact.codeRef)) return
const _node1 = getNodeFromPath<Node<CallExpression | CallExpressionKw>>(
this.ast,
artifact.codeRef.pathToNode,
['CallExpression', 'CallExpressionKw']
)
if (err(_node1)) return
const { node } = _node1
if (node.type !== 'CallExpression' && node.type !== 'CallExpressionKw')
return
const [oldStart, oldEnd] = artifact.codeRef.range
if (oldStart === 0 && oldEnd === 0) return
if (oldStart === node.start && oldEnd === node.end) return
this.engineCommandManager.artifactGraph.set(commandId, {
...artifact,
codeRef: {
...artifact.codeRef,
range: topLevelRange(node.start, node.end),
},
})
}
)
}
cancelAllExecutions() {
this._cancelTokens.forEach((_, key) => {