Hack sectional

e2e/playwright/point-click.spec.ts

@@ -1435,30 +1435,42 @@ sketch002 = startSketchOn('XZ')
     // TODO: this test hits a case that happens sometimes in manual testing where
     // we can't edit the sweep right after its creation. As if the codemod didn't fully
     // register during the initall add flow.
-    // await test.step('Edit sweep via feature tree selection works', async () => {
-    //   await toolbar.openPane('feature-tree')
-    //   const operationButton = await toolbar.getFeatureTreeOperation('Sweep', 0)
-    //   await operationButton.dblclick({ button: 'left' })
-    //   await cmdBar.selectOption({ name: 'True' }).click()
-    //   await cmdBar.expectState({
-    //     commandName: 'Sweep',
-    //     headerArguments: {
-    //       Target: '1 face',
-    //       Trajectory: '1 segment',
-    //       Sectional: '',
-    //     },
-    //     stage: 'review',
-    //   })
-    //   await cmdBar.progressCmdBar()
-    //   await toolbar.closePane('feature-tree')
-    //   await toolbar.openPane('code')
-    //   await editor.expectEditor.toContain(editedSweepDeclaration)
-    //   await editor.expectState({
-    //     diagnostics: [],
-    //     activeLines: [editedSweepDeclaration],
-    //     highlightedCode: '',
-    //   })
-    // })
+    await test.step('Edit sweep via feature tree selection works', async () => {
+      await toolbar.openPane('feature-tree')
+      const operationButton = await toolbar.getFeatureTreeOperation('Sweep', 0)
+      await operationButton.dblclick({ button: 'left' })
+      await cmdBar.selectOption({ name: 'True' }).click()
+      await cmdBar.expectState({
+        commandName: 'Sweep',
+        headerArguments: {
+          Target: '1 face',
+          Trajectory: '1 segment',
+          Sectional: '',
+        },
+        stage: 'review',
+      })
+      const submitButton = page.getByRole('button', { name: 'Submit command' })
+      await submitButton.press('Shift+Backspace')
+      await cmdBar.selectOption({ name: 'True' }).click()
+      await cmdBar.expectState({
+        commandName: 'Sweep',
+        headerArguments: {
+          Target: '1 face',
+          Trajectory: '1 segment',
+          Sectional: '',
+        },
+        stage: 'review',
+      })
+      await cmdBar.progressCmdBar()
+      await toolbar.closePane('feature-tree')
+      await toolbar.openPane('code')
+      await editor.expectEditor.toContain(editedSweepDeclaration)
+      await editor.expectState({
+        diagnostics: [],
+        activeLines: [editedSweepDeclaration],
+        highlightedCode: '',
+      })
+    })
 
     await test.step('Delete sweep via feature tree selection', async () => {
       await toolbar.openPane('feature-tree')

rust/kcl-lib/src/std/extrude.rs

@@ -195,6 +195,8 @@ pub(crate) async fn do_post_extrude(
     for (curve_id, face_id) in face_infos
         .iter()
         .filter(|face_info| face_info.cap == ExtrusionFaceCapType::None)
+        // TODO: change this hack to a filtering of internal faces for sweep
+        .filter(|_face_info| false)
         .filter_map(|face_info| {
             if let (Some(curve_id), Some(face_id)) = (face_info.curve_id, face_info.face_id) {
                 Some((curve_id, face_id))