* Add display of units in UI modals with calculated KCL values
* Fix command bar display to handle units
* Add display of units in the command bar
* Fix more cases of NaN from units
* Fix to support explicit plus for exponent in scientific notation
* Fix display in autocomplete
* Change to parseFloat to be more resilient
* Add e2e test for command bar
* Change an existing test to use explicit inline units
* Fix case when input string can't be parsed
* Allow point-and-click Substract to take in multiple tools
Fixes#7612
* Change target to solids for consistency and make it support multi select too
* Improve err message
* Update src/lang/modifyAst/boolean.ts
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* Update src/lang/modifyAst/boolean.ts
Co-authored-by: Kurt Hutten <k.hutten@protonmail.ch>
* Good bot
* Reduce array to single value if len 1
* Remove console.log
---------
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: Kurt Hutten <k.hutten@protonmail.ch>
* Make sure mode-related args are hidden in point-and-click commands after option args change
Fixes#7589
* WIP improving helix flows and fixing tests
* Fix 2 more tests
* Add test step for opt arg
* Fix last helix test
* Clean up tests, hope to fix CI
Closes https://github.com/KittyCAD/engine/issues/3494. Thanks to @nadr0 for helping on the JS side.
If users set their units, the grid will stop auto scaling, and instead will be set to 10 of whatever unit they used.
If users set their units, and those units are metric, then it'll include a scale bar (see screenshot). Imperial units won't have that bar.
This behaviour is configurable via settings.
## Limitations
- The scale bar below the grid cannot be disabled in metric units, and cannot be enabled in imperial units
<img width="1690" alt="Screenshot 2025-06-05 at 7 51 41 PM" src="https://github.com/user-attachments/assets/c597087c-f96d-4c30-95f4-b3d8ba2b5567" />
* Enable optional arguments in point-and-click Sweep
Fixes#7578
* Fix bug and add e2e test step
* Fix review not triggering bug and e2e test
* WIP: Enable optional arguments in point-and-click Loft
* Add edit flow for loft
* WIP: e2e test and fix
* Got it
* Got it v2 🤦
* use face edge info for some mirrors
* add functionality for other mirror function
* Fix to create new Sketch when mirror results in a new path
* use the original ids and clone the sketches
* remove mirror param
* clippy fix
* debuggin, rm yarn
* Revert "remove mirror param"
This reverts commit a848e243f8.
* use arrbitrary edge_id as sketch mirror id
* additinoal clenaup
* Update rust/kcl-lib/src/std/mirror.rs
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* set .mirror for continuous case
* fix warning
* works without the for loops
* add error handling
* remove duplicate setter
* rm unused var
* clenaup
* unused import
* remove unused let
* Update snapshots
* Update snapshots
* cleanup
* update sim tests
---------
Co-authored-by: gserena <serena@zoo.dev>
Co-authored-by: Jonathan Tran <jonnytran@gmail.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* WIP: Add bidirectional args to point-and-click Extrude
Will eventually close#7495
* Wire up edit flow for symmetric
* Show skip true args in header in review phase
* Add bidirectionalLength
* Make currentArg always part of header
* WIP
* Add twistAng
* Proper optional args line in review
* Labels in progress button and option arg section heading
* Clean up extrude specific changes
* Clean up to separate from #7506
* Clean up to separate from #7506
* More clean up across branches
* More UI polish
* Remove options bool icon
* Fix labels for tests
* Upgrade e2e tests to cmdBar fixtures with fixes
* More fixes
* Fixed up more tests related to sweep behavior change
* Fix nodeToEdit not having hidden: true on Shell
* Add typecheck
* WIP: footer buttons
* back to reg width
* Clean up
* Update snapshots
* Update snapshots
* Clean up
* Fix tests and remove label
* Refactor
* Fix offset plane test
* Add CommandBarDivider
* Fix step back
* Update snapshots
* Add comment
* Fix it, thanks bot
* Clean up and inline optional heading
* Little case tweak
* Update src/components/CommandBar/CommandBarReview.tsx
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* Rename to CommandBarHeaderFooter
* Rename to CommandBarHeaderFooter
* Clean things up and fix edit
* Add test
* Revert something quick
* Reorg args to match kcl order
* Clean up edit arg retrieval error checks
* Lint
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* WIP: Add bidirectional args to point-and-click Extrude
Will eventually close#7495
* Wire up edit flow for symmetric
* Show skip true args in header in review phase
* Add bidirectionalLength
* Make currentArg always part of header
* WIP
* Add twistAng
* Proper optional args line in review
* Labels in progress button and option arg section heading
* Clean up extrude specific changes
* More UI polish
* Remove options bool icon
* Fix labels for tests
* Upgrade e2e tests to cmdBar fixtures with fixes
* More fixes
* Fixed up more tests related to sweep behavior change
* Fix nodeToEdit not having hidden: true on Shell
* Add typecheck
* WIP: footer buttons
* back to reg width
* Clean up
* Clean up
* Fix tests and remove label
* Refactor
* Fix offset plane test
* Add CommandBarDivider
* Fix step back
* Add comment
* Fix it, thanks bot
* Clean up and inline optional heading
* Little case tweak
* Update src/components/CommandBar/CommandBarReview.tsx
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* Rename to CommandBarHeaderFooter
---------
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* Add the 'Download the app' button back on web
Fixes#7527
* Fix staging release link in desktop app
Fixes#7513
* Update snapshots
* Update snapshots
* Update snapshots
* Add ref parsing logic and unit test
* Oops
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add edit flow to named parameters, show their value in feature tree
* Amend a feature tree test to include editing a parameter
* Enforce disallowing "create new variable" in edit parameter flow
* Add wrapping behavior! Sorry forgot to commit this
* Update src/machines/commandBarMachine.ts
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
---------
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* Add the 'Download the app' button back on web
Fixes#7527
* Update snapshots
* Update snapshots
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* move useHotkey for undo/redo into App
* _editorView should be private
* get editorView should be a real get method for consistency
* resolve tsc errors
* fmt
* setView, setState are not exposed
* make undo work without editorview when kcl pane is closed
* lint
* circular deps
* resolve circular deps
* fix undo being 1 step late
* unrelated console.warn removed
* fix undo when code pane is closed during editing
* cleanup
* allow undo to get beyond when code editor has been mounted
* fix up clearHistory
* add test for testing Undo with closed code pane
* Resurrect this branch with an initial commit
* Add telemetry to global default items
* Add credit progress bar to status bar
* Add selection info to status bar
* Add help menu to "local" side
* Rename statusBarItem utils
* Delete LowerRightControls, now unused
* fix lints
* Update snapshots
* Add test-id to network health indicator, which all E2E tests rely on
* Update src/components/StatusBar/StatusBar.tsx
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* Fix a couple little issues with the e2e tests
* Fix gizmo e2e tests (it moved) and network health test (it should not be on home page)
* More tweaks to accomodate changes to network health indicator
We made use of two test ID's to make Playwright aware of the state, one
of which was on the icon. Now that we want to normalize usage of the
status bar along a more limited API, that became a not possible. This
just tweaks some test code that relied on that fact.
* Fix lints
* Update snapshots
* Re-run CI
* Update snapshots
* Update snapshots
* Test fixes, label logic tweaks
* Update snapshots
* Update snapshots
* Fix up last few tests hopefully. Relative path syntax failed on windows
* Relative paths are behaving badly on Windows, use the old code here
* Update snapshots
* Update snapshots
* Tweak y-value to work on all platforms, ubuntu didn't like 438
* Fix tooltip and popover alignment on NetworkMachineIndicator
* Remove dire warning comment
* Update src/components/StatusBar/defaultStatusBarItems.tsx
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* @lee-at-zoo-corp feedback, pull hooks out of UI code
* Re-run CI
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* separate handling of tangentialArc with angle and radius args
* make previousEndTangent available in segment input for handling tangentialArc with angle/radius
* start adding support for editing tangentialArc with angle, radius
* draw tangentialArc sketch when using angle, radius
* fix getTanPreviousPoint when using tangentialArc with angle, radius
* fix case of unwanted negative angles when calculating angle for tangentialArc
* lint
* add test for tangentialArc dragging with andle, radius
* lint, fmt
* fix getArgForEnd for tangentialArc with radius, angle
* renaming vars
* Prompt for temporary workspace when loading external sample
* Always go into temporary workspace when loading sample
* Always go into temporary workspace even on external links
* x
* Add tests
* Fix typo
* Update snapshots
* Update snapshots
* Fix tests that now strip code param
* Fix test
* Weird...
* fmt
* x
* Add await
* agh
* Do not clear query parameters, causes more problems than not
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@franknoirot @jtran and I decided that the `extrudeTwist()` function (which I added in https://github.com/KittyCAD/modeling-app/pull/7480) would be better as an optional case of the normal `extrude` function. Doing it this way means less work for the frontend team.
* Replace tag type with tagIdent and tagDecl
Signed-off-by: Nick Cameron <nrc@ncameron.org>
* Replace tagIdent with TaggedEdge and TaggedFace
Signed-off-by: Nick Cameron <nrc@ncameron.org>
---------
Signed-off-by: Nick Cameron <nrc@ncameron.org>
* Improve docs around PI
Signed-off-by: Nick Cameron <nrc@ncameron.org>
* Refactor and polish type error messages
Signed-off-by: Nick Cameron <nrc@ncameron.org>
* Add suggestion to fix unknown numbers error
Signed-off-by: Nick Cameron <nrc@ncameron.org>
* Don't warn so often about unknown units
Signed-off-by: Nick Cameron <nrc@ncameron.org>
---------
Signed-off-by: Nick Cameron <nrc@ncameron.org>
* pierremtb/adhoc-quick-sharelink-follow-up
* Update snapshots
* Update snapshots
* Remove Linux from 2000 tests
* Revert "Remove Linux from 2000 tests"
This reverts commit ad9bc58dd7.
* Remove Linux from 2000 tests and guard linux in the app too
* Revert "Remove Linux from 2000 tests and guard linux in the app too"
This reverts commit e13983eb12.
* Break out test in two
* Not
* Add debug prints
* Try to force userAgent in pw config
* Revert "Try to force userAgent in pw config"
This reverts commit d1e6d7c7be.
* Clean up
* Add sad fix
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Change so that operations are stored per module
* Refactor so that all modeling commands go through ExecState
* Remove unneeded PartialOrd implementations
* Remove artifact_commands from KclError since it was only for debugging
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add HammerJS
* Fmt and little type cleanup
* Implement multi-touch through HammerJS
* Add velocity-decay "flick" behavior for orbit
* Update src/clientSideScene/CameraControls.ts
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* tsc fix
* Update src/clientSideScene/CameraControls.ts
Co-authored-by: Kurt Hutten <k.hutten@protonmail.ch>
* Release KCL 80 (#7391)
* Check for updates button in moar menus & toasts (#7369)
* Check for update button in more menus
Fixes#7368
* Add menubar item
* Another one
* Add Checking for updates... and No new update toasts
* Lint
* Trigger CI
* Update src/main.ts
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* Update electron-builder.yml
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* Update electron-builder.yml
* Moar clean up
---------
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* Format examples in docs (#7378)
Signed-off-by: Nick Cameron <nrc@ncameron.org>
* Fix some typos in previous PR (#7392)
Signed-off-by: Nick Cameron <nrc@ncameron.org>
* Remove the untyped getters from std::args (#7377)
* Move last uses of untypeed arg getters
Signed-off-by: Nick Cameron <nrc@ncameron.org>
* Rename _typed functions
Signed-off-by: Nick Cameron <nrc@ncameron.org>
---------
Signed-off-by: Nick Cameron <nrc@ncameron.org>
* WIP #7226 Fix remove constraints (#7304)
* handle if graphSelections is empty
* fix removeConstrainingValuesInfo by using pathToNodes if available instead of selectionRanges: current selection should not be required to remove constraints
* selectionRanges not needed for removeConstrainingValuesInfo anymore
* fix remove constraint unit test: pass line's pathToNode instead of argument to remove constraint
* Change to use artifact pathToNode (#7361)
* Change to use artifact pathToNode
* Fix to do bounds checking
* move TTC capture to unit test (#7268)
* move TTC capture to unit test
* progress with artifact
* fmt
* abstract cases
* add another case
* add another test
* update snapshots with proper file names
* force to JSON
* fmt
* make jest happy
* add another example and other tweaks
* fix
* tweak
* add logs
* more logs
* strip out kcl version
* remove logs
* add comment explainer
* more comments
* more comment
* remove package-lock line
* Add support for tag on close segment when the last sketch edge is missing (#7375)
* add test
* fix
* Update snapshots
* Update snapshots
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Use namespace for windows e2e tests (#7398)
* Use namespace for windows e2e tests
* Change to the new profile
* Remove TODO
* Commit new snapshots even if some tests failed (#7399)
* Commit new snapshots even if some tests failed
* Update snapshots
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Clean up share link tests (#7372)
* pierremtb/adhoc/clean-up-share-link-tests
* Lint
* WIP labels
* Trigger CI
* Change to skips
* Remove old docs files (#7381)
* Remove old files; no longer generated.
* Update snapshots
* Update snapshots
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jace Browning <jacebrowning@gmail.com>
* #7199 Fix broken links in docs (#7397)
* update broken links
* update github discussion links, fmt
* update comment
---------
Co-authored-by: Jace Browning <jacebrowning@gmail.com>
* Inline engine issue from @Irev-Dev
* Add commented-out test to be implemented later https://github.com/KittyCAD/modeling-app/issues/7403
* Update e2e/playwright/test-utils.ts
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
---------
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: Kurt Hutten <k.hutten@protonmail.ch>
Co-authored-by: Jonathan Tran <jonnytran@gmail.com>
Co-authored-by: Pierre Jacquier <pierrejacquier39@gmail.com>
Co-authored-by: Nick Cameron <nrc@ncameron.org>
Co-authored-by: Andrew Varga <grizzly33@gmail.com>
Co-authored-by: max <margorskyi@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jace Browning <jacebrowning@gmail.com>
Co-authored-by: Nick McCleery <34814836+nickmccleery@users.noreply.github.com>
* fix edge case of sketch not being exited out of properly
* Update e2e/playwright/sketch-tests.spec.ts
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
---------
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: Jace Browning <jacebrowning@gmail.com>
* Commit new snapshots even if some tests failed
* Update snapshots
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fix the black screen of death
* fmt
* make check
* Clean up
* Fix up zoom to fit
* Change how emulateNetworkConditions work
* Do NOT use browser's offline/online mechanisms
* Fix test
* Improve network error messages
* Signal offline when failed event comes in
* Don't use logic on components that only want a loader
* Remove unnecessary pause state transition
---------
Co-authored-by: jacebrowning <jacebrowning@gmail.com>
* fix test
* fix e2e test in another way so it doesnt break unit tests
* Cleanup
* Update src/hooks/useQueryParamEffects.ts
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* hasAskToOpen should only be used if not in desktop
---------
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* Fix orbit style setting not updating in camControls
* Break apart camera movement tests, add trackball to orbit one
* I don't think zoom was actually testing changes, this fixes that
* test refactor: pass in expected cam pos, not its inverse
* Lints
* Lint fix broke the test, fix fix
* Gah biome whyyy did you format other test names like that?
* fix bug of not saving project when dragging a segment, add a test
* Update e2e/playwright/projects.spec.ts
Co-authored-by: Jace Browning <jacebrowning@gmail.com>
---------
Co-authored-by: Jace Browning <jacebrowning@gmail.com>
