Fix to not blow away files with comments

Instead, just add a second reliable executor input file to use.

.env.development

@@ -1,6 +1,5 @@
 NODE_ENV=development
 DEV=true
-
 VITE_KC_API_WS_MODELING_URL=wss://api.dev.zoo.dev/ws/modeling/commands
 VITE_KC_API_BASE_URL=https://api.dev.zoo.dev
 VITE_KC_SITE_BASE_URL=https://dev.zoo.dev
@@ -9,5 +8,3 @@ VITE_KC_SKIP_AUTH=false
 VITE_KC_CONNECTION_TIMEOUT_MS=5000
 # ONLY add your token in .env.development.local if you want to skip auth, otherwise this token takes precedence!
 #VITE_KC_DEV_TOKEN="your token from dev.zoo.dev should go in .env.development.local"
-
-FAIL_ON_CONSOLE_ERRORS=true

.envrc

@@ -1,13 +1 @@
-# Load optional shared environment variables
-source_up_if_exists
-
-# Load default development environment variables
-dotenv .env.development
-
-# Load optional environment variables overrides
-dotenv_if_exists .env.development.local
-
-# Load optional testing environment variables
-dotenv_if_exists e2e/playwright/playwright-secrets.env
-
 use flake .

.eslintrc

@@ -20,26 +20,8 @@
       "plugin:react-hooks/recommended"
     ],
     "rules": {
-      "no-array-constructor": "off", // This is wrong; use the @typescript-eslint one instead.
-      "@typescript-eslint/no-array-constructor": "error",
-      "@typescript-eslint/no-array-delete": "error",
-      "@typescript-eslint/no-duplicate-enum-values": "error",
-      "@typescript-eslint/no-duplicate-type-constituents": "error",
-      "@typescript-eslint/no-empty-object-type": "error",
-      "@typescript-eslint/no-extra-non-null-assertion": "error",
       "@typescript-eslint/no-floating-promises": "error",
-      "@typescript-eslint/no-for-in-array": "error",
-      "no-implied-eval": "off", // This is wrong; use the @typescript-eslint one instead.
-      "@typescript-eslint/no-implied-eval": "error",
-      "@typescript-eslint/no-misused-new": "error",
       "@typescript-eslint/no-misused-promises": "error",
-      "@typescript-eslint/no-namespace": "error",
-      "@typescript-eslint/no-non-null-asserted-optional-chain": "error",
-      "@typescript-eslint/no-redundant-type-constituents": "error",
-      "@typescript-eslint/no-this-alias": "warn",
-      "@typescript-eslint/no-unnecessary-type-assertion": "error",
-      "@typescript-eslint/no-unnecessary-type-constraint": "error",
-      "no-unused-vars": "off", // This is wrong; use the @typescript-eslint one instead.
       "@typescript-eslint/no-unused-vars": ["error", {
         "varsIgnorePattern": "^_",
         "argsIgnorePattern": "^_",
@@ -47,13 +29,6 @@
         "vars": "all",
         "args": "none"
       }],
-      "@typescript-eslint/no-unsafe-unary-minus": "error",
-      "@typescript-eslint/no-wrapper-object-types": "error",
-      "no-throw-literal": "off", // Use @typescript-eslint/only-throw-error instead.
-      "@typescript-eslint/only-throw-error": "error",
-      "@typescript-eslint/prefer-as-const": "warn",
-      "@typescript-eslint/prefer-namespace-keyword": "error",
-      "@typescript-eslint/restrict-plus-operands": "error",
       "jsx-a11y/click-events-have-key-events": "off",
       "jsx-a11y/no-autofocus": "off",
       "jsx-a11y/no-noninteractive-element-interactions": "off",
@@ -62,7 +37,7 @@
         {
           "name": "isNaN",
           "message": "Use Number.isNaN() instead."
-        }
+        },
       ],
       "no-restricted-syntax": [
         "error",
@@ -76,7 +51,7 @@
         "never"
       ],
       "react-hooks/exhaustive-deps": "off",
-      "suggest-no-throw/suggest-no-throw": "error"
+      "suggest-no-throw/suggest-no-throw": "warn",
     },
     "overrides": [
       {
@@ -96,7 +71,7 @@
           "plugin:testing-library/react"
         ],
         "rules": {
-          "suggest-no-throw/suggest-no-throw": "off"
+          "suggest-no-throw/suggest-no-throw": "off",
         }
       }
     ]

.github/workflows/e2e-tests.yml

@@ -1,9 +1,7 @@
 name: E2E Tests
 on:
   push:
-    branches:
-      - main
-      - all-e2e # this bypasses `fixme()` using `orRunWhenFullSuiteEnabled()`
+    branches: [ main ]
   pull_request:
   schedule:
     - cron: 0 * * * *  # hourly
@@ -17,6 +15,7 @@ permissions:
   pull-requests: write
   actions: read
 
+
 jobs:
 
   conditions:
@@ -68,16 +67,14 @@ jobs:
       - name: Display conditions
         shell: bash
         run: |
-          # For debugging purposes
+          # For debugging purposes.
           set -euo pipefail
-          echo "GITHUB_REF: $GITHUB_REF"
-          echo "GITHUB_HEAD_REF: $GITHUB_HEAD_REF"
-          echo "GITHUB_BASE_REF: $GITHUB_BASE_REF"
           echo "significant: ${{ steps.path-changes.outputs.significant }}"
           echo "should-run: ${{ steps.should-run.outputs.should-run }}"
 
+
   prepare-wasm:
-    # separate job on Ubuntu to build or fetch the wasm blob once on the fastest runner
+    # seperate job on Ubuntu to build or fetch the wasm blob once on the fastest runner
     runs-on: runs-on=${{ github.run_id }}/family=i7ie.2xlarge/image=ubuntu22-full-x64
     needs: conditions
     steps:
@@ -162,6 +159,7 @@ jobs:
           name: prepared-wasm
           path: |
             rust/kcl-wasm-lib/pkg/kcl_wasm_lib*
+  
 
   snapshots:
     name: playwright:snapshots:ubuntu
@@ -229,6 +227,10 @@ jobs:
           timeout_minutes: 30
           max_attempts: 3
         env:
+          CI: true
+          NODE_ENV: development
+          VITE_KC_DEV_TOKEN: ${{ secrets.KITTYCAD_API_TOKEN_DEV }}
+          VITE_KC_SKIP_AUTH: true
           token: ${{ secrets.KITTYCAD_API_TOKEN_DEV }}
           snapshottoken: ${{ secrets.KITTYCAD_API_TOKEN }}
 
@@ -241,7 +243,7 @@ jobs:
           retention-days: 30
           overwrite: true
 
-      - name: Check for changes
+      - name: check for changes
         if: ${{ needs.conditions.outputs.should-run == 'true' && github.ref != 'refs/heads/main' }}
         shell: bash
         id: git-check
@@ -253,8 +255,7 @@ jobs:
             fi
 
       - name: Commit changes, if any
-        # TODO: find a more reliable way to detect visual changes
-        if: ${{ false && needs.conditions.outputs.should-run == 'true' && steps.git-check.outputs.modified == 'true' }}
+        if: ${{ needs.conditions.outputs.should-run == 'true' && steps.git-check.outputs.modified == 'true' }}
         shell: bash
         run: |
           git add e2e/playwright/snapshot-tests.spec.ts-snapshots e2e/playwright/snapshots
@@ -340,7 +341,7 @@ jobs:
         run: yarn tronb:vite:dev
 
       - name: Install vector
-        if: ${{ needs.conditions.outputs.should-run == 'true' && contains(matrix.os, 'ubuntu') }}
+        if: contains(matrix.os, 'ubuntu')
         shell: bash
         run: |
           curl --proto '=https' --tlsv1.2 -sSfL https://sh.vector.dev > /tmp/vector.sh
@@ -373,7 +374,11 @@ jobs:
           timeout_minutes: 45
           max_attempts: 15
         env:
+          CI: true
           FAIL_ON_CONSOLE_ERRORS: true
+          NODE_ENV: development
+          VITE_KC_DEV_TOKEN: ${{ secrets.KITTYCAD_API_TOKEN_DEV }}
+          VITE_KC_SKIP_AUTH: true
           token: ${{ secrets.KITTYCAD_API_TOKEN_DEV }}
 
       - uses: actions/upload-artifact@v4

.github/workflows/static-analysis.yml

@@ -28,87 +28,43 @@ jobs:
       - run: yarn fmt-check
 
   yarn-build-wasm:
-    # Build the wasm blob once on the fastest runner.
-    runs-on: runs-on=${{ github.run_id }}/family=i7ie.2xlarge/image=ubuntu22-full-x64
+    runs-on: ubuntu-22.04
+
     steps:
       - uses: actions/checkout@v4
-
       - uses: actions/setup-node@v4
         with:
           node-version-file: '.nvmrc'
           cache: 'yarn'
-
-      - name: Install dependencies
-        run: yarn install
-
-      - name: Use correct Rust toolchain
-        shell: bash
-        run: |
-          [ -e rust-toolchain.toml ] || cp rust/rust-toolchain.toml ./
-
-      - name: Install rust
-        uses: actions-rust-lang/setup-rust-toolchain@v1
+      - run: yarn install
+      - uses: taiki-e/install-action@37bdc826eaedac215f638a96472df572feab0f9b
         with:
-          cache: false # Configured below.
+          tool: wasm-pack
+      - run: yarn build:wasm
+
+  yarn-tsc:
+    runs-on: ubuntu-22.04
+
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version-file: '.nvmrc'
+          cache: 'yarn'
+      - run: yarn install
+      - run: yarn --cwd ./rust/kcl-language-server --modules-folder node_modules install
+      - uses: Swatinem/rust-cache@v2
+        with:
+          workspaces: './rust'
 
       - uses: taiki-e/install-action@37bdc826eaedac215f638a96472df572feab0f9b
         with:
           tool: wasm-pack
-
-      - name: Rust Cache
-        uses: Swatinem/rust-cache@v2
-        with:
-          workspaces: './rust'
-
-      - name: Build Wasm
-        shell: bash
-        run: yarn build:wasm
-
-      - uses: actions/upload-artifact@v4
-        with:
-          name: prepared-wasm
-          path: |
-            rust/kcl-wasm-lib/pkg/kcl_wasm_lib*
-
-      - uses: actions/upload-artifact@v4
-        with:
-          name: prepared-ts-rs-bindings
-          path: |
-            rust/kcl-lib/bindings/*
-
-  yarn-tsc:
-    runs-on: ubuntu-latest
-    needs: yarn-build-wasm
-
-    steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-node@v4
-        with:
-          node-version-file: '.nvmrc'
-          cache: 'yarn'
-      - run: yarn install
-
-      - name: Download all artifacts
-        uses: actions/download-artifact@v4
-
-      - name: Copy prepared wasm
-        run: |
-          ls -R prepared-wasm
-          cp prepared-wasm/kcl_wasm_lib_bg.wasm public
-          mkdir rust/kcl-wasm-lib/pkg
-          cp prepared-wasm/kcl_wasm_lib* rust/kcl-wasm-lib/pkg
-
-      - name: Copy prepared ts-rs bindings
-        run: |
-          ls -R prepared-ts-rs-bindings
-          mkdir rust/kcl-lib/bindings
-          cp -r prepared-ts-rs-bindings/* rust/kcl-lib/bindings/
-
+      - run: yarn build:wasm
       - run: yarn tsc
 
   yarn-lint:
-    runs-on: ubuntu-latest
-    needs: yarn-build-wasm
+    runs-on: ubuntu-22.04
 
     steps:
       - uses: actions/checkout@v4
@@ -117,23 +73,7 @@ jobs:
           node-version-file: '.nvmrc'
           cache: 'yarn'
       - run: yarn install
-
-      - name: Download all artifacts
-        uses: actions/download-artifact@v4
-
-      - name: Copy prepared wasm
-        run: |
-          ls -R prepared-wasm
-          cp prepared-wasm/kcl_wasm_lib_bg.wasm public
-          mkdir rust/kcl-wasm-lib/pkg
-          cp prepared-wasm/kcl_wasm_lib* rust/kcl-wasm-lib/pkg
-
-      - name: Copy prepared ts-rs bindings
-        run: |
-          ls -R prepared-ts-rs-bindings
-          mkdir rust/kcl-lib/bindings
-          cp -r prepared-ts-rs-bindings/* rust/kcl-lib/bindings/
-
+      - run: yarn --cwd ./rust/kcl-language-server --modules-folder node_modules install
       - run: yarn lint
 
   python-codespell:
@@ -151,7 +91,6 @@ jobs:
 
   yarn-unit-test-kcl-samples:
     runs-on: ubuntu-latest
-    needs: yarn-build-wasm
     steps:
       - uses: actions/checkout@v4
 
@@ -164,22 +103,7 @@ jobs:
       - uses: taiki-e/install-action@37bdc826eaedac215f638a96472df572feab0f9b
         with:
           tool: wasm-pack
-
-      - name: Download all artifacts
-        uses: actions/download-artifact@v4
-
-      - name: Copy prepared wasm
-        run: |
-          ls -R prepared-wasm
-          cp prepared-wasm/kcl_wasm_lib_bg.wasm public
-          mkdir rust/kcl-wasm-lib/pkg
-          cp prepared-wasm/kcl_wasm_lib* rust/kcl-wasm-lib/pkg
-
-      - name: Copy prepared ts-rs bindings
-        run: |
-          ls -R prepared-ts-rs-bindings
-          mkdir rust/kcl-lib/bindings
-          cp -r prepared-ts-rs-bindings/* rust/kcl-lib/bindings/
+      - run: yarn build:wasm
 
       - run: yarn simpleserver:bg
         if: ${{ github.event_name != 'release' && github.event_name != 'schedule' }}
@@ -196,7 +120,6 @@ jobs:
 
   yarn-unit-test:
     runs-on: ubuntu-latest
-    needs: yarn-build-wasm
     steps:
       - uses: actions/checkout@v4
 
@@ -209,22 +132,7 @@ jobs:
       - uses: taiki-e/install-action@37bdc826eaedac215f638a96472df572feab0f9b
         with:
           tool: wasm-pack
-
-      - name: Download all artifacts
-        uses: actions/download-artifact@v4
-
-      - name: Copy prepared wasm
-        run: |
-          ls -R prepared-wasm
-          cp prepared-wasm/kcl_wasm_lib_bg.wasm public
-          mkdir rust/kcl-wasm-lib/pkg
-          cp prepared-wasm/kcl_wasm_lib* rust/kcl-wasm-lib/pkg
-
-      - name: Copy prepared ts-rs bindings
-        run: |
-          ls -R prepared-ts-rs-bindings
-          mkdir rust/kcl-lib/bindings
-          cp -r prepared-ts-rs-bindings/* rust/kcl-lib/bindings/
+      - run: yarn build:wasm
 
       - run: yarn simpleserver:bg
         if: ${{ github.event_name != 'release' && github.event_name != 'schedule' }}
@@ -233,13 +141,13 @@ jobs:
         if: ${{ github.event_name != 'release' && github.event_name != 'schedule' }}
         run: yarn playwright install chromium --with-deps
 
-      - name: Run unit tests
+      - name: run unit tests
         if: ${{ github.event_name != 'release' && github.event_name != 'schedule' }}
         run: xvfb-run -a yarn test:unit
         env:
           VITE_KC_DEV_TOKEN: ${{ secrets.KITTYCAD_API_TOKEN_DEV }}
 
-      - name: Check for changes
+      - name: check for changes
         if: ${{ github.event_name != 'release' && github.event_name != 'schedule' }}
         id: git-check
         run: |

.github/workflows/update-e2e-branch.yml

@@ -14,32 +14,16 @@ permissions:
 jobs:
   update-branch:
     runs-on: ubuntu-latest
+
     steps:
-      - uses: actions/create-github-app-token@v1
-        id: app-token
-        with:
-          app-id: ${{ secrets.MODELING_APP_GH_APP_ID }}
-          private-key: ${{ secrets.MODELING_APP_GH_APP_PRIVATE_KEY }}
-          owner: ${{ github.repository_owner }}
-
       - uses: actions/checkout@v4
-        with:
-          token: ${{ steps.app-token.outputs.token }}
-
-      - name: Sync with main
+      - shell: bash
         run: |
-          # Create the branch
+          # checkout our branch
           git checkout all-e2e || git checkout -b all-e2e
-
-          # Reset to main
+          # fetch origin
           git fetch origin
+          # reset to main
           git reset --hard origin/main
-
-          # Get a new SHA to prevent overwriting the commit status on main
-          git config --local user.email "github-actions[bot]@users.noreply.github.com"
-          git config --local user.name "github-actions[bot]"
-          git commit --allow-empty --message="[all-e2e] $(git log --max-count=1 --pretty=%B)"
-
-          # Overwrite the branch
-          git remote set-url origin https://x-access-token:${{ steps.app-token.outputs.token }}@github.com/${{ github.repository }}.git
+          # force push it
           git push --force origin all-e2e

Makefile

@@ -20,12 +20,8 @@ $(WASM_PACK):
 ###############################################################################
 # BUILD
 
-CARGO_SOURCES := rust/.cargo/config.toml $(wildcard rust/Cargo.*) $(wildcard rust/**/Cargo.*)
-RUST_SOURCES := $(wildcard rust/**/*.rs)
-
-REACT_SOURCES := $(wildcard src/*.tsx) $(wildcard src/**/*.tsx)
-TYPESCRIPT_SOURCES := tsconfig.* $(wildcard src/*.ts) $(wildcard src/**/*.ts)
-VITE_SOURCES := $(wildcard vite.*) $(wildcard vite/**/*.tsx)
+RUST_SOURCES := $(wildcard rust/*) $(wildcard rust/**/*)
+TYPESCRIPT_SOURCES := $(wildcard src/**/*.tsx) $(wildcard src/**/*.ts)
 
 .PHONY: build
 build: build-web build-desktop
@@ -36,13 +32,13 @@ build-web: public/kcl_wasm_lib_bg.wasm build/index.html
 .PHONY: build-desktop
 build-desktop: public/kcl_wasm_lib_bg.wasm .vite/build/main.js
 
-public/kcl_wasm_lib_bg.wasm: $(CARGO_SOURCES)$(RUST_SOURCES)
-	yarn build:wasm:dev
+public/kcl_wasm_lib_bg.wasm: $(RUST_SOURCES)
+	yarn build:wasm
 
-build/index.html: $(REACT_SOURCES) $(TYPESCRIPT_SOURCES) $(VITE_SOURCES)
+build/index.html: $(TYPESCRIPT_SOURCES)
 	yarn build:local
 
-.vite/build/main.js: $(REACT_SOURCES) $(TYPESCRIPT_SOURCES) $(VITE_SOURCES)
+.vite/build/main.js: $(TYPESCRIPT_SOURCES)
 	yarn tronb:vite:dev
 
 ###############################################################################
@@ -77,29 +73,19 @@ run-desktop: install build-desktop ## Start the desktop app
 ###############################################################################
 # TEST
 
-E2E_WORKERS ?= 1
-E2E_FAILURES ?= 1
-E2E_GREP ?= ""
+GREP ?= ""
 
 .PHONY: test
 test: test-unit test-e2e
 
 .PHONY: test-unit
 test-unit: install ## Run the unit tests
-	@ curl -fs localhost:3000 >/dev/null || ( echo "Error: localhost:3000 not available, 'make run-web' first" && exit 1 )
+	@ nc -z localhost 3000 || ( echo "Error: localhost:3000 not available, 'make run-web' first" && exit 1 )
 	yarn test:unit
 
 .PHONY: test-e2e
-test-e2e: test-e2e-desktop
-
-.PHONY: test-e2e-web
-test-e2e-web: install build-web ## Run the web e2e tests
-	@ curl -fs localhost:3000 >/dev/null || ( echo "Error: localhost:3000 not available, 'make run-web' first" && exit 1 )
-	yarn chrome:test --headed --workers=$(E2E_WORKERS) --max-failures=$(E2E_FAILURES) --grep=$(E2E_GREP)
-
-.PHONY: test-e2e-desktop
-test-e2e-desktop: install build-desktop ## Run the desktop e2e tests
-	yarn test:playwright:electron --workers=$(E2E_WORKERS) --max-failures=$(E2E_FAILURES) --grep="$(E2E_GREP)"
+test-e2e: install build-desktop ## Run the e2e tests
+	yarn test:playwright:electron --workers=1 --grep=$(GREP)
 
 ###############################################################################
 # CLEAN

docs/kcl/circleThreePoint.md

@@ -10,10 +10,10 @@ Construct a circle derived from 3 points.
 
 ```js
 circleThreePoint(
-  sketchSurfaceOrGroup: SketchOrSurface,
   p1: [number],
   p2: [number],
   p3: [number],
+  sketchSurfaceOrGroup: SketchOrSurface,
   tag?: TagDeclarator,
 ): Sketch
 ```
@@ -23,10 +23,10 @@ circleThreePoint(
 
 | Name | Type | Description | Required |
 |----------|------|-------------|----------|
-| `sketchSurfaceOrGroup` | [`SketchOrSurface`](/docs/kcl/types/SketchOrSurface) | Plane or surface to sketch on. | Yes |
 | `p1` | [`[number]`](/docs/kcl/types/number) | 1st point to derive the circle. | Yes |
 | `p2` | [`[number]`](/docs/kcl/types/number) | 2nd point to derive the circle. | Yes |
 | `p3` | [`[number]`](/docs/kcl/types/number) | 3rd point to derive the circle. | Yes |
+| `sketchSurfaceOrGroup` | [`SketchOrSurface`](/docs/kcl/types/SketchOrSurface) | Plane or surface to sketch on. | Yes |
 | [`tag`](/docs/kcl/types/tag) | [`TagDeclarator`](/docs/kcl/types#tag-declaration) | Identifier for the circle to reference elsewhere. | No |
 
 ### Returns

docs/kcl/consts.md

@@ -9,9 +9,13 @@ layout: manual
 
 ### `std`
 
+- [`HALF_TURN`](/docs/kcl/consts/std-HALF_TURN)
+- [`QUARTER_TURN`](/docs/kcl/consts/std-QUARTER_TURN)
+- [`THREE_QUARTER_TURN`](/docs/kcl/consts/std-THREE_QUARTER_TURN)
 - [`XY`](/docs/kcl/consts/std-XY)
 - [`XZ`](/docs/kcl/consts/std-XZ)
 - [`YZ`](/docs/kcl/consts/std-YZ)
+- [`ZERO`](/docs/kcl/consts/std-ZERO)
 
 ### `std::math`
 
@@ -19,10 +23,3 @@ layout: manual
 - [`PI`](/docs/kcl/consts/std-math-PI)
 - [`TAU`](/docs/kcl/consts/std-math-TAU)
 
-### `std::turns`
-
-- [`HALF_TURN`](/docs/kcl/consts/std-turns-HALF_TURN)
-- [`QUARTER_TURN`](/docs/kcl/consts/std-turns-QUARTER_TURN)
-- [`THREE_QUARTER_TURN`](/docs/kcl/consts/std-turns-THREE_QUARTER_TURN)
-- [`ZERO`](/docs/kcl/consts/std-turns-ZERO)
-

docs/kcl/consts/std-HALF_TURN.md

@@ -0,0 +1,15 @@
+---
+title: "std::HALF_TURN"
+excerpt: ""
+layout: manual
+---
+
+
+
+
+
+```js
+std::HALF_TURN: number(deg) = 180deg
+```
+
+

docs/kcl/consts/std-QUARTER_TURN.md

@@ -0,0 +1,15 @@
+---
+title: "std::QUARTER_TURN"
+excerpt: ""
+layout: manual
+---
+
+
+
+
+
+```js
+std::QUARTER_TURN: number(deg) = 90deg
+```
+
+

docs/kcl/consts/std-THREE_QUARTER_TURN.md

@@ -0,0 +1,15 @@
+---
+title: "std::THREE_QUARTER_TURN"
+excerpt: ""
+layout: manual
+---
+
+
+
+
+
+```js
+std::THREE_QUARTER_TURN: number(deg) = 270deg
+```
+
+

docs/kcl/consts/std-ZERO.md

@@ -0,0 +1,15 @@
+---
+title: "std::ZERO"
+excerpt: ""
+layout: manual
+---
+
+
+
+
+
+```js
+std::ZERO: number = 0
+```
+
+

docs/kcl/consts/std-math-E.md

@@ -15,7 +15,7 @@ std::math::E: number = 2.71828182845904523536028747135266250_
 ### Examples
 
 ```js
-exampleSketch = startSketchOn(XZ)
+exampleSketch = startSketchOn("XZ")
   |> startProfileAt([0, 0], %)
   |> angledLine({
     angle = 30,

docs/kcl/consts/std-math-PI.md

@@ -17,7 +17,7 @@ std::math::PI: number = 3.14159265358979323846264338327950288_
 ```js
 circumference = 70
 
-exampleSketch = startSketchOn(XZ)
+exampleSketch = startSketchOn("XZ")
  |> circle(center = [0, 0], radius = circumference/ (2 * PI))
 
 example = extrude(exampleSketch, length = 5)

docs/kcl/consts/std-math-TAU.md

@@ -15,7 +15,7 @@ std::math::TAU: number = 6.28318530717958647692528676655900577_
 ### Examples
 
 ```js
-exampleSketch = startSketchOn(XZ)
+exampleSketch = startSketchOn("XZ")
   |> startProfileAt([0, 0], %)
   |> angledLine({
     angle = 50,

docs/kcl/consts/std-turns-HALF_TURN.md

@@ -1,15 +0,0 @@
----
-title: "std::turns::HALF_TURN"
-excerpt: ""
-layout: manual
----
-
-
-
-
-
-```js
-std::turns::HALF_TURN: number(deg) = 180deg
-```
-
-

docs/kcl/consts/std-turns-QUARTER_TURN.md

@@ -1,15 +0,0 @@
----
-title: "std::turns::QUARTER_TURN"
-excerpt: ""
-layout: manual
----
-
-
-
-
-
-```js
-std::turns::QUARTER_TURN: number(deg) = 90deg
-```
-
-

docs/kcl/consts/std-turns-THREE_QUARTER_TURN.md

@@ -1,15 +0,0 @@
----
-title: "std::turns::THREE_QUARTER_TURN"
-excerpt: ""
-layout: manual
----
-
-
-
-
-
-```js
-std::turns::THREE_QUARTER_TURN: number(deg) = 270deg
-```
-
-

docs/kcl/consts/std-turns-ZERO.md

@@ -1,15 +0,0 @@
----
-title: "std::turns::ZERO"
-excerpt: ""
-layout: manual
----
-
-
-
-
-
-```js
-std::turns::ZERO: number = 0
-```
-
-

docs/kcl/index.md

@@ -23,15 +23,19 @@ layout: manual
   * [`tag`](kcl/types/tag)
 * **std**
   * [`Face`](kcl/types/Face)
+  * [`HALF_TURN`](kcl/consts/std-HALF_TURN)
   * [`Helix`](kcl/types/Helix)
   * [`Plane`](kcl/types/Plane)
   * [`Point2d`](kcl/types/Point2d)
   * [`Point3d`](kcl/types/Point3d)
+  * [`QUARTER_TURN`](kcl/consts/std-QUARTER_TURN)
   * [`Sketch`](kcl/types/Sketch)
   * [`Solid`](kcl/types/Solid)
+  * [`THREE_QUARTER_TURN`](kcl/consts/std-THREE_QUARTER_TURN)
   * [`XY`](kcl/consts/std-XY)
   * [`XZ`](kcl/consts/std-XZ)
   * [`YZ`](kcl/consts/std-YZ)
+  * [`ZERO`](kcl/consts/std-ZERO)
   * [`abs`](kcl/abs)
   * [`acos`](kcl/acos)
   * [`angleToMatchLengthX`](kcl/angleToMatchLengthX)
@@ -57,6 +61,7 @@ layout: manual
   * [`bezierCurve`](kcl/bezierCurve)
   * [`ceil`](kcl/ceil)
   * [`chamfer`](kcl/chamfer)
+  * [`circle`](kcl/circle)
   * [`circleThreePoint`](kcl/circleThreePoint)
   * [`close`](kcl/close)
   * [`cm`](kcl/cm)
@@ -69,6 +74,7 @@ layout: manual
   * [`getOppositeEdge`](kcl/getOppositeEdge)
   * [`getPreviousAdjacentEdge`](kcl/getPreviousAdjacentEdge)
   * [`helix`](kcl/helix)
+  * [`helixRevolutions`](kcl/helixRevolutions)
   * [`hole`](kcl/hole)
   * [`hollow`](kcl/hollow)
   * [`inch`](kcl/inch)
@@ -140,10 +146,3 @@ layout: manual
   * [`cos`](kcl/std-math-cos)
   * [`sin`](kcl/std-math-sin)
   * [`tan`](kcl/std-math-tan)
-* **std::sketch**
-  * [`circle`](kcl/std-sketch-circle)
-* **std::turns**
-  * [`turns::HALF_TURN`](kcl/consts/std-turns-HALF_TURN)
-  * [`turns::QUARTER_TURN`](kcl/consts/std-turns-QUARTER_TURN)
-  * [`turns::THREE_QUARTER_TURN`](kcl/consts/std-turns-THREE_QUARTER_TURN)
-  * [`turns::ZERO`](kcl/consts/std-turns-ZERO)

docs/kcl/rotate.md

@@ -6,10 +6,6 @@ layout: manual
 
 Rotate a solid or a sketch.
 
-This is really useful for assembling parts together. You can create a part and then rotate it to the correct orientation.
-
-For sketches, you can use this to rotate a sketch and then loft it with another sketch.
-
 ### Using Roll, Pitch, and Yaw
 
 When rotating a part in 3D space, "roll," "pitch," and "yaw" refer to the three rotational axes used to describe its orientation: roll is rotation around the longitudinal axis (front-to-back), pitch is rotation around the lateral axis (wing-to-wing), and yaw is rotation around the vertical axis (up-down); essentially, it's like tilting the part on its side (roll), tipping the nose up or down (pitch), and turning it left or right (yaw).
@@ -170,7 +166,7 @@ fn square() {
 profile001 = square()
 
 profile002 = square()
-  |> translate(x = 0, y = 0, z = 20)
+  |> translate(translate = [0, 0, 20])
   |> rotate(axis = [0, 0, 1.0], angle = 45)
 
 loft([profile001, profile002])

docs/kcl/std-math-cos.md

@@ -9,7 +9,7 @@ Compute the cosine of a number (in radians).
 
 
 ```js
-cos(@num: number(rad)): number(_)
+cos(num: number(rad)): number(_)
 ```
 
 
@@ -27,7 +27,7 @@ cos(@num: number(rad)): number(_)
 ### Examples
 
 ```js
-exampleSketch = startSketchOn(XZ)
+exampleSketch = startSketchOn("XZ")
   |> startProfileAt([0, 0], %)
   |> angledLine({
     angle = 30,

docs/kcl/std-math-sin.md

@@ -9,7 +9,7 @@ Compute the sine of a number (in radians).
 
 
 ```js
-sin(@num: number(rad)): number(_)
+sin(num: number(rad)): number(_)
 ```
 
 
@@ -27,7 +27,7 @@ sin(@num: number(rad)): number(_)
 ### Examples
 
 ```js
-exampleSketch = startSketchOn(XZ)
+exampleSketch = startSketchOn("XZ")
   |> startProfileAt([0, 0], %)
   |> angledLine({
     angle = 50,

docs/kcl/std-math-tan.md

@@ -9,7 +9,7 @@ Compute the tangent of a number (in radians).
 
 
 ```js
-tan(@num: number(rad)): number(_)
+tan(num: number(rad)): number(_)
 ```
 
 
@@ -27,7 +27,7 @@ tan(@num: number(rad)): number(_)
 ### Examples
 
 ```js
-exampleSketch = startSketchOn(XZ)
+exampleSketch = startSketchOn("XZ")
   |> startProfileAt([0, 0], %)
   |> angledLine({
     angle = 50,

docs/kcl/types/ExtrudeSurface.md

@@ -28,7 +28,7 @@ An extrude plane.
 | `faceId` |[`string`](/docs/kcl/types/string)| The face id for the extrude plane. | No |
 | [`tag`](/docs/kcl/types/tag) |[`TagDeclarator`](/docs/kcl/types#tag-declaration)| The tag. | No |
 | `id` |[`string`](/docs/kcl/types/string)| The id of the geometry. | No |
-| `sourceRange` |`[integer, integer, integer]`| The source range. | No |
+| `sourceRange` |[`SourceRange`](/docs/kcl/types/SourceRange)| The source range. | No |
 
 
 ----
@@ -48,7 +48,7 @@ An extruded arc.
 | `faceId` |[`string`](/docs/kcl/types/string)| The face id for the extrude plane. | No |
 | [`tag`](/docs/kcl/types/tag) |[`TagDeclarator`](/docs/kcl/types#tag-declaration)| The tag. | No |
 | `id` |[`string`](/docs/kcl/types/string)| The id of the geometry. | No |
-| `sourceRange` |`[integer, integer, integer]`| The source range. | No |
+| `sourceRange` |[`SourceRange`](/docs/kcl/types/SourceRange)| The source range. | No |
 
 
 ----
@@ -68,7 +68,7 @@ Geometry metadata.
 | `faceId` |[`string`](/docs/kcl/types/string)| The id for the chamfer surface. | No |
 | [`tag`](/docs/kcl/types/tag) |[`TagDeclarator`](/docs/kcl/types#tag-declaration)| The tag. | No |
 | `id` |[`string`](/docs/kcl/types/string)| The id of the geometry. | No |
-| `sourceRange` |`[integer, integer, integer]`| The source range. | No |
+| `sourceRange` |[`SourceRange`](/docs/kcl/types/SourceRange)| The source range. | No |
 
 
 ----
@@ -88,7 +88,7 @@ Geometry metadata.
 | `faceId` |[`string`](/docs/kcl/types/string)| The id for the fillet surface. | No |
 | [`tag`](/docs/kcl/types/tag) |[`TagDeclarator`](/docs/kcl/types#tag-declaration)| The tag. | No |
 | `id` |[`string`](/docs/kcl/types/string)| The id of the geometry. | No |
-| `sourceRange` |`[integer, integer, integer]`| The source range. | No |
+| `sourceRange` |[`SourceRange`](/docs/kcl/types/SourceRange)| The source range. | No |
 
 
 ----

docs/kcl/types/GeoMeta.md

@@ -17,6 +17,6 @@ Geometry metadata.
 | Property | Type | Description | Required |
 |----------|------|-------------|----------|
 | `id` |[`string`](/docs/kcl/types/string)| The id of the geometry. | No |
-| `sourceRange` |`[integer, integer, integer]`| The source range. | No |
+| `sourceRange` |[`SourceRange`](/docs/kcl/types/SourceRange)| The source range. | No |
 
 

docs/kcl/types/HelixValue.md

@@ -17,11 +17,10 @@ A helix.
 | Property | Type | Description | Required |
 |----------|------|-------------|----------|
 | `value` |[`string`](/docs/kcl/types/string)| The id of the helix. | No |
-| `artifactId` |[`string`](/docs/kcl/types/string)| The artifact ID. | No |
+| `artifactId` |[`ArtifactId`](/docs/kcl/types/ArtifactId)| The artifact ID. | No |
 | `revolutions` |[`number`](/docs/kcl/types/number)| Number of revolutions. | No |
 | `angleStart` |[`number`](/docs/kcl/types/number)| Start angle (in degrees). | No |
 | `ccw` |`boolean`| Is the helix rotation counter clockwise? | No |
-| `cylinderId` |[`string`](/docs/kcl/types/string)| The cylinder the helix was created on. | No |
 | `units` |[`UnitLen`](/docs/kcl/types/UnitLen)| A unit of length. | No |
 
 

docs/kcl/types/KclValue.md

@@ -285,7 +285,7 @@ Data for an imported geometry.
 | Property | Type | Description | Required |
 |----------|------|-------------|----------|
 | `type` |enum: `Module`|  | No |
-| `value` |`integer`| Identifier of a source file.  Uses a u32 to keep the size small. | No |
+| `value` |[`ModuleId`](/docs/kcl/types/ModuleId)| Identifier of a source file.  Uses a u32 to keep the size small. | No |
 
 
 ----

docs/kcl/types/Point2d.md

@@ -10,8 +10,8 @@ A point in two dimensional space.
 type Point2d = [number; 2]
 ```
 
-[`Point2d`](/docs/kcl/types/Point2d) is an alias for a two-element array of [number](/docs/kcl/types/number)s. To write a value
-with type [`Point2d`](/docs/kcl/types/Point2d), use an array, e.g., `[0, 0]` or `[5.0, 3.14]`.
+`Point2d` is an alias for a two-element array of [number](/docs/kcl/types/number)s. To write a value
+with type `Point2d`, use an array, e.g., `[0, 0]` or `[5.0, 3.14]`.
 
 
 

docs/kcl/types/Point3d.md

@@ -10,8 +10,8 @@ A point in three dimensional space.
 type Point3d = [number; 3]
 ```
 
-[`Point3d`](/docs/kcl/types/Point3d) is an alias for a three-element array of [number](/docs/kcl/types/number)s. To write a value
-with type [`Point3d`](/docs/kcl/types/Point3d), use an array, e.g., `[0, 0, 0]` or `[5.0, 3.14, 6.8]`.
+`Point3d` is an alias for a three-element array of [number](/docs/kcl/types/number)s. To write a value
+with type `Point3d`, use an array, e.g., `[0, 0, 0]` or `[5.0, 3.14, 6.8]`.
 
 
 

docs/kcl/types/PolarCoordsData.md

@@ -17,6 +17,6 @@ Data for polar coordinates.
 | Property | Type | Description | Required |
 |----------|------|-------------|----------|
 | `angle` |[`number`](/docs/kcl/types/number)| The angle of the line (in degrees). | No |
-| `length` |[`number`](/docs/kcl/types/number)| The length of the line. | No |
+| `length` |[`TyF64`](/docs/kcl/types/TyF64)| The length of the line. | No |
 
 

docs/kcl/types/Sketch.md

@@ -17,7 +17,7 @@ mySketch = startSketchOn('XY')
     |> close()
 ```
 
-The `mySketch` variable will be an executed [`Sketch`](/docs/kcl/types/Sketch) object. Executed being past
+The `mySketch` variable will be an executed `Sketch` object. Executed being past
 tense, because the engine has already executed the commands to create the sketch.
 
 The previous sketch commands will never be executed again, in this case.

docs/kcl/types/SketchSurface.md

@@ -25,7 +25,7 @@ A sketch type.
 |----------|------|-------------|----------|
 | `type` |enum: `plane`|  | No |
 | `id` |[`string`](/docs/kcl/types/string)| The id of the plane. | No |
-| `artifactId` |[`string`](/docs/kcl/types/string)| The artifact ID. | No |
+| `artifactId` |[`ArtifactId`](/docs/kcl/types/ArtifactId)| The artifact ID. | No |
 | `value` |[`PlaneType`](/docs/kcl/types/PlaneType)| Type for a plane. | No |
 | `origin` |[`Point3d`](/docs/kcl/types/Point3d)| Origin of the plane. | No |
 | `xAxis` |[`Point3d`](/docs/kcl/types/Point3d)| What should the plane's X axis be? | No |
@@ -49,7 +49,7 @@ A face.
 |----------|------|-------------|----------|
 | `type` |enum: `face`|  | No |
 | `id` |[`string`](/docs/kcl/types/string)| The id of the face. | No |
-| `artifactId` |[`string`](/docs/kcl/types/string)| The artifact ID. | No |
+| `artifactId` |[`ArtifactId`](/docs/kcl/types/ArtifactId)| The artifact ID. | No |
 | `value` |[`string`](/docs/kcl/types/string)| The tag of the face. | No |
 | `xAxis` |[`Point3d`](/docs/kcl/types/Point3d)| What should the face's X axis be? | No |
 | `yAxis` |[`Point3d`](/docs/kcl/types/Point3d)| What should the face's Y axis be? | No |

docs/kcl/types/Solid.md

@@ -18,7 +18,7 @@ myPart = startSketchOn('XY')
     |> extrude(length = 6)
 ```
 
-The `myPart` variable will be an executed [`Solid`](/docs/kcl/types/Solid) object. Executed being past
+The `myPart` variable will be an executed `Solid` object. Executed being past
 tense, because the engine has already executed the commands to create the solid.
 
 The previous solid commands will never be executed again, in this case.

docs/kcl/types/SourceRange.md

@@ -0,0 +1,15 @@
+---
+title: "SourceRange"
+excerpt: ""
+layout: manual
+---
+
+
+**Type:** `integer` (`uint`)
+
+
+
+
+
+
+

docs/kcl/types/TyF64.md

@@ -5,11 +5,17 @@ layout: manual
 ---
 
 
-**Type:** [`number`](/docs/kcl/types/number) (`double`)
+**Type:** `object`
 
 
 
 
 
+## Properties
+
+| Property | Type | Description | Required |
+|----------|------|-------------|----------|
+| `n` |[`number`](/docs/kcl/types/number)|  | No |
+| `ty` |[`NumericType`](/docs/kcl/types/NumericType)|  | No |
 
 

e2e/playwright/basic-sketch.spec.ts

@@ -85,7 +85,7 @@ async function doBasicSketch(
   await page.mouse.click(startXPx, 500 - PUR * 20)
   if (openPanes.includes('code')) {
     await expect(u.codeLocator)
-      .toHaveText(`@settings(defaultLengthUnit = in)sketch001 = startSketchOn(XZ)profile001 = startProfileAt(${
+      .toHaveText(`@settings(defaultLengthUnit = in)sketch001 = startSketchOn('XZ')profile001 = startProfileAt(${
       commonPoints.startAt
     }, sketch001)
   |> xLine(length = ${commonPoints.num1})
@@ -119,7 +119,10 @@ async function doBasicSketch(
   await page.waitForTimeout(100)
 
   if (openPanes.includes('code')) {
-    expect(await u.getGreatestPixDiff(line1, TEST_COLORS.BLUE)).toBeLessThan(3)
+    await expect(
+      await u.getGreatestPixDiff(line1, TEST_COLORS.BLUE)
+    ).toBeLessThan(3)
+    await expect(await u.getGreatestPixDiff(line1, [0, 0, 255])).toBeLessThan(3)
   }
 
   // hold down shift
@@ -142,7 +145,7 @@ async function doBasicSketch(
   // Open the code pane.
   await u.openKclCodePanel()
   await expect(u.codeLocator)
-    .toHaveText(`@settings(defaultLengthUnit = in)sketch001 = startSketchOn(XZ)profile001 = startProfileAt(${
+    .toHaveText(`@settings(defaultLengthUnit = in)sketch001 = startSketchOn('XZ')profile001 = startProfileAt(${
     commonPoints.startAt
   }, sketch001)
   |> xLine(length = ${commonPoints.num1}, tag = $seg01)

e2e/playwright/boolean.spec.ts

@@ -1,117 +0,0 @@
-import { test, expect } from './zoo-test'
-import fs from 'node:fs/promises'
-import path from 'node:path'
-
-test.describe('Point and click for boolean workflows', () => {
-  // Boolean operations to test
-  const booleanOperations = [
-    {
-      name: 'union',
-      code: 'union([extrude001, extrude006])',
-    },
-    {
-      name: 'subtract',
-      code: 'subtract([extrude001], tools = [extrude006])',
-    },
-    {
-      name: 'intersect',
-      code: 'intersect([extrude001, extrude006])',
-    },
-  ] as const
-  for (let i = 0; i < booleanOperations.length; i++) {
-    const operation = booleanOperations[i]
-    const operationName = operation.name
-    const commandName = `Boolean ${
-      operationName.charAt(0).toUpperCase() + operationName.slice(1)
-    }`
-    test(`Create boolean operation -- ${operationName}`, async ({
-      context,
-      homePage,
-      cmdBar,
-      editor,
-      toolbar,
-      scene,
-      page,
-    }) => {
-      const file = await fs.readFile(
-        path.resolve(
-          __dirname,
-          '../../',
-          './rust/kcl-lib/e2e/executor/inputs/boolean-setup-with'
-        ),
-        'utf-8'
-      )
-      await context.addInitScript((file) => {
-        localStorage.setItem('persistCode', file)
-      }, file)
-      await homePage.goToModelingScene()
-      await scene.waitForExecutionDone()
-
-      await scene.settled(cmdBar)
-
-      // Test coordinates for selection - these might need adjustment based on actual scene layout
-      const cylinderPoint = { x: 592, y: 174 }
-      const secondObjectPoint = { x: 683, y: 273 }
-
-      // Create mouse helpers for selecting objects
-      const [clickFirstObject] = scene.makeMouseHelpers(
-        cylinderPoint.x,
-        cylinderPoint.y,
-        { steps: 10 }
-      )
-      const [clickSecondObject] = scene.makeMouseHelpers(
-        secondObjectPoint.x,
-        secondObjectPoint.y,
-        { steps: 10 }
-      )
-
-      await test.step(`Test ${operationName} operation`, async () => {
-        // Click the boolean operation button in the toolbar
-        await toolbar.selectBoolean(operationName)
-
-        // Verify command bar is showing the right command
-        await expect(cmdBar.page.getByTestId('command-name')).toContainText(
-          commandName
-        )
-
-        // Select first object in the scene, expect there to be a pixel diff from the selection color change
-        await clickFirstObject({ pixelDiff: 50 })
-
-        // For subtract, we need to proceed to the next step before selecting the second object
-        if (operationName !== 'subtract') {
-          // should down shift key to select multiple objects
-          await page.keyboard.down('Shift')
-        }
-
-        // Select second object
-        await clickSecondObject({ pixelDiff: 50 })
-
-        // Confirm the operation in the command bar
-        await cmdBar.progressCmdBar()
-
-        if (operationName === 'union' || operationName === 'intersect') {
-          await cmdBar.expectState({
-            stage: 'review',
-            headerArguments: {
-              Solids: '2 paths',
-            },
-            commandName,
-          })
-        } else if (operationName === 'subtract') {
-          await cmdBar.expectState({
-            stage: 'review',
-            headerArguments: {
-              Tool: '1 path',
-              Target: '1 path',
-            },
-            commandName,
-          })
-        }
-
-        await cmdBar.submit()
-
-        await editor.expectEditor.toContain(operation.code)
-      })
-    })
-  }
-})

e2e/playwright/can-create-sketches-on-all-planes-and-their-back-sides.spec.ts

@@ -46,7 +46,7 @@ test.describe(
         },
       }
 
-      const code = `@settings(defaultLengthUnit = in)sketch001 = startSketchOn(${plane})profile001 = startProfileAt([0.91, -1.22], sketch001)`
+      const code = `@settings(defaultLengthUnit = in)sketch001 = startSketchOn('${plane}')profile001 = startProfileAt([0.91, -1.22], sketch001)`
 
       await u.openDebugPanel()
 

e2e/playwright/code-pane-and-errors.spec.ts

@@ -21,15 +21,14 @@ test.describe('Code pane and errors', { tag: ['@skipWin'] }, () => {
     await page.addInitScript(() => {
       localStorage.setItem(
         'persistCode',
-        `@settings(defaultLengthUnit = in)
-// Extruded Triangle
-sketch001 = startSketchOn(XZ)
-  |> startProfileAt([0, 0], %)
-  |> line(end = [10, 0])
-  |> line(end = [-5, 10])
-  |> line(endAbsolute = [profileStartX(%), profileStartY(%)])
-  |> close()
-extrude001 = extrude(sketch001, length = 5)`
+        `// Extruded Triangle
+  sketch001 = startSketchOn(XZ)
+    |> startProfileAt([0, 0], %)
+    |> line(end = [10, 0])
+    |> line(end = [-5, 10])
+    |> line(endAbsolute = [profileStartX(%), profileStartY(%)])
+    |> close()
+  extrude001 = extrude(sketch001, length = 5)`
       )
     })
 

e2e/playwright/command-bar-tests.spec.ts

@@ -513,8 +513,7 @@ c = 3 + a`
     await homePage.openProject(projectName)
     // TODO: you probably shouldn't need an engine connection to add a parameter,
     // but you do because all modeling commands have that requirement
-    // Don't use scene.settled here
-    await expect(scene.startEditSketchBtn).toBeEnabled({ timeout: 15_000 })
+    await scene.settled(cmdBar)
 
     await test.step(`Create a parameter via command bar`, async () => {
       await cmdBar.cmdBarOpenBtn.click()
@@ -543,12 +542,7 @@ c = 3 + a`
     )
 
     const newValue = `2 * b + a`
-
     await test.step(`Edit the parameter via command bar`, async () => {
-      // TODO: make the command palette command registration more static, and the enabled state more dynamic
-      // so that we can just open the command palette and know all commands will be there.
-      await expect(scene.startEditSketchBtn).toBeEnabled()
-
       await cmdBar.cmdBarOpenBtn.click()
       await cmdBar.chooseCommand('edit parameter')
       await cmdBar.expectState({

e2e/playwright/editor-tests.spec.ts

@@ -34,7 +34,7 @@ test.describe('Editor tests', { tag: ['@skipWin'] }, () => {
 
     await expect(page.locator('.cm-content')).toHaveText(
       `@settings(defaultLengthUnit = in)
-sketch001 = startSketchOn(XY)
+sketch001 = startSketchOn('XY')
   |> startProfileAt([-10, -10], %)
   |> line(end = [20, 0])
   |> line(end = [0, 20])
@@ -49,7 +49,7 @@ sketch001 = startSketchOn(XY)
 
     await expect(page.locator('.cm-content')).toHaveText(
       `@settings(defaultLengthUnit = in)
-sketch001 = startSketchOn(XY)
+sketch001 = startSketchOn('XY')
   |> startProfileAt([-10, -10], %)
   |> line(end = [20, 0])
   |> line(end = [0, 20])
@@ -184,7 +184,7 @@ sketch001 = startSketchOn(XY)
 
     await expect(page.locator('.cm-content')).toHaveText(
       `@settings(defaultLengthUnit = in)
-sketch001 = startSketchOn(XY)
+sketch001 = startSketchOn('XY')
   |> startProfileAt([-10, -10], %)
   |> line(end = [20, 0])
   |> line(end = [0, 20])
@@ -235,7 +235,7 @@ sketch001 = startSketchOn(XY)
 
     await expect(page.locator('.cm-content')).toHaveText(
       `@settings(defaultLengthUnit = in)
-sketch_001 = startSketchOn(XY)
+sketch_001 = startSketchOn('XY')
   |> startProfileAt([-10, -10], %)
   |> line(end = [20, 0])
   |> line(end = [0, 20])
@@ -479,7 +479,6 @@ sketch_001 = startSketchOn(XY)
   test('if you write kcl with lint errors you get lints', async ({
     page,
     homePage,
-    scene,
   }) => {
     const u = await getUtils(page)
     await page.setBodyDimensions({ width: 1000, height: 500 })
@@ -499,7 +498,10 @@ sketch_001 = startSketchOn(XY)
     await page.keyboard.press('ArrowLeft')
     await page.keyboard.press('ArrowRight')
 
-    await scene.waitForExecutionDone()
+    // FIXME: lsp errors do not propagate to the frontend until engine is connected and code is executed
+    // This timeout is to wait for engine connection. LSP and code execution errors should be handled differently
+    // LSP can emit errors as fast as it waits and show them in the editor
+    await page.waitForTimeout(10000)
 
     // error in guter
     await expect(page.locator('.cm-lint-marker-info').first()).toBeVisible()
@@ -823,7 +825,7 @@ sketch_001 = startSketchOn(XY)
 
       await expect(page.locator('.cm-content')).toHaveText(
         `@settings(defaultLengthUnit = in)
-sketch001 = startSketchOn(XZ)
+sketch001 = startSketchOn('XZ')
         |> startProfileAt([3.14, 12], %)
         |> xLine(%, length = 5) // lin`.replaceAll('\n', '')
       )
@@ -898,7 +900,7 @@ sketch001 = startSketchOn(XZ)
 
       await expect(page.locator('.cm-content')).toHaveText(
         `@settings(defaultLengthUnit = in)
-sketch001 = startSketchOn(XZ)
+sketch001 = startSketchOn('XZ')
         |> startProfileAt([3.14, 12], %)
         |> xLine(%, length = 5) // lin`.replaceAll('\n', '')
       )
@@ -1216,55 +1218,4 @@ sketch001 = startSketchOn(XZ)
       })
     }
   )
-
-  test('Rectangle tool panning with middle click', async ({
-    page,
-    homePage,
-    toolbar,
-    scene,
-    cmdBar,
-    editor,
-  }) => {
-    await page.setBodyDimensions({ width: 1200, height: 900 })
-    await homePage.goToModelingScene()
-
-    // wait until scene is ready to be interacted with
-    await scene.connectionEstablished()
-    await scene.settled(cmdBar)
-
-    await page.getByRole('button', { name: 'Start Sketch' }).click()
-
-    // select an axis plane
-    await page.mouse.click(700, 200)
-
-    // Needed as we don't yet have a way to get a signal from the engine that the camera has animated to the sketch plane
-    await page.waitForTimeout(1000)
-
-    const middleMousePan = async (
-      startX: number,
-      startY: number,
-      endX: number,
-      endY: number
-    ) => {
-      const initialCode = await editor.getCurrentCode()
-
-      await page.mouse.click(startX, startY, { button: 'middle' })
-      await page.mouse.move(endX, endY, {
-        steps: 10,
-      })
-
-      // We expect the code to be the same, middle mouse click should not modify the code, only do panning
-      await editor.expectEditor.toBe(initialCode)
-    }
-
-    await test.step(`Verify corner rectangle panning`, async () => {
-      await page.getByTestId('corner-rectangle').click()
-      await middleMousePan(800, 500, 900, 600)
-    })
-
-    await test.step(`Verify center rectangle panning`, async () => {
-      await toolbar.selectCenterRectangle()
-      await middleMousePan(800, 200, 900, 300)
-    })
-  })
 })

e2e/playwright/file-tree.spec.ts

@@ -6,7 +6,6 @@ import {
   executorInputPath,
   getUtils,
   orRunWhenFullSuiteEnabled,
-  runningOnWindows,
 } from './test-utils'
 import { join } from 'path'
 import { FILE_EXT } from 'lib/constants'
@@ -16,9 +15,6 @@ test.describe('integrations tests', () => {
     'Creating a new file or switching file while in sketchMode should exit sketchMode',
     { tag: '@electron' },
     async ({ page, context, homePage, scene, editor, toolbar, cmdBar }) => {
-      if (runningOnWindows()) {
-        test.fixme(orRunWhenFullSuiteEnabled())
-      }
       await context.folderSetupFn(async (dir) => {
         const bracketDir = join(dir, 'test-sample')
         await fsp.mkdir(bracketDir, { recursive: true })

e2e/playwright/fixtures/editorFixture.ts

@@ -81,13 +81,6 @@ export class EditorFixture {
   expectEditor = {
     toContain: this._expectEditorToContain(),
     not: { toContain: this._expectEditorToContain(true) },
-    toBe: async (code: string) => {
-      const currentCode = await this.getCurrentCode()
-      return expect(currentCode).toBe(code)
-    },
-  }
-  getCurrentCode = async () => {
-    return await this.codeContent.innerText()
   }
   snapshot = async (options?: { timeout?: number; name?: string }) => {
     const wasPaneOpen = await this.checkIfPaneIsOpen()

e2e/playwright/fixtures/fixtureSetup.ts

@@ -124,7 +124,6 @@ export class ElectronZoo {
 
     // We need to expose this in order for some tests that require folder
     // creation and some code below.
-    // eslint-disable-next-line @typescript-eslint/no-this-alias
     const that = this
 
     const options = {

e2e/playwright/fixtures/toolbarFixture.ts

@@ -181,14 +181,6 @@ export class ToolbarFixture {
     ).toBeVisible()
     await this.page.getByTestId('dropdown-center-rectangle').click()
   }
-  selectBoolean = async (operation: 'union' | 'subtract' | 'intersect') => {
-    await this.page
-      .getByRole('button', { name: 'caret down Union: open menu' })
-      .click()
-    const operationTestId = `dropdown-boolean-${operation}`
-    await expect(this.page.getByTestId(operationTestId)).toBeVisible()
-    await this.page.getByTestId(operationTestId).click()
-  }
 
   selectCircleThreePoint = async () => {
     await this.page

e2e/playwright/lib/console-error-whitelist.ts

@@ -257,29 +257,6 @@ export const isErrorWhitelisted = (exception: Error) => {
       project: 'Google Chrome',
       foundInSpec: 'e2e/playwright/testing-settings.spec.ts',
     },
-    // TODO: fix this error in the code
-    {
-      name: 'ReferenceError',
-      message: '_testUtils is not defined',
-      stack: '',
-      project: 'Google Chrome',
-      foundInSpec: 'e2e/playwright/snapshot-tests.spec.ts',
-    },
-    {
-      name: 'TypeError',
-      message: 'Failed to fetch',
-      stack: '',
-      project: 'Google Chrome',
-      foundInSpec: 'e2e/playwright/snapshot-tests.spec.ts',
-    },
-    {
-      name: 'Error',
-      message: 'The "path" argument must be of type string. Received undefined',
-      stack:
-        'Error: The "path" argument must be of type string. Received undefined',
-      project: 'Google Chrome',
-      foundInSpec: '', // many tests are impacted by this error
-    },
   ]
 
   const cleanString = (str: string) => str.replace(/[`"]/g, '')

e2e/playwright/named-views.spec.ts

@@ -1,292 +0,0 @@
-import { test, expect } from './zoo-test'
-import { PROJECT_SETTINGS_FILE_NAME } from 'lib/constants'
-import * as fsp from 'fs/promises'
-import { join } from 'path'
-import {
-  createProject,
-  tomlToPerProjectSettings,
-  perProjectsettingsToToml,
-} from './test-utils'
-import { NamedView } from '@rust/kcl-lib/bindings/NamedView'
-
-// Helper function to determine if the file path on disk exists
-// Specifically this is used to check if project.toml exists on disk
-const fileExists = async (path: string) => {
-  return !!(await fsp
-    .stat(path)
-    .then((_) => true)
-    .catch((_) => false))
-}
-
-// Here are a few uuids.
-// When created named views rust will auto generate uuids and they will
-// never match the snapshots. Overwrite them in memory to these
-// values to have them match the snapshots.
-const uuid1: string = '0656fb1a-9640-473e-b334-591dc70c0138'
-const uuid2: string = 'c810cf04-c6cc-4a4a-8b11-17bf445dcab7'
-const uuid3: string = 'cfecbfee-48a6-4561-b96d-ffbe5678bb7d'
-
-// Look up the named view by name and then rewrite it with the same uuid each time
-const nameToUuid: Map<string, string> = new Map()
-nameToUuid.set('uuid1', uuid1)
-nameToUuid.set('uuid2', uuid2)
-nameToUuid.set('uuid3', uuid3)
-
-/**
- * Given the project.toml string, overwrite the named views to be the constant uuid
- * values to match the snapshots. The uuids are randomly generated
- */
-function tomlStringOverWriteNamedViewUuids(toml: string): string {
-  const settings = tomlToPerProjectSettings(toml)
-  const namedViews = settings.settings?.app?.named_views
-  if (namedViews) {
-    const entries = Object.entries(namedViews)
-    const remappedNamedViews: { [key: string]: NamedView } = {}
-    entries.forEach(([_, value]) => {
-      if (value) {
-        // {name:'uuid1'} -> uuid1 lookup
-        const staticUuid = nameToUuid.get(value.name)
-        if (staticUuid) {
-          remappedNamedViews[staticUuid] = value
-        }
-      }
-    })
-    if (settings && settings.settings && settings.settings.app) {
-      settings.settings.app.named_views = remappedNamedViews
-    }
-  }
-  return perProjectsettingsToToml(settings)
-}
-
-test.describe('Named view tests', () => {
-  test('Verify project.toml is not created', async ({ page }, testInfo) => {
-    // Create project and load it
-    const projectName = 'named-views'
-    await createProject({ name: projectName, page })
-
-    // Generate file paths for project.toml
-    const projectDirName = testInfo.outputPath('electron-test-projects-dir')
-    const tempProjectSettingsFilePath = join(
-      projectDirName,
-      projectName,
-      PROJECT_SETTINGS_FILE_NAME
-    )
-
-    // project.toml should not exist on initial project creation
-    let exists = await fileExists(tempProjectSettingsFilePath)
-    expect(exists).toBe(false)
-  })
-  test('Verify named view gets created', async ({
-    cmdBar,
-    scene,
-    page,
-  }, testInfo) => {
-    const projectName = 'named-views'
-    const myNamedView = 'uuid1'
-
-    // Create and load project
-    await createProject({ name: projectName, page })
-    await scene.waitForExecutionDone()
-
-    // Create named view
-    const projectDirName = testInfo.outputPath('electron-test-projects-dir')
-    await cmdBar.openCmdBar()
-    await cmdBar.chooseCommand('create named view')
-    await cmdBar.argumentInput.fill(myNamedView)
-    await cmdBar.progressCmdBar(false)
-
-    // Generate paths for the project.toml
-    const tempProjectSettingsFilePath = join(
-      projectDirName,
-      projectName,
-      PROJECT_SETTINGS_FILE_NAME
-    )
-
-    // Expect project.toml to be generated on disk since a named view was created
-    await expect(async () => {
-      let exists = await fileExists(tempProjectSettingsFilePath)
-      expect(exists).toBe(true)
-    }).toPass()
-
-    // Read project.toml into memory
-    let tomlString = await fsp.readFile(tempProjectSettingsFilePath, 'utf-8')
-    // Rewrite the uuids in the named views to match snapshot otherwise they will be randomly generated from rust and break
-    tomlString = tomlStringOverWriteNamedViewUuids(tomlString)
-
-    // Write the entire tomlString to a snapshot.
-    // There are many key/value pairs to check this is a safer match.
-    expect(tomlString).toMatchSnapshot('verify-named-view-gets-created')
-  })
-  test('Verify named view gets deleted', async ({
-    cmdBar,
-    scene,
-    page,
-  }, testInfo) => {
-    const projectName = 'named-views'
-    const myNamedView1 = 'uuid1'
-    const myNamedView2 = 'uuid2'
-
-    // Create project and go into the project
-    await createProject({ name: projectName, page })
-    await scene.waitForExecutionDone()
-
-    // Create a new named view
-    await cmdBar.openCmdBar()
-    await cmdBar.chooseCommand('create named view')
-    await cmdBar.argumentInput.fill(myNamedView1)
-    await cmdBar.progressCmdBar(false)
-
-    // Generate file paths for project.toml
-    const projectDirName = testInfo.outputPath('electron-test-projects-dir')
-    const tempProjectSettingsFilePath = join(
-      projectDirName,
-      projectName,
-      PROJECT_SETTINGS_FILE_NAME
-    )
-
-    // Except the project.toml to be written to disk since a named view was created
-    await expect(async () => {
-      let exists = await fileExists(tempProjectSettingsFilePath)
-      expect(exists).toBe(true)
-    }).toPass()
-
-    // Read project.toml into memory
-    let tomlString = await fsp.readFile(tempProjectSettingsFilePath, 'utf-8')
-    // Rewrite the uuids in the named views to match snapshot otherwise they will be randomly generated from rust and break
-    tomlString = tomlStringOverWriteNamedViewUuids(tomlString)
-
-    // Write the entire tomlString to a snapshot.
-    // There are many key/value pairs to check this is a safer match.
-    expect(tomlString).toMatchSnapshot('verify-named-view-gets-created')
-
-    // Delete a named view
-    await cmdBar.openCmdBar()
-    await cmdBar.chooseCommand('delete named view')
-    cmdBar.selectOption({ name: myNamedView2 })
-    await cmdBar.progressCmdBar(false)
-
-    // Read project.toml into memory again since we deleted a named view
-    tomlString = await fsp.readFile(tempProjectSettingsFilePath, 'utf-8')
-    // Rewrite the uuids in the named views to match snapshot otherwise they will be randomly generated from rust and break
-    tomlString = tomlStringOverWriteNamedViewUuids(tomlString)
-
-    // // Write the entire tomlString to a snapshot.
-    // // There are many key/value pairs to check this is a safer match.
-    expect(tomlString).toMatchSnapshot('verify-named-view-gets-deleted')
-  })
-  test('Verify named view gets loaded', async ({
-    cmdBar,
-    scene,
-    page,
-  }, testInfo) => {
-    const projectName = 'named-views'
-    const myNamedView = 'uuid1'
-
-    // Create project and go into the project
-    await createProject({ name: projectName, page })
-    await scene.waitForExecutionDone()
-
-    // Create a new named view
-    await cmdBar.openCmdBar()
-    await cmdBar.chooseCommand('create named view')
-    await cmdBar.argumentInput.fill(myNamedView)
-    await cmdBar.progressCmdBar(false)
-
-    // Generate file paths for project.toml
-    const projectDirName = testInfo.outputPath('electron-test-projects-dir')
-    const tempProjectSettingsFilePath = join(
-      projectDirName,
-      projectName,
-      PROJECT_SETTINGS_FILE_NAME
-    )
-
-    // Except the project.toml to be written to disk since a named view was created
-    await expect(async () => {
-      let exists = await fileExists(tempProjectSettingsFilePath)
-      expect(exists).toBe(true)
-    }).toPass()
-
-    // Read project.toml into memory
-    let tomlString = await fsp.readFile(tempProjectSettingsFilePath, 'utf-8')
-    // Rewrite the uuids in the named views to match snapshot otherwise they will be randomly generated from rust and break
-    tomlString = tomlStringOverWriteNamedViewUuids(tomlString)
-
-    // Write the entire tomlString to a snapshot.
-    // There are many key/value pairs to check this is a safer match.
-    expect(tomlString).toMatchSnapshot('verify-named-view-gets-created')
-
-    // Create a load a named view
-    await cmdBar.openCmdBar()
-    await cmdBar.chooseCommand('load named view')
-    await cmdBar.argumentInput.fill(myNamedView)
-    await cmdBar.progressCmdBar(false)
-
-    // Check the toast appeared
-    await expect(
-      page.getByText(`Named view ${myNamedView} loaded.`)
-    ).toBeVisible()
-  })
-  test('Verify two named views get created', async ({
-    cmdBar,
-    scene,
-    page,
-  }, testInfo) => {
-    const projectName = 'named-views'
-    const myNamedView1 = 'uuid1'
-    const myNamedView2 = 'uuid2'
-
-    // Create and load project
-    await createProject({ name: projectName, page })
-    await scene.waitForExecutionDone()
-
-    // Create named view
-    const projectDirName = testInfo.outputPath('electron-test-projects-dir')
-    await cmdBar.openCmdBar()
-    await cmdBar.chooseCommand('create named view')
-    await cmdBar.argumentInput.fill(myNamedView1)
-    await cmdBar.progressCmdBar(false)
-
-    await page.waitForTimeout(1000)
-
-    const orbitMouseStart = { x: 800, y: 130 }
-    const orbitMouseEnd = { x: 0, y: 130 }
-    await page.mouse.move(orbitMouseStart.x, orbitMouseStart.y)
-    await page.mouse.down({ button: 'middle' })
-    await page.mouse.move(orbitMouseEnd.x, orbitMouseEnd.y, {
-      steps: 3,
-    })
-    await page.mouse.up({ button: 'middle' })
-
-    await page.waitForTimeout(1000)
-
-    await cmdBar.openCmdBar()
-    await cmdBar.chooseCommand('create named view')
-    await cmdBar.argumentInput.fill(myNamedView2)
-    await cmdBar.progressCmdBar(false)
-
-    // Wait a moment for the project.toml to get written to disk with the new view point
-    await page.waitForTimeout(1000)
-
-    // Generate paths for the project.toml
-    const tempProjectSettingsFilePath = join(
-      projectDirName,
-      projectName,
-      PROJECT_SETTINGS_FILE_NAME
-    )
-
-    // Expect project.toml to be generated on disk since a named view was created
-    await expect(async () => {
-      let exists = await fileExists(tempProjectSettingsFilePath)
-      expect(exists).toBe(true)
-    }).toPass()
-
-    // Read project.toml into memory
-    let tomlString = await fsp.readFile(tempProjectSettingsFilePath, 'utf-8')
-    // Rewrite the uuids in the named views to match snapshot otherwise they will be randomly generated from rust and break
-    tomlString = tomlStringOverWriteNamedViewUuids(tomlString)
-
-    // Write the entire tomlString to a snapshot.
-    // There are many key/value pairs to check this is a safer match.
-    expect(tomlString).toMatchSnapshot('verify-two-named-view-gets-created')
-  })
-})

e2e/playwright/named-views.spec.ts-snapshots/verify-named-view-gets-created-chromium-linux

@@ -1,16 +0,0 @@
-[settings]
-modeling = { }
-text_editor = { }
-command_bar = { }
-
-[settings.app.named_views.0656fb1a-9640-473e-b334-591dc70c0138]
-name = "uuid1"
-eye_offset = 1_378.0059
-fov_y = 45
-is_ortho = false
-ortho_scale_enabled = true
-ortho_scale_factor = 1.6
-pivot_position = [ 0, 0, 0 ]
-pivot_rotation = [ 0.5380994, 0.0, 0.0, 0.8428814 ]
-world_coord_system = "right_handed_up_z"
-version = 1

e2e/playwright/named-views.spec.ts-snapshots/verify-named-view-gets-deleted-chromium-linux

@@ -1,16 +0,0 @@
-[settings]
-modeling = { }
-text_editor = { }
-command_bar = { }
-
-[settings.app.named_views.0656fb1a-9640-473e-b334-591dc70c0138]
-name = "uuid1"
-eye_offset = 1_378.0059
-fov_y = 45
-is_ortho = false
-ortho_scale_enabled = true
-ortho_scale_factor = 1.6
-pivot_position = [ 0, 0, 0 ]
-pivot_rotation = [ 0.5380994, 0.0, 0.0, 0.8428814 ]
-world_coord_system = "right_handed_up_z"
-version = 1

e2e/playwright/named-views.spec.ts-snapshots/verify-two-named-view-gets-created-chromium-linux

@@ -1,28 +0,0 @@
-[settings]
-modeling = { }
-text_editor = { }
-command_bar = { }
-
-[settings.app.named_views.0656fb1a-9640-473e-b334-591dc70c0138]
-name = "uuid1"
-eye_offset = 1_378.0059
-fov_y = 45
-is_ortho = false
-ortho_scale_enabled = true
-ortho_scale_factor = 1.6
-pivot_position = [ 0, 0, 0 ]
-pivot_rotation = [ 0.5380994, 0.0, 0.0, 0.8428814 ]
-world_coord_system = "right_handed_up_z"
-version = 1
-
-[settings.app.named_views.c810cf04-c6cc-4a4a-8b11-17bf445dcab7]
-name = "uuid2"
-eye_offset = 1_378.0059
-fov_y = 45
-is_ortho = false
-ortho_scale_enabled = true
-ortho_scale_factor = 1.6
-pivot_position = [ 1_826.5239, 0.0, 0.0 ]
-pivot_rotation = [ 0.5380994, 0.0, 0.0, 0.8428814 ]
-world_coord_system = "right_handed_up_z"
-version = 1

e2e/playwright/native-file-menu.spec.ts

@@ -1,312 +0,0 @@
-import { test, expect } from './zoo-test'
-
-/**
- * Not all menu actions are tested. Some are default electron menu actions.
- * Test file menu actions that trigger something in the frontend
- */
-test.describe('Native file menu', { tag: ['@electron'] }, () => {
-  test.describe('Home page', () => {
-    test.describe('File role', () => {
-      test('File.Create project', async ({ tronApp, cmdBar, page }) => {
-        if (!tronApp) fail()
-        // Run electron snippet to find the Menu!
-        await tronApp.electron.evaluate(async ({ app }) => {
-          if (!app || !app.applicationMenu) fail()
-          const newProject =
-            app.applicationMenu.getMenuItemById('File.New project')
-          if (!newProject) fail()
-          newProject.click()
-        })
-        // Check that the command bar is opened
-        await expect(cmdBar.cmdBarElement).toBeVisible()
-        // Check the placeholder project name exists
-        const actualArgument = await cmdBar.cmdBarElement
-          .getByTestId('cmd-bar-arg-value')
-          .inputValue()
-        const expectedArgument = 'project-$nnn'
-        expect(actualArgument).toBe(expectedArgument)
-      })
-      test('File.Open project', async ({ tronApp, cmdBar, page }) => {
-        if (!tronApp) fail()
-        // Run electron snippet to find the Menu!
-        await tronApp.electron.evaluate(async ({ app }) => {
-          if (!app || !app.applicationMenu) fail()
-          const openProject =
-            app.applicationMenu.getMenuItemById('File.Open project')
-          if (!openProject) fail()
-          openProject.click()
-        })
-        // Check that the command bar is opened
-        await expect(cmdBar.cmdBarElement).toBeVisible()
-        // Check the placeholder project name exists
-        const actual = await cmdBar.cmdBarElement
-          .getByTestId('command-name')
-          .textContent()
-        const expected = 'Open project'
-        expect(actual).toBe(expected)
-      })
-      test('File.Preferences.User settings', async ({
-        tronApp,
-        cmdBar,
-        page,
-      }) => {
-        if (!tronApp) fail()
-        // Run electron snippet to find the Menu!
-        await tronApp.electron.evaluate(async ({ app }) => {
-          if (!app || !app.applicationMenu) fail()
-          const userSettings = app.applicationMenu.getMenuItemById(
-            'File.Preferences.User settings'
-          )
-          if (!userSettings) fail()
-          userSettings.click()
-        })
-        const settings = page.getByTestId('settings-dialog-panel')
-        await expect(settings).toBeVisible()
-        // You are viewing the user tab
-        const actualText = settings.getByText(
-          'The overall appearance of the app'
-        )
-        await expect(actualText).toBeVisible()
-      })
-      test('File.Preferences.Keybindings', async ({
-        tronApp,
-        cmdBar,
-        page,
-      }) => {
-        if (!tronApp) fail()
-        // Run electron snippet to find the Menu!
-        await tronApp.electron.evaluate(async ({ app }) => {
-          if (!app || !app.applicationMenu) fail()
-          const keybindings = app.applicationMenu.getMenuItemById(
-            'File.Preferences.Keybindings'
-          )
-          if (!keybindings) fail()
-          keybindings.click()
-        })
-        const settings = page.getByTestId('settings-dialog-panel')
-        await expect(settings).toBeVisible()
-        // You are viewing the keybindings tab
-        const enterSketchMode = settings.locator('#enter-sketch-mode')
-        await expect(enterSketchMode).toBeVisible()
-      })
-      test('File.Preferences.User default units', async ({
-        tronApp,
-        cmdBar,
-        page,
-      }) => {
-        if (!tronApp) fail()
-        // Run electron snippet to find the Menu!
-        await tronApp.electron.evaluate(async ({ app }) => {
-          if (!app || !app.applicationMenu) fail()
-          const menu = app.applicationMenu.getMenuItemById(
-            'File.Preferences.User default units'
-          )
-          if (!menu) fail()
-          menu.click()
-        })
-        const settings = page.getByTestId('settings-dialog-panel')
-        await expect(settings).toBeVisible()
-        const defaultUnit = settings.locator('#defaultUnit')
-        await expect(defaultUnit).toBeVisible()
-      })
-      test('File.Preferences.Theme', async ({ tronApp, cmdBar, page }) => {
-        if (!tronApp) fail()
-        // Run electron snippet to find the Menu!
-        await tronApp.electron.evaluate(async ({ app }) => {
-          if (!app || !app.applicationMenu) fail()
-          const menu = app.applicationMenu.getMenuItemById(
-            'File.Preferences.Theme'
-          )
-          if (!menu) fail()
-          menu.click()
-        })
-        // Check that the command bar is opened
-        await expect(cmdBar.cmdBarElement).toBeVisible()
-        // Check the placeholder project name exists
-        const actual = await cmdBar.cmdBarElement
-          .getByTestId('command-name')
-          .textContent()
-        const expected = 'Settings · app · theme'
-        expect(actual).toBe(expected)
-      })
-      test('File.Preferences.Theme color', async ({
-        tronApp,
-        cmdBar,
-        page,
-      }) => {
-        if (!tronApp) fail()
-        // Run electron snippet to find the Menu!
-        await tronApp.electron.evaluate(async ({ app }) => {
-          if (!app || !app.applicationMenu) fail()
-          const menu = app.applicationMenu.getMenuItemById(
-            'File.Preferences.Theme color'
-          )
-          if (!menu) fail()
-          menu.click()
-        })
-        const settings = page.getByTestId('settings-dialog-panel')
-        await expect(settings).toBeVisible()
-        const defaultUnit = settings.locator('#themeColor')
-        await expect(defaultUnit).toBeVisible()
-      })
-      test('File.Preferences.Sign out', async ({ tronApp, cmdBar, page }) => {
-        if (!tronApp) fail()
-        // Run electron snippet to find the Menu!
-        await tronApp.electron.evaluate(async ({ app }) => {
-          if (!app || !app.applicationMenu) fail()
-          const menu = app.applicationMenu.getMenuItemById('File.Sign out')
-          if (!menu) fail()
-          // FIXME: Add back when you can actually sign out
-          // menu.click()
-        })
-        // FIXME: When signing out during E2E the page is not bound correctly.
-        // It cannot find the button
-        // const signIn = page.getByTestId('sign-in-button')
-        // await expect(signIn).toBeVisible()
-      })
-    })
-
-    test.describe('Edit role', () => {
-      test('Edit.Rename project', async ({ tronApp, cmdBar, page }) => {
-        if (!tronApp) fail()
-        // Run electron snippet to find the Menu!
-        await tronApp.electron.evaluate(async ({ app }) => {
-          if (!app || !app.applicationMenu) fail()
-          const menu = app.applicationMenu.getMenuItemById(
-            'Edit.Rename project'
-          )
-          if (!menu) fail()
-          menu.click()
-        })
-        // Check the placeholder project name exists
-        const actual = await cmdBar.cmdBarElement
-          .getByTestId('command-name')
-          .textContent()
-        const expected = 'Rename project'
-        expect(actual).toBe(expected)
-      })
-      test('Edit.Delete project', async ({ tronApp, cmdBar, page }) => {
-        if (!tronApp) fail()
-        // Run electron snippet to find the Menu!
-        await tronApp.electron.evaluate(async ({ app }) => {
-          if (!app || !app.applicationMenu) fail()
-          const menu = app.applicationMenu.getMenuItemById(
-            'Edit.Delete project'
-          )
-          if (!menu) fail()
-          menu.click()
-        })
-        // Check the placeholder project name exists
-        const actual = await cmdBar.cmdBarElement
-          .getByTestId('command-name')
-          .textContent()
-        const expected = 'Delete project'
-        expect(actual).toBe(expected)
-      })
-      test('Edit.Change project directory', async ({
-        tronApp,
-        cmdBar,
-        page,
-      }) => {
-        if (!tronApp) fail()
-        // Run electron snippet to find the Menu!
-        await tronApp.electron.evaluate(async ({ app }) => {
-          if (!app || !app.applicationMenu) fail()
-          const menu = app.applicationMenu.getMenuItemById(
-            'Edit.Change project directory'
-          )
-          if (!menu) fail()
-          menu.click()
-        })
-        const settings = page.getByTestId('settings-dialog-panel')
-        await expect(settings).toBeVisible()
-        const projectDirectory = settings.locator('#projectDirectory')
-        await expect(projectDirectory).toBeVisible()
-      })
-    })
-    test.describe('View role', () => {
-      test('View.Command Palette...', async ({ tronApp, cmdBar, page }) => {
-        if (!tronApp) fail()
-        // Run electron snippet to find the Menu!
-        await tronApp.electron.evaluate(async ({ app }) => {
-          if (!app || !app.applicationMenu) fail()
-          const menu = app.applicationMenu.getMenuItemById(
-            'View.Command Palette...'
-          )
-          if (!menu) fail()
-          menu.click()
-        })
-        // Check the placeholder project name exists
-        const actual = cmdBar.cmdBarElement.getByTestId('cmd-bar-search')
-        await expect(actual).toBeVisible()
-      })
-    })
-    test.describe('Help role', () => {
-      test('Help.Show all commands', async ({ tronApp, cmdBar, page }) => {
-        if (!tronApp) fail()
-        // Run electron snippet to find the Menu!
-        await tronApp.electron.evaluate(async ({ app }) => {
-          if (!app || !app.applicationMenu) fail()
-          const menu = app.applicationMenu.getMenuItemById(
-            'Help.Show all commands'
-          )
-          if (!menu) fail()
-          menu.click()
-        })
-        // Check the placeholder project name exists
-        const actual = cmdBar.cmdBarElement.getByTestId('cmd-bar-search')
-        await expect(actual).toBeVisible()
-      })
-      test('Help.KCL code samples', async ({ tronApp, cmdBar, page }) => {
-        if (!tronApp) fail()
-        // Run electron snippet to find the Menu!
-        await tronApp.electron.evaluate(async ({ app }) => {
-          if (!app || !app.applicationMenu) fail()
-          const menu = app.applicationMenu.getMenuItemById(
-            'Help.KCL code samples'
-          )
-          if (!menu) fail()
-        })
-      })
-      test('Help.Refresh and report a bug', async ({
-        tronApp,
-        cmdBar,
-        page,
-      }) => {
-        if (!tronApp) fail()
-        // Run electron snippet to find the Menu!
-        await tronApp.electron.evaluate(async ({ app }) => {
-          if (!app || !app.applicationMenu) fail()
-          const menu = app.applicationMenu.getMenuItemById(
-            'Help.Refresh and report a bug'
-          )
-          if (!menu) fail()
-          menu.click()
-        })
-        // Core dump and refresh magic number timeout
-        await page.waitForTimeout(7000)
-        const actual = page.getByText(
-          'No Projects found, ready to make your first one?'
-        )
-        await expect(actual).toBeVisible()
-      })
-      test('Help.Reset onboarding', async ({ tronApp, cmdBar, page }) => {
-        if (!tronApp) fail()
-        // Run electron snippet to find the Menu!
-        await tronApp.electron.evaluate(async ({ app }) => {
-          if (!app || !app.applicationMenu) fail()
-          const menu = app.applicationMenu.getMenuItemById(
-            'Help.Reset onboarding'
-          )
-          if (!menu) fail()
-          menu.click()
-        })
-
-        const actual = page.getByText(
-          `This is a hardware design tool that lets you edit visually, with code, or both. It's powered by the KittyCAD Design API, the first API created for anyone to build hardware design tools.`
-        )
-        await expect(actual).toBeVisible()
-      })
-    })
-  })
-})

e2e/playwright/onboarding-tests.spec.ts

@@ -230,9 +230,9 @@ test.describe('Onboarding tests', () => {
 
     // Override beforeEach test setup
     await context.addInitScript(
-      async ({ settingsKey, settings, code }) => {
+      async ({ settingsKey, settings }) => {
         // Give some initial code, so we can test that it's cleared
-        localStorage.setItem('persistCode', code)
+        localStorage.setItem('persistCode', originalCode)
         localStorage.setItem(settingsKey, settings)
       },
       {
@@ -240,7 +240,6 @@ test.describe('Onboarding tests', () => {
         settings: settingsToToml({
           settings: TEST_SETTINGS_ONBOARDING_EXPORT,
         }),
-        code: originalCode,
       }
     )
 

e2e/playwright/point-click.spec.ts

@@ -1073,7 +1073,7 @@ openSketch = startSketchOn(XY)
     })
   })
 
-  test('Helix point-and-click on default axis', async ({
+  test('Helix point-and-click', async ({
     context,
     page,
     homePage,
@@ -1084,25 +1084,29 @@ openSketch = startSketchOn(XY)
   }) => {
     // One dumb hardcoded screen pixel value
     const testPoint = { x: 620, y: 257 }
-    const expectedOutput = `helix001 = helix(  axis = 'X',  radius = 5,  length = 5,  revolutions = 1,  angleStart = 360,  ccw = false,)`
-    const expectedLine = `axis='X',`
+    const expectedOutput = `helix001 = helix(  revolutions = 1,  angleStart = 360,  counterClockWise = false,  radius = 5,  axis = 'X',  length = 5,)`
+    const expectedLine = `revolutions=1,`
 
     await homePage.goToModelingScene()
 
+    // await test.step(`Look for the red of the default plane`, async () => {
+    //   await scene.expectPixelColor([96, 52, 52], testPoint, 15)
+    // })
     await test.step(`Go through the command bar flow`, async () => {
       await toolbar.helixButton.click()
       await cmdBar.expectState({
         stage: 'arguments',
-        currentArgKey: 'mode',
-        currentArgValue: '',
+        currentArgKey: 'revolutions',
+        currentArgValue: '1',
         headerArguments: {
-          Mode: '',
           AngleStart: '',
-          Revolutions: '',
+          Axis: '',
+          CounterClockWise: '',
+          Length: '',
           Radius: '',
-          CounterClockWise: '',
+          Revolutions: '',
         },
-        highlightedHeaderArg: 'mode',
+        highlightedHeaderArg: 'revolutions',
         commandName: 'Helix',
       })
       await cmdBar.progressCmdBar()
@@ -1111,19 +1115,6 @@ openSketch = startSketchOn(XY)
       await cmdBar.progressCmdBar()
       await cmdBar.progressCmdBar()
       await cmdBar.progressCmdBar()
-      await cmdBar.expectState({
-        stage: 'review',
-        headerArguments: {
-          Mode: 'Axis',
-          Axis: 'X',
-          AngleStart: '360',
-          Revolutions: '1',
-          Length: '5',
-          Radius: '5',
-          CounterClockWise: '',
-        },
-        commandName: 'Helix',
-      })
       await cmdBar.progressCmdBar()
     })
 
@@ -1147,31 +1138,30 @@ openSketch = startSketchOn(XY)
       await cmdBar.expectState({
         commandName: 'Helix',
         stage: 'arguments',
-        currentArgKey: 'CounterClockWise',
-        currentArgValue: '',
+        currentArgKey: 'length',
+        currentArgValue: initialInput,
         headerArguments: {
-          Axis: 'X',
           AngleStart: '360',
-          Revolutions: '1',
-          Radius: '5',
-          Length: initialInput,
+          Axis: 'X',
           CounterClockWise: '',
+          Length: initialInput,
+          Radius: '5',
+          Revolutions: '1',
         },
-        highlightedHeaderArg: 'CounterClockWise',
+        highlightedHeaderArg: 'length',
       })
-      await page.keyboard.press('Shift+Backspace')
       await expect(cmdBar.currentArgumentInput).toBeVisible()
       await cmdBar.currentArgumentInput.locator('.cm-content').fill(newInput)
       await cmdBar.progressCmdBar()
       await cmdBar.expectState({
         stage: 'review',
         headerArguments: {
-          Axis: 'X',
           AngleStart: '360',
-          Revolutions: '1',
-          Radius: '5',
-          Length: newInput,
+          Axis: 'X',
           CounterClockWise: '',
+          Length: newInput,
+          Radius: '5',
+          Revolutions: '1',
         },
         commandName: 'Helix',
       })
@@ -1191,295 +1181,6 @@ openSketch = startSketchOn(XY)
     })
   })
 
-  const helixCases = [
-    {
-      selectionType: 'segment',
-      testPoint: { x: 513, y: 221 },
-      expectedOutput: `helix001 = helix(  axis = seg01,  radius = 1,  revolutions = 20,  angleStart = 0,  ccw = false,)`,
-      expectedEditedOutput: `helix001 = helix(  axis = seg01,  radius = 5,  revolutions = 20,  angleStart = 0,  ccw = false,)`,
-    },
-    {
-      selectionType: 'sweepEdge',
-      testPoint: { x: 564, y: 364 },
-      expectedOutput: `helix001 = helix(  axis =   getOppositeEdge(seg01),  radius = 1,  revolutions = 20,  angleStart = 0,  ccw = false,)`,
-      expectedEditedOutput: `helix001 = helix(  axis =   getOppositeEdge(seg01),  radius = 5,  revolutions = 20,  angleStart = 0,  ccw = false,)`,
-    },
-  ]
-  helixCases.map(
-    ({ selectionType, testPoint, expectedOutput, expectedEditedOutput }) => {
-      test(`Helix point-and-click around ${selectionType}`, async ({
-        context,
-        page,
-        homePage,
-        scene,
-        editor,
-        toolbar,
-        cmdBar,
-      }) => {
-        page.on('console', console.log)
-        const initialCode = `sketch001 = startSketchOn('XZ')
-  profile001 = startProfileAt([0, 0], sketch001)
-    |> yLine(length = 100)
-    |> line(endAbsolute = [100, 0])
-    |> line(endAbsolute = [profileStartX(%), profileStartY(%)])
-    |> close()
-  extrude001 = extrude(profile001, length = 100)`
-
-        // One dumb hardcoded screen pixel value
-        const [clickOnEdge] = scene.makeMouseHelpers(testPoint.x, testPoint.y)
-
-        await context.addInitScript((initialCode) => {
-          localStorage.setItem('persistCode', initialCode)
-        }, initialCode)
-        await page.setBodyDimensions({ width: 1000, height: 500 })
-        await homePage.goToModelingScene()
-
-        await test.step(`Go through the command bar flow`, async () => {
-          await toolbar.closePane('code')
-          await toolbar.helixButton.click()
-          await cmdBar.expectState({
-            stage: 'arguments',
-            currentArgKey: 'mode',
-            currentArgValue: '',
-            headerArguments: {
-              AngleStart: '',
-              Mode: '',
-              CounterClockWise: '',
-              Radius: '',
-              Revolutions: '',
-            },
-            highlightedHeaderArg: 'mode',
-            commandName: 'Helix',
-          })
-          await cmdBar.selectOption({ name: 'Edge' }).click()
-          await clickOnEdge()
-          await cmdBar.progressCmdBar()
-          await cmdBar.argumentInput.focus()
-          await page.keyboard.insertText('20')
-          await cmdBar.progressCmdBar()
-          await page.keyboard.insertText('0')
-          await cmdBar.progressCmdBar()
-          await page.keyboard.insertText('1')
-          await cmdBar.progressCmdBar()
-          await cmdBar.expectState({
-            stage: 'review',
-            headerArguments: {
-              Mode: 'Edge',
-              Edge: `1 ${selectionType}`,
-              AngleStart: '0',
-              Revolutions: '20',
-              Radius: '1',
-              CounterClockWise: '',
-            },
-            commandName: 'Helix',
-          })
-          await cmdBar.progressCmdBar()
-        })
-
-        await test.step(`Confirm code is added to the editor, scene has changed`, async () => {
-          await toolbar.openPane('code')
-          await editor.expectEditor.toContain(expectedOutput)
-          await toolbar.closePane('code')
-        })
-
-        await test.step(`Edit helix through the feature tree`, async () => {
-          await toolbar.openPane('feature-tree')
-          const operationButton = await toolbar.getFeatureTreeOperation(
-            'Helix',
-            0
-          )
-          await operationButton.dblclick()
-          const initialInput = '1'
-          const newInput = '5'
-          await cmdBar.expectState({
-            commandName: 'Helix',
-            stage: 'arguments',
-            currentArgKey: 'CounterClockWise',
-            currentArgValue: '',
-            headerArguments: {
-              AngleStart: '0',
-              Revolutions: '20',
-              Radius: initialInput,
-              CounterClockWise: '',
-            },
-            highlightedHeaderArg: 'CounterClockWise',
-          })
-          await page
-            .getByRole('button', { name: 'radius', exact: false })
-            .click()
-          await expect(cmdBar.currentArgumentInput).toBeVisible()
-          await cmdBar.currentArgumentInput
-            .locator('.cm-content')
-            .fill(newInput)
-          await cmdBar.progressCmdBar()
-          await cmdBar.expectState({
-            stage: 'review',
-            headerArguments: {
-              AngleStart: '0',
-              Revolutions: '20',
-              Radius: newInput,
-              CounterClockWise: '',
-            },
-            commandName: 'Helix',
-          })
-          await cmdBar.progressCmdBar()
-          await toolbar.closePane('feature-tree')
-          await toolbar.openPane('code')
-          await editor.expectEditor.toContain(expectedEditedOutput)
-          await toolbar.closePane('code')
-        })
-
-        await test.step('Delete helix via feature tree selection', async () => {
-          await toolbar.openPane('feature-tree')
-          const operationButton = await toolbar.getFeatureTreeOperation(
-            'Helix',
-            0
-          )
-          await operationButton.click({ button: 'left' })
-          await page.keyboard.press('Delete')
-          await editor.expectEditor.not.toContain(expectedEditedOutput)
-          await expect(
-            await toolbar.getFeatureTreeOperation('Helix', 0)
-          ).not.toBeVisible()
-        })
-      })
-    }
-  )
-
-  test('Helix point-and-click on cylinder', async ({
-    context,
-    page,
-    homePage,
-    scene,
-    editor,
-    toolbar,
-    cmdBar,
-  }) => {
-    const initialCode = `sketch001 = startSketchOn(XY)
-profile001 = circle(
-  sketch001,
-  center = [0, 0],
-  radius = 100,
-  tag = $seg01,
-)
-extrude001 = extrude(profile001, length = 100)
-    `
-    await context.addInitScript((initialCode) => {
-      localStorage.setItem('persistCode', initialCode)
-    }, initialCode)
-    await page.setBodyDimensions({ width: 1000, height: 500 })
-    await homePage.goToModelingScene()
-    await scene.waitForExecutionDone()
-
-    // One dumb hardcoded screen pixel value
-    const testPoint = { x: 620, y: 257 }
-    const [clickOnWall] = scene.makeMouseHelpers(testPoint.x, testPoint.y)
-    const expectedOutput = `helix001 = helix(  cylinder = extrude001,  revolutions = 1,  angleStart = 360,  ccw = false,)`
-    const expectedLine = `cylinder = extrude001,`
-    const expectedEditedOutput = `helix001 = helix(  cylinder = extrude001,  revolutions = 1,  angleStart = 360,  ccw = true,)`
-
-    await test.step(`Go through the command bar flow`, async () => {
-      await toolbar.helixButton.click()
-      await cmdBar.expectState({
-        stage: 'arguments',
-        currentArgKey: 'mode',
-        currentArgValue: '',
-        headerArguments: {
-          Mode: '',
-          AngleStart: '',
-          Revolutions: '',
-          Radius: '',
-          CounterClockWise: '',
-        },
-        highlightedHeaderArg: 'mode',
-        commandName: 'Helix',
-      })
-      await cmdBar.selectOption({ name: 'Cylinder' }).click()
-      await cmdBar.expectState({
-        stage: 'arguments',
-        currentArgKey: 'cylinder',
-        currentArgValue: '',
-        headerArguments: {
-          Mode: 'Cylinder',
-          Cylinder: '',
-          AngleStart: '',
-          Revolutions: '',
-          CounterClockWise: '',
-        },
-        highlightedHeaderArg: 'cylinder',
-        commandName: 'Helix',
-      })
-      await clickOnWall()
-      await cmdBar.progressCmdBar()
-      await cmdBar.progressCmdBar()
-      await cmdBar.progressCmdBar()
-      await cmdBar.expectState({
-        stage: 'review',
-        headerArguments: {
-          Mode: 'Cylinder',
-          Cylinder: '1 face',
-          AngleStart: '360',
-          Revolutions: '1',
-          CounterClockWise: '',
-        },
-        commandName: 'Helix',
-      })
-      await cmdBar.progressCmdBar()
-    })
-
-    await test.step(`Confirm code is added to the editor, scene has changed`, async () => {
-      await editor.expectEditor.toContain(expectedOutput)
-      await editor.expectState({
-        diagnostics: [],
-        activeLines: [expectedLine],
-        highlightedCode: '',
-      })
-    })
-
-    await test.step(`Edit helix through the feature tree`, async () => {
-      await editor.closePane()
-      const operationButton = await toolbar.getFeatureTreeOperation('Helix', 0)
-      await operationButton.dblclick()
-      await cmdBar.expectState({
-        commandName: 'Helix',
-        stage: 'arguments',
-        currentArgKey: 'CounterClockWise',
-        currentArgValue: '',
-        headerArguments: {
-          AngleStart: '360',
-          Revolutions: '1',
-          CounterClockWise: '',
-        },
-        highlightedHeaderArg: 'CounterClockWise',
-      })
-      await cmdBar.selectOption({ name: 'True' }).click()
-      await cmdBar.expectState({
-        stage: 'review',
-        headerArguments: {
-          AngleStart: '360',
-          Revolutions: '1',
-          CounterClockWise: 'true',
-        },
-        commandName: 'Helix',
-      })
-      await cmdBar.progressCmdBar()
-      await toolbar.closePane('feature-tree')
-      await toolbar.openPane('code')
-      await editor.expectEditor.toContain(expectedEditedOutput)
-      await editor.closePane()
-    })
-
-    await test.step('Delete helix via feature tree selection', async () => {
-      await toolbar.openPane('feature-tree')
-      const operationButton = await toolbar.getFeatureTreeOperation('Helix', 0)
-      await operationButton.click({ button: 'left' })
-      await page.keyboard.press('Delete')
-      await toolbar.closePane('feature-tree')
-      await toolbar.openPane('code')
-      await editor.expectEditor.not.toContain(expectedEditedOutput)
-    })
-  })
-
   const loftPointAndClickCases = [
     { shouldPreselect: true },
     { shouldPreselect: false },
@@ -1642,9 +1343,9 @@ loft001 = loft([sketch001, sketch002])
       targetType: 'circle',
       testPoint: { x: 700, y: 250 },
       initialCode: `@settings(defaultLengthUnit = in)
-sketch001 = startSketchOn(YZ)
+sketch001 = startSketchOn('YZ')
 profile001 = circle(sketch001, center = [0, 0], radius = 500)
-sketch002 = startSketchOn(XZ)
+sketch002 = startSketchOn('XZ')
   |> startProfileAt([0, 0], %)
   |> xLine(length = -500)
   |> tangentialArcTo([-2000, 500], %)`,
@@ -1653,7 +1354,7 @@ sketch002 = startSketchOn(XZ)
       targetType: 'rectangle',
       testPoint: { x: 710, y: 255 },
       initialCode: `@settings(defaultLengthUnit = in)
-sketch001 = startSketchOn(YZ)
+sketch001 = startSketchOn('YZ')
 profile001 = startProfileAt([-400, -400], sketch001)
   |> angledLine([0, 800], %, $rectangleSegmentA001)
   |> angledLine([
@@ -1666,7 +1367,7 @@ profile001 = startProfileAt([-400, -400], sketch001)
      ], %)
   |> line(endAbsolute = [profileStartX(%), profileStartY(%)])
   |> close()
-sketch002 = startSketchOn(XZ)
+sketch002 = startSketchOn('XZ')
   |> startProfileAt([0, 0], %)
   |> xLine(length = -500)
   |> tangentialArcTo([-2000, 500], %)`,
@@ -1920,7 +1621,7 @@ extrude001 = extrude(sketch001, length = -12)
     const filletColor: [number, number, number] = [127, 127, 127]
     const backgroundColor: [number, number, number] = [30, 30, 30]
     const lowTolerance = 20
-    const highTolerance = 70 // TODO: understand why I needed that for edgeColorYellow on macos (local)
+    const highTolerance = 40
 
     // Setup
     await test.step(`Initial test setup`, async () => {
@@ -2007,54 +1708,6 @@ extrude001 = extrude(sketch001, length = -12)
       await scene.expectPixelColor(filletColor, firstEdgeLocation, lowTolerance)
     })
 
-    // Test 1.1: Edit fillet (segment type)
-    async function editFillet(
-      featureTreeIndex: number,
-      oldValue: string,
-      newValue: string
-    ) {
-      await toolbar.openPane('feature-tree')
-      const operationButton = await toolbar.getFeatureTreeOperation(
-        'Fillet',
-        featureTreeIndex
-      )
-      await operationButton.dblclick({ button: 'left' })
-      await cmdBar.expectState({
-        commandName: 'Fillet',
-        currentArgKey: 'radius',
-        currentArgValue: oldValue,
-        headerArguments: {
-          Radius: oldValue,
-        },
-        highlightedHeaderArg: 'radius',
-        stage: 'arguments',
-      })
-      await page.keyboard.insertText(newValue)
-      await cmdBar.progressCmdBar()
-      await cmdBar.expectState({
-        stage: 'review',
-        headerArguments: {
-          Radius: newValue,
-        },
-        commandName: 'Fillet',
-      })
-      await cmdBar.progressCmdBar()
-      await toolbar.closePane('feature-tree')
-    }
-
-    await test.step('Edit fillet via feature tree selection works', async () => {
-      const firstFilletFeatureTreeIndex = 0
-      const editedRadius = '1'
-      await editFillet(firstFilletFeatureTreeIndex, '5', editedRadius)
-      await editor.expectEditor.toContain(
-        firstFilletDeclaration.replace('radius = 5', 'radius = ' + editedRadius)
-      )
-
-      // Edit back to original radius
-      await editFillet(firstFilletFeatureTreeIndex, editedRadius, '5')
-      await editor.expectEditor.toContain(firstFilletDeclaration)
-    })
-
     // Test 2: Command bar flow without preselected edges
     await test.step(`Open fillet UI without selecting edges`, async () => {
       await page.waitForTimeout(100)
@@ -2139,23 +1792,6 @@ extrude001 = extrude(sketch001, length = -12)
       )
     })
 
-    // Test 2.1: Edit fillet (edgeSweep type)
-    await test.step('Edit fillet via feature tree selection works', async () => {
-      const secondFilletFeatureTreeIndex = 1
-      const editedRadius = '2'
-      await editFillet(secondFilletFeatureTreeIndex, '5', editedRadius)
-      await editor.expectEditor.toContain(
-        secondFilletDeclaration.replace(
-          'radius = 5',
-          'radius = ' + editedRadius
-        )
-      )
-
-      // Edit back to original radius
-      await editFillet(secondFilletFeatureTreeIndex, editedRadius, '5')
-      await editor.expectEditor.toContain(secondFilletDeclaration)
-    })
-
     // Test 3: Delete fillets
     await test.step('Delete fillet via feature tree selection', async () => {
       await test.step('Open Feature Tree Pane', async () => {
@@ -2178,43 +1814,6 @@ extrude001 = extrude(sketch001, length = -12)
     })
   })
 
-  test(`Fillet point-and-click edit rejected when not in pipe`, async ({
-    context,
-    page,
-    homePage,
-    scene,
-    toolbar,
-  }) => {
-    const initialCode = `sketch001 = startSketchOn(XY)
-profile001 = circle(
-  sketch001,
-  center = [0, 0],
-  radius = 100,
-  tag = $seg01,
-)
-extrude001 = extrude(profile001, length = 100)
-fillet001 = fillet(extrude001, radius = 5, tags = [getOppositeEdge(seg01)])
-`
-    await context.addInitScript((initialCode) => {
-      localStorage.setItem('persistCode', initialCode)
-    }, initialCode)
-    await page.setBodyDimensions({ width: 1000, height: 500 })
-    await homePage.goToModelingScene()
-    await scene.waitForExecutionDone()
-
-    await test.step('Double-click in feature tree and expect error toast', async () => {
-      await toolbar.openPane('feature-tree')
-      const operationButton = await toolbar.getFeatureTreeOperation('Fillet', 0)
-      await operationButton.dblclick({ button: 'left' })
-      await expect(
-        page.getByText(
-          'Only chamfer and fillet in pipe expressions are supported for edits'
-        )
-      ).toBeVisible()
-      await page.waitForTimeout(1000)
-    })
-  })
-
   test(`Fillet point-and-click delete`, async ({
     context,
     page,
@@ -2512,7 +2111,7 @@ extrude001 = extrude(sketch001, length = -12)
     const chamferColor: [number, number, number] = [168, 168, 168]
     const backgroundColor: [number, number, number] = [30, 30, 30]
     const lowTolerance = 20
-    const highTolerance = 70 // TODO: understand why I needed that for edgeColorYellow on macos (local)
+    const highTolerance = 40
 
     // Setup
     await test.step(`Initial test setup`, async () => {
@@ -2594,57 +2193,6 @@ extrude001 = extrude(sketch001, length = -12)
       )
     })
 
-    // Test 1.1: Edit sweep
-    async function editChamfer(
-      featureTreeIndex: number,
-      oldValue: string,
-      newValue: string
-    ) {
-      await toolbar.openPane('feature-tree')
-      const operationButton = await toolbar.getFeatureTreeOperation(
-        'Chamfer',
-        featureTreeIndex
-      )
-      await operationButton.dblclick({ button: 'left' })
-      await cmdBar.expectState({
-        commandName: 'Chamfer',
-        currentArgKey: 'length',
-        currentArgValue: oldValue,
-        headerArguments: {
-          Length: oldValue,
-        },
-        highlightedHeaderArg: 'length',
-        stage: 'arguments',
-      })
-      await page.keyboard.insertText(newValue)
-      await cmdBar.progressCmdBar()
-      await cmdBar.expectState({
-        stage: 'review',
-        headerArguments: {
-          Length: newValue,
-        },
-        commandName: 'Chamfer',
-      })
-      await cmdBar.progressCmdBar()
-      await toolbar.closePane('feature-tree')
-    }
-
-    await test.step('Edit chamfer via feature tree selection works', async () => {
-      const firstChamferFeatureTreeIndex = 0
-      const editedLength = '1'
-      await editChamfer(firstChamferFeatureTreeIndex, '5', editedLength)
-      await editor.expectEditor.toContain(
-        firstChamferDeclaration.replace(
-          'length = 5',
-          'length = ' + editedLength
-        )
-      )
-
-      // Edit back to original radius
-      await editChamfer(firstChamferFeatureTreeIndex, editedLength, '5')
-      await editor.expectEditor.toContain(firstChamferDeclaration)
-    })
-
     // Test 2: Command bar flow without preselected edges
     await test.step(`Open chamfer UI without selecting edges`, async () => {
       await page.waitForTimeout(100)
@@ -2729,23 +2277,6 @@ extrude001 = extrude(sketch001, length = -12)
       )
     })
 
-    // Test 2.1: Edit chamfer (edgeSweep type)
-    await test.step('Edit chamfer via feature tree selection works', async () => {
-      const secondChamferFeatureTreeIndex = 1
-      const editedLength = '2'
-      await editChamfer(secondChamferFeatureTreeIndex, '5', editedLength)
-      await editor.expectEditor.toContain(
-        secondChamferDeclaration.replace(
-          'length = 5',
-          'length = ' + editedLength
-        )
-      )
-
-      // Edit back to original length
-      await editChamfer(secondChamferFeatureTreeIndex, editedLength, '5')
-      await editor.expectEditor.toContain(secondChamferDeclaration)
-    })
-
     // Test 3: Delete chamfer via feature tree selection
     await test.step('Open Feature Tree Pane', async () => {
       await toolbar.openPane('feature-tree')
@@ -3476,39 +3007,6 @@ segAng(rectangleSegmentA002),
 
       const newCodeToFind = `revolve001 = revolve(sketch002, angle = 360, axis = 'X')`
       expect(editor.expectEditor.toContain(newCodeToFind)).toBeTruthy()
-
-      // Edit flow
-      const newAngle = '90'
-      await toolbar.openPane('feature-tree')
-      const operationButton = await toolbar.getFeatureTreeOperation(
-        'Revolve',
-        0
-      )
-      await operationButton.dblclick({ button: 'left' })
-      await cmdBar.expectState({
-        commandName: 'Revolve',
-        currentArgKey: 'angle',
-        currentArgValue: '360',
-        headerArguments: {
-          Angle: '360',
-        },
-        highlightedHeaderArg: 'angle',
-        stage: 'arguments',
-      })
-      await page.keyboard.insertText(newAngle)
-      await cmdBar.progressCmdBar()
-      await cmdBar.expectState({
-        stage: 'review',
-        headerArguments: {
-          Angle: newAngle,
-        },
-        commandName: 'Revolve',
-      })
-      await cmdBar.progressCmdBar()
-      await toolbar.closePane('feature-tree')
-      await editor.expectEditor.toContain(
-        newCodeToFind.replace('angle = 360', 'angle = ' + newAngle)
-      )
     })
     test('revolve surface around edge from an extruded solid2d', async ({
       context,
@@ -3519,22 +3017,26 @@ segAng(rectangleSegmentA002),
       toolbar,
       cmdBar,
     }) => {
-      const initialCode = `sketch001 = startSketchOn(XZ)
-  |> startProfileAt([-102.57, 101.72], %)
-  |> angledLine([0, 202.6], %, $rectangleSegmentA001)
-  |> angledLine([
-       segAng(rectangleSegmentA001) - 90,
-       202.6
-     ], %, $rectangleSegmentB001)
-  |> angledLine([
-       segAng(rectangleSegmentA001),
-       -segLen(rectangleSegmentA001)
-     ], %, $rectangleSegmentC001)
-  |> line(endAbsolute = [profileStartX(%), profileStartY(%)])
-  |> close()
+      const initialCode = `
+sketch001 = startSketchOn(XZ)
+|> startProfileAt([-102.57, 101.72], %)
+|> angledLine([0, 202.6], %, $rectangleSegmentA001)
+|> angledLine([
+segAng(rectangleSegmentA001) - 90,
+202.6
+], %, $rectangleSegmentB001)
+|> angledLine([
+segAng(rectangleSegmentA001),
+-segLen(rectangleSegmentA001)
+], %, $rectangleSegmentC001)
+|> line(endAbsolute = [profileStartX(%), profileStartY(%)])
+|> close()
 extrude001 = extrude(sketch001, length = 50)
 sketch002 = startSketchOn(extrude001, rectangleSegmentA001)
-  |> circle(center = [-11.34, 10.0], radius = 8.69)
+|> circle(
+center = [-11.34, 10.0],
+radius = 8.69
+)
 `
       await context.addInitScript((initialCode) => {
         localStorage.setItem('persistCode', initialCode)
@@ -3552,49 +3054,9 @@ sketch002 = startSketchOn(extrude001, rectangleSegmentA001)
       const lineCodeToSelection = `|> angledLine([0, 202.6], %, $rectangleSegmentA001)`
       await page.getByText(lineCodeToSelection).click()
       await cmdBar.progressCmdBar()
-      await cmdBar.progressCmdBar()
-      await cmdBar.progressCmdBar()
 
-      const newCodeToFind = `revolve001 = revolve(sketch002, angle = 360, axis = rectangleSegmentA001)`
-      await editor.expectEditor.toContain(newCodeToFind)
-
-      // Edit flow
-      const newAngle = '180'
-      await toolbar.openPane('feature-tree')
-      const operationButton = await toolbar.getFeatureTreeOperation(
-        'Revolve',
-        0
-      )
-      await operationButton.dblclick({ button: 'left' })
-      await cmdBar.expectState({
-        commandName: 'Revolve',
-        currentArgKey: 'angle',
-        currentArgValue: '360',
-        headerArguments: {
-          Angle: '360',
-        },
-        highlightedHeaderArg: 'angle',
-        stage: 'arguments',
-      })
-      await page.keyboard.insertText(newAngle)
-      await page.getByRole('button', { name: 'Create new variable' }).click()
-      await expect(page.getByPlaceholder('Variable name')).toHaveValue(
-        'angle001'
-      )
-      await cmdBar.progressCmdBar()
-      await cmdBar.expectState({
-        stage: 'review',
-        headerArguments: {
-          Angle: newAngle,
-        },
-        commandName: 'Revolve',
-      })
-      await cmdBar.progressCmdBar()
-      await toolbar.closePane('feature-tree')
-      await editor.expectEditor.toContain('angle001 = ' + newAngle)
-      await editor.expectEditor.toContain(
-        newCodeToFind.replace('angle = 360', 'angle = angle001')
-      )
+      const newCodeToFind = `revolve001 = revolve(sketch002, angle = 360, axis = getOppositeEdge(rectangleSegmentA001)) `
+      expect(editor.expectEditor.toContain(newCodeToFind)).toBeTruthy()
     })
     test('revolve sketch circle around line segment from startProfileAt sketch', async ({
       context,
@@ -3605,22 +3067,26 @@ sketch002 = startSketchOn(extrude001, rectangleSegmentA001)
       toolbar,
       cmdBar,
     }) => {
-      const initialCode = `sketch002 = startSketchOn(XY)
-  |> startProfileAt([-2.02, 1.79], %)
-  |> xLine(length = 2.6)
-sketch001 = startSketchOn(-XY)
-  |> startProfileAt([-0.48, 1.25], %)
-  |> angledLine([0, 2.38], %, $rectangleSegmentA001)
-  |> angledLine([segAng(rectangleSegmentA001) - 90, 2.4], %, $rectangleSegmentB001)
-  |> angledLine([
-       segAng(rectangleSegmentA001),
-       -segLen(rectangleSegmentA001)
-     ], %, $rectangleSegmentC001)
-  |> line(endAbsolute = [profileStartX(%), profileStartY(%)])
-  |> close()
-extrude001 = extrude(sketch001, length = 5)
-sketch003 = startSketchOn(extrude001, 'START')
-  |> circle(center = [-0.69, 0.56], radius = 0.28)
+      const initialCode = `
+    sketch002 = startSketchOn(XY)
+      |> startProfileAt([-2.02, 1.79], %)
+      |> xLine(length = 2.6)
+    sketch001 = startSketchOn('-XY')
+      |> startProfileAt([-0.48, 1.25], %)
+      |> angledLine([0, 2.38], %, $rectangleSegmentA001)
+      |> angledLine([segAng(rectangleSegmentA001) - 90, 2.4], %, $rectangleSegmentB001)
+      |> angledLine([
+        segAng(rectangleSegmentA001),
+          -segLen(rectangleSegmentA001)
+      ], %, $rectangleSegmentC001)
+      |> line(endAbsolute = [profileStartX(%), profileStartY(%)])
+      |> close()
+    extrude001 = extrude(sketch001, length = 5)
+    sketch003 = startSketchOn(extrude001, 'START')
+      |> circle(
+        center = [-0.69, 0.56],
+        radius = 0.28
+      )
 `
 
       await context.addInitScript((initialCode) => {
@@ -3639,44 +3105,9 @@ sketch003 = startSketchOn(extrude001, 'START')
       const lineCodeToSelection = `|> xLine(length = 2.6)`
       await page.getByText(lineCodeToSelection).click()
       await cmdBar.progressCmdBar()
-      await cmdBar.progressCmdBar()
-      await cmdBar.progressCmdBar()
 
       const newCodeToFind = `revolve001 = revolve(sketch003, angle = 360, axis = seg01)`
       expect(editor.expectEditor.toContain(newCodeToFind)).toBeTruthy()
-
-      // Edit flow
-      const newAngle = '270'
-      await toolbar.openPane('feature-tree')
-      const operationButton = await toolbar.getFeatureTreeOperation(
-        'Revolve',
-        0
-      )
-      await operationButton.dblclick({ button: 'left' })
-      await cmdBar.expectState({
-        commandName: 'Revolve',
-        currentArgKey: 'angle',
-        currentArgValue: '360',
-        headerArguments: {
-          Angle: '360',
-        },
-        highlightedHeaderArg: 'angle',
-        stage: 'arguments',
-      })
-      await page.keyboard.insertText(newAngle)
-      await cmdBar.progressCmdBar()
-      await cmdBar.expectState({
-        stage: 'review',
-        headerArguments: {
-          Angle: newAngle,
-        },
-        commandName: 'Revolve',
-      })
-      await cmdBar.progressCmdBar()
-      await toolbar.closePane('feature-tree')
-      await editor.expectEditor.toContain(
-        newCodeToFind.replace('angle = 360', 'angle = ' + newAngle)
-      )
     })
   })
 

e2e/playwright/projects.spec.ts

@@ -8,7 +8,6 @@ import {
   createProject,
   getPlaywrightDownloadDir,
   orRunWhenFullSuiteEnabled,
-  runningOnWindows,
 } from './test-utils'
 import fsp from 'fs/promises'
 import fs from 'fs'
@@ -162,7 +161,7 @@ test(
       // gray at this pixel means the stream has loaded in the most
       // user way we can verify it (pixel color)
       await expect
-        .poll(() => u.getGreatestPixDiff(pointOnModel, [110, 110, 110]), {
+        .poll(() => u.getGreatestPixDiff(pointOnModel, [85, 85, 85]), {
           timeout: 10_000,
         })
         .toBeLessThan(20)
@@ -192,7 +191,7 @@ test(
 
       // error text on hover
       await page.hover('.cm-lint-marker-error')
-      const crypticErrorText = `The arg tag was given, but it was the wrong type`
+      const crypticErrorText = `Expected a tag declarator`
       await expect(page.getByText(crypticErrorText).first()).toBeVisible()
 
       // black pixel means the scene has been cleared.
@@ -248,7 +247,7 @@ test(
       // gray at this pixel means the stream has loaded in the most
       // user way we can verify it (pixel color)
       await expect
-        .poll(() => u.getGreatestPixDiff(pointOnModel, [125, 125, 125]), {
+        .poll(() => u.getGreatestPixDiff(pointOnModel, [85, 85, 85]), {
           timeout: 10_000,
         })
         .toBeLessThan(15)
@@ -319,7 +318,7 @@ test(
       // gray at this pixel means the stream has loaded in the most
       // user way we can verify it (pixel color)
       await expect
-        .poll(() => u.getGreatestPixDiff(pointOnModel, [125, 125, 125]), {
+        .poll(() => u.getGreatestPixDiff(pointOnModel, [85, 85, 85]), {
           timeout: 10_000,
         })
         .toBeLessThan(15)
@@ -352,9 +351,6 @@ test(
   'open a file in a project works and renders, open another file in the same project with errors, it should clear the scene',
   { tag: '@electron' },
   async ({ context, page }, testInfo) => {
-    if (runningOnWindows()) {
-      test.fixme(orRunWhenFullSuiteEnabled())
-    }
     await context.folderSetupFn(async (dir) => {
       const bracketDir = path.join(dir, 'bracket')
       await fsp.mkdir(bracketDir, { recursive: true })
@@ -393,7 +389,7 @@ test(
       // gray at this pixel means the stream has loaded in the most
       // user way we can verify it (pixel color)
       await expect
-        .poll(() => u.getGreatestPixDiff(pointOnModel, [125, 125, 125]), {
+        .poll(() => u.getGreatestPixDiff(pointOnModel, [85, 85, 85]), {
           timeout: 10_000,
         })
         .toBeLessThan(15)
@@ -413,7 +409,7 @@ test(
 
       // error text on hover
       await page.hover('.cm-lint-marker-error')
-      const crypticErrorText = `The arg tag was given, but it was the wrong type`
+      const crypticErrorText = `Expected a tag declarator`
       await expect(page.getByText(crypticErrorText).first()).toBeVisible()
 
       // black pixel means the scene has been cleared.
@@ -443,6 +439,7 @@ test(
     await page.getByText('broken-code').click()
 
     // Gotcha: You can not use scene.waitForExecutionDone() since the KCL code is going to fail
+    await expect(page.getByTestId('loading')).toBeAttached()
     await expect(page.getByTestId('loading')).not.toBeAttached({
       timeout: 20_000,
     })
@@ -456,7 +453,7 @@ test(
 
     // error text on hover
     await page.hover('.cm-lint-marker-error')
-    const crypticErrorText = `The arg tag was given, but it was the wrong type`
+    const crypticErrorText = `Expected a tag declarator`
     await expect(page.getByText(crypticErrorText).first()).toBeVisible()
   }
 )
@@ -472,9 +469,6 @@ test.describe('Can export from electron app', () => {
         if (!tronApp) {
           fail()
         }
-        if (runningOnWindows()) {
-          test.fixme(orRunWhenFullSuiteEnabled())
-        }
 
         await context.folderSetupFn(async (dir) => {
           const bracketDir = path.join(dir, 'bracket')
@@ -512,7 +506,7 @@ test.describe('Can export from electron app', () => {
           // gray at this pixel means the stream has loaded in the most
           // user way we can verify it (pixel color)
           await expect
-            .poll(() => u.getGreatestPixDiff(pointOnModel, [125, 125, 125]), {
+            .poll(() => u.getGreatestPixDiff(pointOnModel, [85, 85, 85]), {
               timeout: 10_000,
             })
             .toBeLessThan(15)
@@ -553,7 +547,7 @@ test.describe('Can export from electron app', () => {
               },
               { timeout: 15_000 }
             )
-            .toBeGreaterThan(50_000)
+            .toBeGreaterThan(300_000)
 
           // clean up exported file
           await fsp.rm(filepath)
@@ -1334,9 +1328,6 @@ test(
   'Can load a file with CRLF line endings',
   { tag: '@electron' },
   async ({ context, page }, testInfo) => {
-    if (runningOnWindows()) {
-      test.fixme(orRunWhenFullSuiteEnabled())
-    }
     await context.folderSetupFn(async (dir) => {
       const routerTemplateDir = path.join(dir, 'router-template-slate')
       await fsp.mkdir(routerTemplateDir, { recursive: true })

e2e/playwright/regression-tests.spec.ts

@@ -331,7 +331,7 @@ extrude001 = extrude(sketch001, length = 50)
           localStorage.setItem(
             'persistCode',
             `@settings(defaultLengthUnit = mm)
-sketch002 = startSketchOn(XY)
+sketch002 = startSketchOn('XY')
 profile002 = startProfileAt([72.24, -52.05], sketch002)
   |> angledLine([0, 181.26], %, $rectangleSegmentA001)
   |> angledLine([
@@ -619,7 +619,6 @@ extrude002 = extrude(profile002, length = 150)
   test(`View gizmo stays visible even when zoomed out all the way`, async ({
     page,
     homePage,
-    scene,
   }) => {
     const u = await getUtils(page)
 
@@ -639,6 +638,7 @@ extrude002 = extrude(profile002, length = 150)
       await homePage.goToModelingScene()
       await u.waitForPageLoad()
       await u.closeKclCodePanel()
+      await page.waitForTimeout(20)
     })
 
     await test.step(`Zoom out until you can't see the default planes`, async () => {
@@ -648,30 +648,22 @@ extrude002 = extrude(profile002, length = 150)
           message: 'Plane color is visible',
         })
         .toBeLessThanOrEqual(20)
-      await expect(scene.startEditSketchBtn).toBeEnabled()
 
       let maxZoomOuts = 10
       let middlePixelIsBackgroundColor =
         (await middlePixelIsColor(bgColor)) < 10
-
-      console.time('pressing control')
-      await page.keyboard.down('Control')
-
       while (!middlePixelIsBackgroundColor && maxZoomOuts > 0) {
-        await page.waitForTimeout(100)
-        await page.mouse.move(650, 460)
-        console.time('moved to start point')
+        await page.keyboard.down('Control')
+        await page.waitForTimeout(20)
+        await page.mouse.move(600, 460)
         await page.mouse.down({ button: 'right' })
-        console.time('moused down')
-        await page.mouse.move(650, 50, { steps: 20 })
-        console.time('moved to end point')
-        await page.waitForTimeout(100)
+        await page.mouse.move(600, 50, { steps: 20 })
         await page.mouse.up({ button: 'right' })
-        console.time('moused up')
+        await page.keyboard.up('Control')
+        await page.waitForTimeout(100)
         maxZoomOuts--
         middlePixelIsBackgroundColor = (await middlePixelIsColor(bgColor)) < 15
       }
-      await page.keyboard.up('Control')
 
       expect(middlePixelIsBackgroundColor, {
         message: 'We should not see the default planes',
@@ -706,8 +698,8 @@ extrude002 = extrude(profile002, length = 150)
       await scene.loadingIndicator.waitFor({ state: 'detached' })
     })
     await test.step(`The part should start loading quickly, not waiting until execution is complete`, async () => {
-      // TODO: use the viewport size to pick the center point, but the `viewport` fixture's values were wrong.
-      await scene.expectPixelColor([116, 116, 116], { x: 500, y: 250 }, 15)
+      // TODO: use the viewport size to pick the center point, but the `viewport` fixutre's values were wrong.
+      await scene.expectPixelColor([143, 143, 143], { x: 500, y: 250 }, 15)
     })
   })
 
@@ -784,19 +776,6 @@ plane002 = offsetPlane(XZ, offset = -2 * x)`
       await editor.expectEditor.not.toContain(`plane002`)
     })
   })
-
-  test.fail(
-    'Console errors cause tests to fail',
-    async ({ page, homePage }) => {
-      const u = await getUtils(page)
-      await homePage.goToModelingScene()
-      await u.openAndClearDebugPanel()
-
-      await page.getByTestId('custom-cmd-input').fill('foobar')
-      await page.getByTestId('custom-cmd-send-button').scrollIntoViewIfNeeded()
-      await page.getByTestId('custom-cmd-send-button').click()
-    }
-  )
 })
 
 async function clickExportButton(page: Page) {

e2e/playwright/sketch-tests.spec.ts

@@ -873,8 +873,7 @@ sketch001 = startProfileAt([12.34, -12.34], sketch002)
 
       await u.openDebugPanel()
 
-      const code = `@settings(defaultLengthUnit = in)
-sketch001 = startSketchOn(-XZ)
+      const code = `sketch001 = startSketchOn(-XZ)
 profile001 = startProfileAt([${roundOff(scale * 69.6)}, ${roundOff(
         scale * 34.8
       )}], sketch001)
@@ -904,7 +903,7 @@ profile001 = startProfileAt([${roundOff(scale * 69.6)}, ${roundOff(
       await page.mouse.move(700, 200, { steps: 10 })
       await page.mouse.click(700, 200, { delay: 200 })
       await expect(page.locator('.cm-content')).toHaveText(
-        `@settings(defaultLengthUnit = in)sketch001 = startSketchOn(-XZ)`
+        `sketch001 = startSketchOn(-XZ)`
       )
 
       let prevContent = await page.locator('.cm-content').innerText()
@@ -1611,8 +1610,7 @@ profile002 = startProfileAt([117.2, 56.08], sketch001)
       await context.addInitScript(() => {
         localStorage.setItem(
           'persistCode',
-          `@settings(defaultLengthUnit = in)
-sketch001 = startSketchOn(XZ)
+          `sketch001 = startSketchOn(XZ)
 profile002 = startProfileAt([40.68, 87.67], sketch001)
   |> xLine(length = 239.17)
 profile003 = startProfileAt([206.63, -56.73], sketch001)
@@ -2180,8 +2178,7 @@ profile003 = startProfileAt([206.63, -56.73], sketch001)
       await page.addInitScript(async () => {
         localStorage.setItem(
           'persistCode',
-          `@settings(defaultLengthUnit = in)
-sketch001 = startSketchOn(XZ)
+          `sketch001 = startSketchOn(XZ)
 profile001 = startProfileAt([6.24, 4.54], sketch001)
   |> line(end = [-0.41, 6.99])
   |> line(end = [8.61, 0.74])
@@ -2326,8 +2323,7 @@ profile004 = circleThreePoint(sketch001, p1 = [13.44, -6.8], p2 = [13.39, -2.07]
       await page.addInitScript(async () => {
         localStorage.setItem(
           'persistCode',
-          `@settings(defaultLengthUnit = in)
-sketch001 = startSketchOn(XZ)
+          `sketch001 = startSketchOn(XZ)
 profile001 = startProfileAt([6.24, 4.54], sketch001)
   |> line(end = [-0.41, 6.99])
   |> line(end = [8.61, 0.74])
@@ -2432,8 +2428,7 @@ profile003 = circle(sketch001, center = [6.92, -4.2], radius = 3.16)
       await page.addInitScript(async () => {
         localStorage.setItem(
           'persistCode',
-          `@settings(defaultLengthUnit = in)
-sketch001 = startSketchOn(XZ)
+          `sketch001 = startSketchOn(XZ)
 profile001 = startProfileAt([-63.43, 193.08], sketch001)
   |> line(end = [168.52, 149.87])
   |> line(end = [190.29, -39.18])
@@ -2548,8 +2543,7 @@ extrude001 = extrude(profile003, length = 5)
       await page.addInitScript(async () => {
         localStorage.setItem(
           'persistCode',
-          `@settings(defaultLengthUnit = in)
-sketch001 = startSketchOn(XZ)
+          `sketch001 = startSketchOn(XZ)
 profile001 = startProfileAt([85.19, 338.59], sketch001)
   |> line(end = [213.3, -94.52])
   |> line(end = [-230.09, -55.34])
@@ -2591,8 +2585,7 @@ profile002 = startProfileAt([85.81, 52.55], sketch002)
       await page.addInitScript(async () => {
         localStorage.setItem(
           'persistCode',
-          `@settings(defaultLengthUnit = in)
-thePart = startSketchOn(XZ)
+          `thePart = startSketchOn(XZ)
   |> startProfileAt([7.53, 10.51], %)
   |> line(end = [12.54, 1.83])
   |> line(end = [6.65, -6.91])
@@ -2653,8 +2646,7 @@ extrude001 = extrude(thePart, length = 75)
       await page.addInitScript(async () => {
         localStorage.setItem(
           'persistCode',
-          `@settings(defaultLengthUnit = in)
-sketch001 = startSketchOn(XZ)
+          `sketch001 = startSketchOn(XZ)
 profile001 = startProfileAt([6.71, -3.66], sketch001)
   |> line(end = [2.65, 9.02], tag = $seg02)
   |> line(end = [3.73, -9.36], tag = $seg01)
@@ -2827,8 +2819,7 @@ extrude003 = extrude(profile011, length = 2.5)
       await page.addInitScript(async () => {
         localStorage.setItem(
           'persistCode',
-          `@settings(defaultLengthUnit = in)
-sketch001 = startSketchOn(XZ)
+          `sketch001 = startSketchOn(XZ)
 profile001 = startProfileAt([34, 42.66], sketch001)
   |> line(end = [102.65, 151.99])
   |> line(end = [76, -138.66])

e2e/playwright/snapshot-tests.spec.ts

@@ -76,11 +76,11 @@ part001 = startSketchOn(-XZ)
   |> xLine(endAbsolute = totalLen, tag = $seg03)
   |> yLine(length = -armThick, tag = $seg01)
   |> angledLineThatIntersects({
-        angle = turns::HALF_TURN,
+        angle = HALF_TURN,
         offset = -armThick,
         intersectTag = seg04
       }, %)
-  |> angledLineToY([segAng(seg04, %) + 180, turns::ZERO], %)
+  |> angledLineToY([segAng(seg04, %) + 180, ZERO], %)
   |> angledLineToY({
         angle = -bottomAng,
         to = -totalHeightHalf - armThick,
@@ -88,12 +88,12 @@ part001 = startSketchOn(-XZ)
   |> xLine(length = endAbsolute = segEndX(seg03) + 0)
   |> yLine(length = -segLen(seg01, %))
   |> angledLineThatIntersects({
-        angle = turns::HALF_TURN,
+        angle = HALF_TURN,
         offset = -armThick,
         intersectTag = seg02
       }, %)
   |> angledLineToY([segAng(seg02, %) + 180, -baseHeight], %)
-  |> xLine(endAbsolute = turns::ZERO)
+  |> xLine(endAbsolute = ZERO)
   |> close()
   |> extrude(length = 4)`
       )

e2e/playwright/snapshots/prompt-to-edit/prompt-to-edit-snapshot-tests-spec-ts--change-colour.snap.json

@@ -1,5 +1,5 @@
 {
-  "original_source_code": "sketch001 = startSketchOn('XZ')\nprofile001 = startProfileAt([57.81, 250.51], sketch001)\n  |> line(end = [121.13, 56.63], tag = $seg02)\n  |> line(end = [83.37, -34.61], tag = $seg01)\n  |> line(end = [19.66, -116.4])\n  |> line(end = [-221.8, -41.69])\n  |> line(endAbsolute = [profileStartX(%), profileStartY(%)])\n  |> close()\nextrude001 = extrude(profile001, length = 200)\nsketch002 = startSketchOn('XZ')\n  |> startProfileAt([-73.64, -42.89], %)\n  |> xLine(length = 173.71)\n  |> line(end = [-22.12, -94.4])\n  |> xLine(length = -156.98)\n  |> line(endAbsolute = [profileStartX(%), profileStartY(%)])\n  |> close()\nextrude002 = extrude(sketch002, length = 50)\nsketch003 = startSketchOn(XY)\n  |> startProfileAt([52.92, 157.81], %)\n  |> angledLine([0, 176.4], %, $rectangleSegmentA001)\n  |> angledLine([\n       segAng(rectangleSegmentA001) - 90,\n       53.4\n     ], %, $rectangleSegmentB001)\n  |> angledLine([\n       segAng(rectangleSegmentA001),\n       -segLen(rectangleSegmentA001)\n     ], %, $rectangleSegmentC001)\n  |> line(endAbsolute = [profileStartX(%), profileStartY(%)])\n  |> close()\nextrude003 = extrude(sketch003, length = 20)\n",
+  "original_source_code": "sketch001 = startSketchOn('XZ')\nprofile001 = startProfileAt([57.81, 250.51], sketch001)\n  |> line(end = [121.13, 56.63], tag = $seg02)\n  |> line(end = [83.37, -34.61], tag = $seg01)\n  |> line(end = [19.66, -116.4])\n  |> line(end = [-221.8, -41.69])\n  |> line(endAbsolute = [profileStartX(%), profileStartY(%)])\n  |> close()\nextrude001 = extrude(profile001, length = 200)\nsketch002 = startSketchOn('XZ')\n  |> startProfileAt([-73.64, -42.89], %)\n  |> xLine(length = 173.71)\n  |> line(end = [-22.12, -94.4])\n  |> xLine(length = -156.98)\n  |> line(endAbsolute = [profileStartX(%), profileStartY(%)])\n  |> close()\nextrude002 = extrude(sketch002, length = 50)\nsketch003 = startSketchOn('XY')\n  |> startProfileAt([52.92, 157.81], %)\n  |> angledLine([0, 176.4], %, $rectangleSegmentA001)\n  |> angledLine([\n       segAng(rectangleSegmentA001) - 90,\n       53.4\n     ], %, $rectangleSegmentB001)\n  |> angledLine([\n       segAng(rectangleSegmentA001),\n       -segLen(rectangleSegmentA001)\n     ], %, $rectangleSegmentC001)\n  |> line(endAbsolute = [profileStartX(%), profileStartY(%)])\n  |> close()\nextrude003 = extrude(sketch003, length = 20)\n",
   "prompt": "make this neon green please, use #39FF14",
   "source_ranges": [
     {
@@ -30,4 +30,4 @@
     }
   ],
   "kcl_version": "0.2.48"
-}
+}

e2e/playwright/snapshots/prompt-to-edit/prompt-to-edit-snapshot-tests-spec-ts--edit-with-ai-example-snapshots--change-colour.snap.json

@@ -29,5 +29,5 @@
       }
     }
   ],
-  "kcl_version": "0.2.54"
+  "kcl_version": "0.2.52"
 }

e2e/playwright/test-utils.test.ts

@@ -1,99 +0,0 @@
-import {
-  runningOnLinux,
-  runningOnMac,
-  runningOnWindows,
-  orRunWhenFullSuiteEnabled,
-} from './test-utils'
-
-describe('platform detection utilities', () => {
-  const originalPlatform = process.platform
-
-  afterAll(() => {
-    Object.defineProperty(process, 'platform', {
-      value: originalPlatform,
-    })
-  })
-
-  describe('runningOnLinux', () => {
-    it('returns true on Linux', () => {
-      Object.defineProperty(process, 'platform', {
-        value: 'linux',
-      })
-      expect(runningOnLinux()).toBe(true)
-    })
-
-    it('returns false on other platforms', () => {
-      Object.defineProperty(process, 'platform', {
-        value: 'darwin',
-      })
-      expect(runningOnLinux()).toBe(false)
-    })
-  })
-
-  describe('runningOnMac', () => {
-    it('returns true on Mac', () => {
-      Object.defineProperty(process, 'platform', {
-        value: 'darwin',
-      })
-      expect(runningOnMac()).toBe(true)
-    })
-
-    it('returns false on other platforms', () => {
-      Object.defineProperty(process, 'platform', {
-        value: 'linux',
-      })
-      expect(runningOnMac()).toBe(false)
-    })
-  })
-
-  describe('runningOnWindows', () => {
-    it('returns true on Windows', () => {
-      Object.defineProperty(process, 'platform', {
-        value: 'win32',
-      })
-      expect(runningOnWindows()).toBe(true)
-    })
-
-    it('returns false on other platforms', () => {
-      Object.defineProperty(process, 'platform', {
-        value: 'linux',
-      })
-      expect(runningOnWindows()).toBe(false)
-    })
-  })
-})
-
-describe('utility to bypass unreliable tests', () => {
-  const originalEnv = { ...process.env }
-
-  afterAll(() => {
-    process.env = { ...originalEnv }
-  })
-
-  it('always runs them on dedicated branch', () => {
-    process.env.GITHUB_EVENT_NAME = 'push'
-    process.env.GITHUB_REF = 'refs/heads/all-e2e'
-    process.env.GITHUB_HEAD_REF = ''
-    process.env.GITHUB_BASE_REF = ''
-    const shouldSkip = orRunWhenFullSuiteEnabled()
-    expect(shouldSkip).toBe(false)
-  })
-
-  it('skips them on the main branch', () => {
-    process.env.GITHUB_EVENT_NAME = 'push'
-    process.env.GITHUB_REF = 'refs/heads/main'
-    process.env.GITHUB_HEAD_REF = ''
-    process.env.GITHUB_BASE_REF = ''
-    const shouldSkip = orRunWhenFullSuiteEnabled()
-    expect(shouldSkip).toBe(true)
-  })
-
-  it('skips them on pull requests', () => {
-    process.env.GITHUB_EVENT_NAME = 'pull_request'
-    process.env.GITHUB_REF = 'refs/pull/5883/merge'
-    process.env.GITHUB_HEAD_REF = 'my-branch'
-    process.env.GITHUB_BASE_REF = 'main'
-    const shouldSkip = orRunWhenFullSuiteEnabled()
-    expect(shouldSkip).toBe(true)
-  })
-})

e2e/playwright/test-utils.ts

@@ -26,7 +26,6 @@ import { isArray } from 'lib/utils'
 import { reportRejection } from 'lib/trap'
 import { DeepPartial } from 'lib/types'
 import { Configuration } from 'lang/wasm'
-import { ProjectConfiguration } from '@rust/kcl-lib/bindings/ProjectConfiguration'
 
 const toNormalizedCode = (text: string) => {
   return text.replace(/\s+/g, '')
@@ -56,21 +55,8 @@ export const commonPoints = {
 export const editorSelector = '[role="textbox"][data-language="kcl"]'
 type PaneId = 'variables' | 'code' | 'files' | 'logs'
 
-export function runningOnLinux() {
-  return process.platform === 'linux'
-}
-
-export function runningOnMac() {
-  return process.platform === 'darwin'
-}
-
-export function runningOnWindows() {
-  return process.platform === 'win32'
-}
-
 export function orRunWhenFullSuiteEnabled() {
-  const branch = process.env.GITHUB_REF?.replace('refs/heads/', '')
-  return branch !== 'all-e2e'
+  return process.env.GITHUB_HEAD_REF !== 'all-e2e'
 }
 
 async function waitForPageLoadWithRetry(page: Page) {
@@ -762,7 +748,7 @@ export interface Paths {
 }
 
 export const doExport = async (
-  output: Models['OutputFormat3d_type'],
+  output: Models['OutputFormat_type'],
   rootDir: string,
   page: Page,
   exportFrom: 'dropdown' | 'sidebarButton' | 'commandBar' = 'dropdown'
@@ -935,39 +921,47 @@ export async function setup(
 }
 
 function failOnConsoleErrors(page: Page, testInfo?: TestInfo) {
-  page.on('pageerror', (exception: any) => {
-    if (isErrorWhitelisted(exception)) {
-      return
-    }
-    // Only disable this environment variable if you want to collect console errors
-    if (process.env.FAIL_ON_CONSOLE_ERRORS !== 'false') {
-      // Use expect to prevent page from closing and not cleaning up
-      expect(`An error was detected in the console: \r\n message:${exception.message} \r\n name:${exception.name} \r\n stack:${exception.stack}
+  // enabled for chrome for now
+  if (page.context().browser()?.browserType().name() === 'chromium') {
+    // No idea wtf exception is
+    page.on('pageerror', (exception: any) => {
+      if (isErrorWhitelisted(exception)) {
+        return
+      }
 
-        *Either fix the console error or add it to the whitelist defined in ./lib/console-error-whitelist.ts (if the error can be safely ignored)
-        `).toEqual('Console error detected')
-    } else {
-      // Add errors to `test-results/exceptions.txt` as a test artifact
-      fsp
-        .appendFile(
-          './test-results/exceptions.txt',
-          [
-            '~~~',
-            `triggered_by_test:${
-              testInfo?.file + ' ' + (testInfo?.title || ' ')
-            }`,
-            `name:${exception.name}`,
-            `message:${exception.message}`,
-            `stack:${exception.stack}`,
-            `project:${testInfo?.project.name}`,
-            '~~~',
-          ].join('\n')
-        )
-        .catch((err) => {
-          console.error(err)
-        })
-    }
-  })
+      // only set this env var to false if you want to collect console errors
+      // This can be configured in the GH workflow.  This should be set to true by default (we want tests to fail when
+      // unwhitelisted console errors are detected).
+      if (process.env.FAIL_ON_CONSOLE_ERRORS === 'true') {
+        // Fail when running on CI and FAIL_ON_CONSOLE_ERRORS is set
+        // use expect to prevent page from closing and not cleaning up
+        expect(`An error was detected in the console: \r\n message:${exception.message} \r\n name:${exception.name} \r\n stack:${exception.stack}
+
+          *Either fix the console error or add it to the whitelist defined in ./lib/console-error-whitelist.ts (if the error can be safely ignored)
+          `).toEqual('Console error detected')
+      } else {
+        // the (test-results/exceptions.txt) file will be uploaded as part of an upload artifact in GH
+        fsp
+          .appendFile(
+            './test-results/exceptions.txt',
+            [
+              '~~~',
+              `triggered_by_test:${
+                testInfo?.file + ' ' + (testInfo?.title || ' ')
+              }`,
+              `name:${exception.name}`,
+              `message:${exception.message}`,
+              `stack:${exception.stack}`,
+              `project:${testInfo?.project.name}`,
+              '~~~',
+            ].join('\n')
+          )
+          .catch((err) => {
+            console.error(err)
+          })
+      }
+    })
+  }
 }
 export async function isOutOfViewInScrollContainer(
   element: Locator,
@@ -1118,15 +1112,3 @@ export function settingsToToml(settings: DeepPartial<Configuration>) {
 export function tomlToSettings(toml: string): DeepPartial<Configuration> {
   return TOML.parse(toml)
 }
-
-export function tomlToPerProjectSettings(
-  toml: string
-): DeepPartial<ProjectConfiguration> {
-  return TOML.parse(toml)
-}
-
-export function perProjectsettingsToToml(
-  settings: DeepPartial<ProjectConfiguration>
-) {
-  return TOML.stringify(settings as any)
-}

e2e/playwright/testing-constraints.spec.ts

@@ -80,8 +80,7 @@ test.describe('Testing constraints', { tag: ['@skipWin'] }, () => {
     await page.addInitScript(async () => {
       localStorage.setItem(
         'persistCode',
-        `@settings(defaultLengthUnit = in)
-  yo = 79
+        `yo = 79
   part001 = startSketchOn(XZ)
     |> startProfileAt([-7.54, -26.74], %)
     |> line(end = [74.36, 130.4], tag = $seg01)
@@ -145,8 +144,7 @@ test.describe('Testing constraints', { tag: ['@skipWin'] }, () => {
         await page.addInitScript(async () => {
           localStorage.setItem(
             'persistCode',
-            `@settings(defaultLengthUnit = in)
-      yo = 5
+            `yo = 5
       part001 = startSketchOn(XZ)
         |> startProfileAt([-7.54, -26.74], %)
         |> line(end = [74.36, 130.4], tag = $seg01)
@@ -160,6 +158,31 @@ test.describe('Testing constraints', { tag: ['@skipWin'] }, () => {
         |> xLine(length = segLen(seg_what))
         |> line(endAbsolute = [profileStartX(%), profileStartY(%)])`
           )
+
+          const isChecked = await createNewVariableCheckbox.isChecked()
+          const addVariable = testName === 'Add variable'
+          XOR(isChecked, addVariable) && // XOR because no need to click the checkbox if the state is already correct
+            (await createNewVariableCheckbox.click())
+
+          await page
+            .getByRole('button', { name: 'Add constraining value' })
+            .click()
+
+          // Wait for the codemod to take effect
+          await expect(page.locator('.cm-content')).toContainText(`angle: -57,`)
+          await expect(page.locator('.cm-content')).toContainText(
+            `offset: ${offset},`
+          )
+
+          await pollEditorLinesSelectedLength(page, 2)
+          const activeLinesContent = await page.locator('.cm-activeLine').all()
+          await expect(activeLinesContent[0]).toHaveText(
+            `|> line(end = [74.36, 130.4], tag = $seg01)`
+          )
+          await expect(activeLinesContent[1]).toHaveText(`}, %)`)
+
+          // checking the count of the overlays is a good proxy check that the client sketch scene is in a good state
+          await expect(page.getByTestId('segment-overlay')).toHaveCount(4)
         })
         const u = await getUtils(page)
         await page.setBodyDimensions({ width: 1200, height: 500 })
@@ -253,8 +276,7 @@ test.describe('Testing constraints', { tag: ['@skipWin'] }, () => {
         await page.addInitScript(async () => {
           localStorage.setItem(
             'persistCode',
-            `@settings(defaultLengthUnit = in)
-      yo = 5
+            `yo = 5
       part001 = startSketchOn(XZ)
         |> startProfileAt([-7.54, -26.74], %)
         |> line(end = [74.36, 130.4])
@@ -364,8 +386,7 @@ test.describe('Testing constraints', { tag: ['@skipWin'] }, () => {
         await page.addInitScript(async () => {
           localStorage.setItem(
             'persistCode',
-            `@settings(defaultLengthUnit = in)
-      yo = 5
+            `yo = 5
       part001 = startSketchOn(XZ)
         |> startProfileAt([-7.54, -26.74], %)
         |> line(end = [74.36, 130.4])
@@ -464,13 +485,13 @@ test.describe('Testing constraints', { tag: ['@skipWin'] }, () => {
         testName: 'Add variable, selecting axis',
         addVariable: true,
         axisSelect: true,
-        value: 'turns::QUARTER_TURN - angle001',
+        value: 'QUARTER_TURN - angle001',
       },
       {
         testName: 'No variable, selecting axis',
         addVariable: false,
         axisSelect: true,
-        value: 'turns::QUARTER_TURN - 7',
+        value: 'QUARTER_TURN - 7',
       },
     ] as const
     for (const { testName, addVariable, value, axisSelect } of cases) {
@@ -478,8 +499,7 @@ test.describe('Testing constraints', { tag: ['@skipWin'] }, () => {
         await page.addInitScript(async () => {
           localStorage.setItem(
             'persistCode',
-            `@settings(defaultLengthUnit = in)
-      yo = 5
+            `yo = 5
       part001 = startSketchOn(XZ)
         |> startProfileAt([-7.54, -26.74], %)
         |> line(end = [74.36, 130.4])
@@ -581,8 +601,7 @@ test.describe('Testing constraints', { tag: ['@skipWin'] }, () => {
         await page.addInitScript(async () => {
           localStorage.setItem(
             'persistCode',
-            `@settings(defaultLengthUnit = in)
-      yo = 5
+            `yo = 5
       part001 = startSketchOn(XZ)
         |> startProfileAt([-7.54, -26.74], %)
         |> line(end = [74.36, 130.4])
@@ -668,8 +687,7 @@ test.describe('Testing constraints', { tag: ['@skipWin'] }, () => {
         await page.addInitScript(async () => {
           localStorage.setItem(
             'persistCode',
-            `@settings(defaultLengthUnit = in)
-yo = 5
+            `yo = 5
 part001 = startSketchOn(XZ)
   |> startProfileAt([-7.54, -26.74], %)
   |> line(end = [74.36, 130.4])
@@ -749,8 +767,7 @@ part002 = startSketchOn(XZ)
         await page.addInitScript(async (customCode) => {
           localStorage.setItem(
             'persistCode',
-            `@settings(defaultLengthUnit = in)
-      yo = 5
+            `yo = 5
       part001 = startSketchOn(XZ)
         |> startProfileAt([-7.54, -26.74], %)
         |> line(end = [74.36, 130.4])
@@ -851,8 +868,7 @@ part002 = startSketchOn(XZ)
         await page.addInitScript(async () => {
           localStorage.setItem(
             'persistCode',
-            `@settings(defaultLengthUnit = in)
-      yo = 5
+            `yo = 5
       part001 = startSketchOn(XZ)
         |> startProfileAt([-7.54, -26.74], %)
         |> line(end = [74.36, 130.4])
@@ -918,12 +934,12 @@ part002 = startSketchOn(XZ)
   test.describe('Axis & segment - no modal constraints', () => {
     const cases = [
       {
-        codeAfter: `|> line(endAbsolute = [154.9, turns::ZERO])`,
+        codeAfter: `|> line(endAbsolute = [154.9, ZERO])`,
         axisClick: { x: 950, y: 250 },
         constraintName: 'Snap To X',
       },
       {
-        codeAfter: `|> line(endAbsolute = [turns::ZERO, 61.34])`,
+        codeAfter: `|> line(endAbsolute = [ZERO, 61.34])`,
         axisClick: { x: 600, y: 150 },
         constraintName: 'Snap To Y',
       },
@@ -933,8 +949,7 @@ part002 = startSketchOn(XZ)
         await page.addInitScript(async () => {
           localStorage.setItem(
             'persistCode',
-            `@settings(defaultLengthUnit = in)
-      yo = 5
+            `yo = 5
       part001 = startSketchOn(XZ)
         |> startProfileAt([-7.54, -26.74], %)
         |> line(end = [74.36, 130.4])

e2e/playwright/testing-samples-loading.spec.ts

@@ -46,7 +46,7 @@ test.describe('Testing in-app sample loading', () => {
       page.getByRole('option', {
         name,
       })
-    const warningText = page.getByText('Overwrite current file with sample?')
+    const warningText = page.getByText('Overwrite current file and units?')
     const confirmButton = page.getByRole('button', { name: 'Submit command' })
 
     await test.step(`Precondition: check the initial code`, async () => {
@@ -110,9 +110,11 @@ test.describe('Testing in-app sample loading', () => {
       const commandMethodOption = page.getByRole('option', {
         name: 'Overwrite',
       })
-      const newFileWarning = page.getByText('Create a new file from sample?')
+      const newFileWarning = page.getByText(
+        'Create a new file, overwrite project units?'
+      )
       const overwriteWarning = page.getByText(
-        'Overwrite current file with sample?'
+        'Overwrite current file and units?'
       )
       const confirmButton = page.getByRole('button', { name: 'Submit command' })
       const projectMenuButton = page.getByTestId('project-sidebar-toggle')

e2e/playwright/testing-segment-overlays.spec.ts

@@ -210,8 +210,7 @@ test.describe('Testing segment overlays', { tag: ['@skipWin'] }, () => {
       await page.addInitScript(async () => {
         localStorage.setItem(
           'persistCode',
-          `@settings(defaultLengthUnit = in)
-      part001 = startSketchOn(XZ)
+          `part001 = startSketchOn(XZ)
         |> startProfileAt([5 + 0, 20 + 0], %)
         |> line(end = [0.5, -14 + 0])
         |> angledLine({ angle = 3 + 0, length = 32 + 0 }, %)
@@ -381,8 +380,7 @@ test.describe('Testing segment overlays', { tag: ['@skipWin'] }, () => {
       await page.addInitScript(async () => {
         localStorage.setItem(
           'persistCode',
-          `@settings(defaultLengthUnit = in)
-    yRel001 = -14
+          `yRel001 = -14
     xRel001 = 0.5
     angle001 = 3
     len001 = 32
@@ -461,8 +459,7 @@ test.describe('Testing segment overlays', { tag: ['@skipWin'] }, () => {
       await page.addInitScript(async () => {
         localStorage.setItem(
           'persistCode',
-          `@settings(defaultLengthUnit = in)
-      part001 = startSketchOn(XZ)
+          `part001 = startSketchOn(XZ)
         |> startProfileAt([0, 0], %)
         |> line(end = [0.5, -14 + 0])
         |> angledLine({ angle = 3 + 0, length = 32 + 0 }, %)
@@ -593,8 +590,7 @@ test.describe('Testing segment overlays', { tag: ['@skipWin'] }, () => {
       await page.addInitScript(async () => {
         localStorage.setItem(
           'persistCode',
-          `@settings(defaultLengthUnit = in)
-      part001 = startSketchOn(XZ)
+          `part001 = startSketchOn(XZ)
         |> startProfileAt([0, 0], %)
         |> line(end = [0.5, -14 + 0])
         |> angledLine({ angle = 3 + 0, length = 32 + 0 }, %)
@@ -755,8 +751,7 @@ test.describe('Testing segment overlays', { tag: ['@skipWin'] }, () => {
       await page.addInitScript(async () => {
         localStorage.setItem(
           'persistCode',
-          `@settings(defaultLengthUnit = in)
-      part001 = startSketchOn(XZ)
+          `part001 = startSketchOn(XZ)
         |> startProfileAt([0, 0], %)
         |> line(end = [0.5, -14 + 0])
         |> angledLine({ angle = 3 + 0, length = 32 + 0 }, %)
@@ -836,8 +831,7 @@ test.describe('Testing segment overlays', { tag: ['@skipWin'] }, () => {
       await page.addInitScript(async () => {
         localStorage.setItem(
           'persistCode',
-          `@settings(defaultLengthUnit = in)
-sketch001 = startSketchOn(XZ)
+          `sketch001 = startSketchOn(XZ)
 profile001 = startProfileAt([56.37, 120.33], sketch001)
   |> line(end = [162.86, 106.48])
   |> arcTo({
@@ -963,8 +957,7 @@ profile001 = startProfileAt([56.37, 120.33], sketch001)
       await page.addInitScript(async () => {
         localStorage.setItem(
           'persistCode',
-          `@settings(defaultLengthUnit = in)
-part001 = startSketchOn(XZ)
+          `part001 = startSketchOn(XZ)
       |> circle(center = [1 + 0, 0], radius = 8)
     `
         )
@@ -1084,8 +1077,7 @@ part001 = startSketchOn(XZ)
       await page.addInitScript(async () => {
         localStorage.setItem(
           'persistCode',
-          `@settings(defaultLengthUnit = in)
-part001 = startSketchOn(XZ)
+          `part001 = startSketchOn(XZ)
   |>startProfileAt([0, 0], %)
   |> line(end = [0.5, -14 + 0])
   |> angledLine({ angle = 3 + 0, length = 32 + 0 }, %)
@@ -1359,8 +1351,7 @@ part001 = startSketchOn(XZ)
             async ({ lineToBeDeleted, extraLine }) => {
               localStorage.setItem(
                 'persistCode',
-                `@settings(defaultLengthUnit = in)
-        part001 = startSketchOn(XZ)
+                `part001 = startSketchOn(XZ)
           |> startProfileAt([5, 6], %)
           |> ${lineToBeDeleted}
           |> line(end = [-10, -15])
@@ -1525,8 +1516,7 @@ part001 = startSketchOn(XZ)
           async ({ lineToBeDeleted }) => {
             localStorage.setItem(
               'persistCode',
-              `@settings(defaultLengthUnit = in)
-      part001 = startSketchOn(XZ)
+              `part001 = startSketchOn(XZ)
         |> startProfileAt([5, 6], %)
         |> ${lineToBeDeleted}
         |> line(end = [-10, -15])

e2e/playwright/testing-selections.spec.ts

@@ -68,20 +68,20 @@ test.describe('Testing selections', { tag: ['@skipWin'] }, () => {
     await u.closeDebugPanel()
     await page.mouse.click(startXPx + PUR * 10, 500 - PUR * 10)
     await expect(page.locator('.cm-content')).toHaveText(
-      `@settings(defaultLengthUnit = in)sketch001 = startSketchOn(XZ)profile001 = startProfileAt(${commonPoints.startAt}, sketch001)`
+      `sketch001 = startSketchOn(XZ)profile001 = startProfileAt(${commonPoints.startAt}, sketch001)`
     )
 
     await page.waitForTimeout(100)
     await page.mouse.click(startXPx + PUR * 20, 500 - PUR * 10)
 
     await expect(page.locator('.cm-content'))
-      .toHaveText(`@settings(defaultLengthUnit = in)sketch001 = startSketchOn(XZ)profile001 = startProfileAt(${commonPoints.startAt}, sketch001)
+      .toHaveText(`sketch001 = startSketchOn(XZ)profile001 = startProfileAt(${commonPoints.startAt}, sketch001)
     |> xLine(length = ${commonPoints.num1})`)
 
     await page.waitForTimeout(100)
     await page.mouse.click(startXPx + PUR * 20, 500 - PUR * 20)
     await expect(page.locator('.cm-content'))
-      .toHaveText(`@settings(defaultLengthUnit = in)sketch001 = startSketchOn(XZ)profile001 = startProfileAt(${
+      .toHaveText(`sketch001 = startSketchOn(XZ)profile001 = startProfileAt(${
       commonPoints.startAt
     }, sketch001)
     |> xLine(length = ${commonPoints.num1})
@@ -89,7 +89,7 @@ test.describe('Testing selections', { tag: ['@skipWin'] }, () => {
     await page.waitForTimeout(100)
     await page.mouse.click(startXPx, 500 - PUR * 20)
     await expect(page.locator('.cm-content'))
-      .toHaveText(`@settings(defaultLengthUnit = in)sketch001 = startSketchOn(XZ)profile001 = startProfileAt(${
+      .toHaveText(`sketch001 = startSketchOn(XZ)profile001 = startProfileAt(${
       commonPoints.startAt
     }, sketch001)
     |> xLine(length = ${commonPoints.num1})
@@ -260,8 +260,7 @@ test.describe('Testing selections', { tag: ['@skipWin'] }, () => {
     await page.addInitScript(async () => {
       localStorage.setItem(
         'persistCode',
-        `@settings(defaultLengthUnit = in)
-sketch001 = startSketchOn(XZ)
+        `sketch001 = startSketchOn(XZ)
   |> startProfileAt([-79.26, 95.04], %)
   |> line(end = [112.54, 127.64], tag = $seg02)
   |> line(end = [170.36, -121.61], tag = $seg01)
@@ -529,8 +528,7 @@ profile001 = startProfileAt([7.49, 9.96], sketch001)
     await page.addInitScript(async (KCL_DEFAULT_LENGTH) => {
       localStorage.setItem(
         'persistCode',
-        `@settings(defaultLengthUnit = in)
-part001 = startSketchOn(XZ)
+        `part001 = startSketchOn(XZ)
   |> startProfileAt([20, 0], %)
   |> line(end = [7.13, 4 + 0])
   |> angledLine({ angle = 3 + 0, length = 3.14 + 0 }, %)
@@ -749,8 +747,7 @@ part001 = startSketchOn(XZ)
     await page.waitForTimeout(200)
 
     await u.removeCurrentCode()
-    await u.codeLocator.fill(`@settings(defaultLengthUnit = in)
-    sketch001 = startSketchOn(XZ)
+    await u.codeLocator.fill(`sketch001 = startSketchOn(XZ)
     |> startProfileAt([75.8, 317.2], %) // [$startCapTag, $EndCapTag]
     |> angledLine([0, 268.43], %, $rectangleSegmentA001)
     |> angledLine([
@@ -968,8 +965,7 @@ part001 = startSketchOn(XZ)
       async ({ cases }) => {
         localStorage.setItem(
           'persistCode',
-          `@settings(defaultLengthUnit = in)
-  yo = 79
+          `yo = 79
   part001 = startSketchOn(XZ)
     |> startProfileAt([-7.54, -26.74], %)
     |> ${cases[0].expectedCode}
@@ -1024,8 +1020,7 @@ part001 = startSketchOn(XZ)
     await page.addInitScript(async () => {
       localStorage.setItem(
         'persistCode',
-        `@settings(defaultLengthUnit = in)
-  sketch001 = startSketchOn(XZ)
+        `sketch001 = startSketchOn(XZ)
     |> startProfileAt([-79.26, 95.04], %)
     |> line(end = [112.54, 127.64])
     |> line(end = [170.36, -121.61], tag = $seg01)
@@ -1258,7 +1253,7 @@ part001 = startSketchOn(XZ)
     await page.mouse.click(700, 200)
 
     await expect(page.locator('.cm-content')).toHaveText(
-      `@settings(defaultLengthUnit = in)sketch001 = startSketchOn(XZ)`
+      `sketch001 = startSketchOn(XZ)`
     )
 
     await page.waitForTimeout(600)

e2e/playwright/testing-settings.spec.ts

@@ -699,19 +699,19 @@ test.describe('Testing settings', () => {
           name: 'Current units are: ',
         })
         await gizmo.click()
-        const button = page.locator('ul').getByRole('button', {
+        const button = page.getByRole('button', {
           name: copy,
           exact: true,
         })
         await button.click()
         const toastMessage = page.getByText(
-          `Updated per-file units to ${unitOfMeasure}`
+          `Set default unit to "${unitOfMeasure}" for this project`
         )
         await expect(toastMessage).toBeVisible()
       }
 
-      await changeUnitOfMeasureInGizmo('ft', 'Feet')
       await changeUnitOfMeasureInGizmo('in', 'Inches')
+      await changeUnitOfMeasureInGizmo('ft', 'Feet')
       await changeUnitOfMeasureInGizmo('yd', 'Yards')
       await changeUnitOfMeasureInGizmo('mm', 'Millimeters')
       await changeUnitOfMeasureInGizmo('cm', 'Centimeters')
@@ -746,7 +746,6 @@ test.describe('Testing settings', () => {
     })
     await page.setBodyDimensions({ width: 1200, height: 500 })
     await homePage.goToModelingScene()
-    await expect(toolbar.startSketchBtn).toBeEnabled({ timeout: 15_000 })
     await scene.settled(cmdBar)
     await page.waitForTimeout(1000)
 

e2e/playwright/various.spec.ts

@@ -67,11 +67,11 @@ part001 = startSketchOn(-XZ)
 |> xLine(endAbsolute = totalLen, tag = $seg03)
 |> yLine(length = -armThick, tag = $seg01)
 |> angledLineThatIntersects({
-      angle = turns::HALF_TURN,
+      angle = HALF_TURN,
       offset = -armThick,
       intersectTag = seg04
     }, %)
-|> angledLineToY([segAng(seg04) + 180, turns::ZERO], %)
+|> angledLineToY([segAng(seg04) + 180, ZERO], %)
 |> angledLineToY({
       angle = -bottomAng,
       to = -totalHeightHalf - armThick,
@@ -79,12 +79,12 @@ part001 = startSketchOn(-XZ)
 |> xLine(endAbsolute = segEndX(seg03) + 0)
 |> yLine(length = -segLen(seg01))
 |> angledLineThatIntersects({
-      angle = turns::HALF_TURN,
+      angle = HALF_TURN,
       offset = -armThick,
       intersectTag = seg02
     }, %)
 |> angledLineToY([segAng(seg02) + 180, -baseHeight], %)
-|> xLine(endAbsolute = turns::ZERO)
+|> xLine(endAbsolute = ZERO)
 |> close()
 |> extrude(length = 4)`
       )

interface.d.ts

@@ -3,18 +3,6 @@ import fsSync from 'node:fs'
 import path from 'path'
 import { dialog, shell } from 'electron'
 import { MachinesListing } from 'components/MachineManagerProvider'
-import type { Channel } from 'src/menu/channels'
-import { Menu, WebContents } from 'electron'
-import { ZooLabel, ZooMenuEvents } from 'menu/roles'
-import type { MenuActionIPC } from 'menu/rules'
-import type { WebContentSendPayload } from 'menu/channels'
-
-// Extend the interface with additional custom properties
-declare module 'electron' {
-  interface Menu {
-    label?: ZooLabel
-  }
-}
 
 type EnvFn = (value?: string) => string
 
@@ -56,9 +44,6 @@ export interface IElectronAPI {
   rm: typeof fs.rm
   stat: (path: string) => ReturnType<fs.stat>
   statIsDirectory: (path: string) => Promise<boolean>
-  canReadWriteDirectory: (
-    path: string
-  ) => Promise<{ value: boolean; error: unknown }>
   path: typeof path
   mkdir: typeof fs.mkdir
   join: typeof path.join
@@ -106,14 +91,6 @@ export interface IElectronAPI {
   appCheckForUpdates: () => Promise<unknown>
   getArgvParsed: () => any
   getAppTestProperty: (propertyName: string) => any
-
-  // Helper functions to create application Menus
-  createHomePageMenu: () => Promise<any>
-  createModelingPageMenu: () => Promise<any>
-  createFallbackMenu: () => Promise<any>
-  enableMenu(menuId: string): Promise<any>
-  disableMenu(menuId: string): Promise<any>
-  menuOn: (callback: (payload: WebContentSendPayload) => void) => any
 }
 
 declare global {

package.json

@@ -13,20 +13,20 @@
   "license": "MIT",
   "dependencies": {
     "@codemirror/autocomplete": "^6.18.6",
-    "@codemirror/commands": "^6.8.1",
+    "@codemirror/commands": "^6.8.0",
     "@codemirror/language": "^6.11.0",
-    "@codemirror/lint": "^6.8.5",
+    "@codemirror/lint": "^6.8.4",
     "@codemirror/search": "^6.5.10",
-    "@codemirror/state": "^6.5.2",
+    "@codemirror/state": "^6.4.1",
     "@codemirror/theme-one-dark": "^6.1.2",
-    "@csstools/postcss-oklab-function": "^4.0.8",
+    "@csstools/postcss-oklab-function": "^4.0.7",
     "@fortawesome/fontawesome-svg-core": "^6.7.2",
     "@fortawesome/free-brands-svg-icons": "^6.7.2",
     "@fortawesome/free-solid-svg-icons": "^6.7.2",
     "@fortawesome/react-fontawesome": "^0.2.0",
     "@headlessui/react": "^1.7.19",
-    "@headlessui/tailwindcss": "^0.2.2",
-    "@kittycad/lib": "2.0.23",
+    "@headlessui/tailwindcss": "^0.2.0",
+    "@kittycad/lib": "2.0.17",
     "@lezer/highlight": "^1.2.1",
     "@lezer/lr": "^1.4.1",
     "@react-hook/resize-observer": "^2.0.1",
@@ -37,11 +37,11 @@
     "@xstate/react": "^4.1.1",
     "bonjour-service": "^1.3.0",
     "bson": "^6.10.3",
-    "chokidar": "^4.0.3",
+    "chokidar": "^4.0.1",
     "codemirror": "^6.0.1",
     "decamelize": "^6.0.0",
     "diff": "^7.0.0",
-    "electron-updater": "^6.6.2",
+    "electron-updater": "^6.6.0",
     "fuse.js": "^7.1.0",
     "html2canvas-pro": "^1.5.8",
     "isomorphic-fetch": "^3.0.0",
@@ -94,11 +94,9 @@
     "fetch:wasm": "./scripts/get-latest-wasm-bundle.sh",
     "fetch:wasm:windows": "./scripts/get-latest-wasm-bundle.ps1",
     "fetch:samples": "rm -rf public/kcl-samples* && curl -L -o public/kcl-samples.zip https://github.com/KittyCAD/kcl-samples/archive/refs/heads/achalmers/kw-args-xylineto.zip && unzip -o public/kcl-samples.zip -d public && mv public/kcl-samples-* public/kcl-samples",
+    "build:wasm-dev": "yarn wasm-prep && (cd rust && wasm-pack build kcl-wasm-lib --dev --target web --out-dir pkg && cargo test -p kcl-lib export_bindings) && yarn isomorphic-copy-wasm && yarn fmt:generated",
     "build:wasm": "./scripts/build-wasm.sh",
     "build:wasm:windows": "./scripts/build-wasm.ps1",
-    "build:wasm-dev": "yarn build:wasm:dev",
-    "build:wasm:dev": "./scripts/build-wasm-dev.sh",
-    "build:wasm:dev:windows": "./scripts/build-wasm-dev.ps1",
     "remove-importmeta": "sed -i 's/import.meta.url/window.location.origin/g' \"./rust/kcl-wasm-lib/pkg/kcl_wasm_lib.js\"; sed -i '' 's/import.meta.url/window.location.origin/g' \"./rust/kcl-wasm-lib/pkg/kcl_wasm_lib.js\" || echo \"sed for both mac and linux\"",
     "lint-fix": "eslint --fix --ext .ts --ext .tsx src e2e packages/codemirror-lsp-client/src rust/kcl-language-server/client/src",
     "lint": "eslint --max-warnings 0 --ext .ts --ext .tsx src e2e packages/codemirror-lsp-client/src rust/kcl-language-server/client/src",
@@ -164,15 +162,15 @@
     "@iarna/toml": "^2.2.5",
     "@lezer/generator": "^1.7.2",
     "@nabla/vite-plugin-eslint": "^2.0.5",
-    "@playwright/test": "^1.51.1",
+    "@playwright/test": "^1.51.0",
     "@testing-library/jest-dom": "^5.14.1",
     "@testing-library/react": "^15.0.2",
-    "@types/diff": "^7.0.2",
+    "@types/diff": "^7.0.1",
     "@types/electron": "^1.6.10",
     "@types/isomorphic-fetch": "^0.0.39",
     "@types/minimist": "^1.2.5",
     "@types/mocha": "^10.0.10",
-    "@types/node": "^22.13.14",
+    "@types/node": "^22.13.9",
     "@types/pixelmatch": "^5.2.6",
     "@types/pngjs": "^6.0.4",
     "@types/react": "^18.3.4",
@@ -182,13 +180,13 @@
     "@types/ua-parser-js": "^0.7.39",
     "@types/uuid": "^9.0.8",
     "@types/wicg-file-system-access": "^2023.10.5",
-    "@types/ws": "^8.18.0",
-    "@vitejs/plugin-react": "^4.3.4",
+    "@types/ws": "^8.5.13",
+    "@vitejs/plugin-react": "^4.3.0",
     "@vitest/web-worker": "^1.5.0",
     "@xstate/cli": "^0.5.17",
-    "autoprefixer": "^10.4.21",
+    "autoprefixer": "^10.4.19",
     "electron": "^34.1.1",
-    "electron-builder": "^26.0.12",
+    "electron-builder": "^26.0.6",
     "eslint": "^8.0.1",
     "eslint-plugin-css-modules": "^2.12.0",
     "eslint-plugin-import": "^2.31.0",
@@ -220,7 +218,7 @@
     "vite-tsconfig-paths": "^4.3.2",
     "vitest": "^1.6.1",
     "vitest-webgl-canvas-mock": "^1.1.0",
-    "ws": "^8.18.1",
+    "ws": "^8.17.0",
     "yarn": "^1.22.22"
   },
   "packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e"

packages/codemirror-lang-kcl/src/kcl.grammar

@@ -75,14 +75,17 @@ LabeledArgument { ArgumentLabel Equals expression }
 ArgumentList { "(" commaSep<LabeledArgument | expression> ")" }
 
 type[@isGroup=Type] {
-  PrimitiveType { identifier } |
+  @specialize[@name=PrimitiveType]<
+    identifier,
+    "bool" | "number" | "string" | "tag" | "Sketch" | "SketchSurface" | "Solid" | "Plane"
+  > |
   ArrayType { "[" type !member (";" Number "+"?)? "]" } |
   ObjectType { "{" commaSep<ObjectProperty { PropertyName ":" type }> "}" }
 }
 
 VariableDefinition { identifier }
 
-VariableName { identifier ("::" identifier)*}
+VariableName { identifier }
 
 ArgumentLabel { identifier }
 
@@ -134,7 +137,7 @@ commaSep1NoTrailingComma<term> { term ("," term)* }
   "(" ")"
   "{" "}"
   "[" "]"
-  "," "?" ":" "." ".." ";" "::"
+  "," "?" ":" "." ".." ";"
 }
 
 @external propSource kclHighlight from "./highlight"

packages/codemirror-lang-kcl/vitest.main.config.ts

@@ -18,9 +18,7 @@ const config = defineConfig({
     environment: 'node',
     reporters: process.env.GITHUB_ACTIONS
       ? ['dot', 'github-actions']
-      : // Gotcha: 'hanging-process' is very noisey, turn off by default on localhost
-        // : ['verbose', 'hanging-process'],
-        ['verbose'],
+      : ['verbose', 'hanging-process'],
     testTimeout: 1000,
     hookTimeout: 1000,
     teardownTimeout: 1000,

packages/codemirror-lsp-client/package.json

@@ -29,7 +29,7 @@
     "vscode-uri": "^3.1.0"
   },
   "devDependencies": {
-    "@types/node": "^22.13.13",
+    "@types/node": "^22.13.10",
     "ts-node": "^10.9.2"
   }
 }

packages/codemirror-lsp-client/src/client/codec/demuxer.ts

@@ -90,7 +90,7 @@ export default class StreamDemuxer extends Queue<Uint8Array> {
   }
 
   add(bytes: Uint8Array): void {
-    const message = Codec.decode<vsrpc.Message>(bytes)
+    const message = Codec.decode(bytes) as vsrpc.Message
     if (this.trace) {
       Tracer.server(message)
     }

packages/codemirror-lsp-client/src/client/codec/index.ts

@@ -37,11 +37,11 @@ export class IntoServer
   implements AsyncGenerator<Uint8Array, never, void>
 {
   private worker: Worker | null = null
-  private type_: string | null = null
+  private type_: String | null = null
 
   private trace: boolean = false
 
-  constructor(type_?: string, worker?: Worker, trace?: boolean) {
+  constructor(type_?: String, worker?: Worker, trace?: boolean) {
     super()
     if (worker && type_) {
       this.worker = worker

packages/codemirror-lsp-client/yarn.lock

@@ -116,10 +116,10 @@
   resolved "https://registry.yarnpkg.com/@tsconfig/node16/-/node16-1.0.4.tgz#0b92dcc0cc1c81f6f306a381f28e31b1a56536e9"
   integrity sha512-vxhUy4J8lyeyinH7Azl1pdd43GJhZH/tP2weN8TntQblOY+A0XbT8DJk1/oCPuOOyg/Ja757rG0CgHcWC8OfMA==
 
-"@types/node@^22.13.13":
-  version "22.13.13"
-  resolved "https://registry.yarnpkg.com/@types/node/-/node-22.13.13.tgz#5e7d110fb509b0d4a43fbf48fa9d6e0f83e1b1e7"
-  integrity sha512-ClsL5nMwKaBRwPcCvH8E7+nU4GxHVx1axNvMZTFHMEfNI7oahimt26P5zjVCRrjiIWj6YFXfE1v3dEp94wLcGQ==
+"@types/node@^22.13.10":
+  version "22.13.10"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-22.13.10.tgz#df9ea358c5ed991266becc3109dc2dc9125d77e4"
+  integrity sha512-I6LPUvlRH+O6VRUqYOcMudhaIdUVWfsjnZavnsraHvpBwaEyMN29ry+0UVJhImYL16xsscu0aske3yA+uPOWfw==
   dependencies:
     undici-types "~6.20.0"
 

playwright.config.ts

@@ -12,7 +12,6 @@ import { defineConfig, devices } from '@playwright/test'
 export default defineConfig({
   timeout: 120_000, // override the default 30s timeout
   testDir: './e2e/playwright',
-  testIgnore: '*.test.ts', // ignore unit tests
   /* Run tests in files in parallel */
   fullyParallel: true,
   /* Fail the build on CI if you accidentally left test.only in the source code. */

playwright.electron.config.ts

@@ -7,7 +7,6 @@ import { platform } from 'os'
 export default defineConfig({
   timeout: 120_000, // override the default 30s timeout
   testDir: './e2e/playwright',
-  testIgnore: '*.test.ts', // ignore unit tests
   /* Run tests in files in parallel */
   fullyParallel: true,
   /* Fail the build on CI if you accidentally left test.only in the source code. */

public/kcl-samples/80-20-rail/main.kcl

@@ -7,7 +7,7 @@
 // Define function
 fn rail8020(originStart, railHeight, railLength) {
   // Sketch side 1 of profile
-  sketch001 = startSketchOn(-XZ)
+  sketch001 = startSketchOn('-XZ')
     |> startProfileAt([
          originStart[0],
          0.1 * railHeight + originStart[1]
@@ -194,7 +194,7 @@ fn rail8020(originStart, railHeight, railLength) {
            .5 * railHeight + originStart[0],
            .5 * railHeight + originStart[1]
          ],
-         radius = .205 * railHeight / 2,
+         radius = .205 * railHeight / 2
        ), %)
     |> extrude(length = railLength)
     |> fillet(
@@ -216,7 +216,7 @@ fn rail8020(originStart, railHeight, railLength) {
            getNextAdjacentEdge(edge28),
            getNextAdjacentEdge(edge29),
            getNextAdjacentEdge(edge30)
-         ],
+         ]
        )
     |> fillet(
          radius = 0.03,
@@ -237,7 +237,7 @@ fn rail8020(originStart, railHeight, railLength) {
            getNextAdjacentEdge(edge26),
            getNextAdjacentEdge(edge31),
            getNextAdjacentEdge(edge32)
-         ],
+         ]
        )
   return sketch001
 }

public/kcl-samples/README.md

@@ -41,8 +41,6 @@ When you submit a PR to add or modify KCL samples, images and STEP files will be
 [![cycloidal-gear](screenshots/cycloidal-gear.png)](cycloidal-gear/main.kcl)
 #### [dodecahedron](dodecahedron/main.kcl) ([screenshot](screenshots/dodecahedron.png))
 [![dodecahedron](screenshots/dodecahedron.png)](dodecahedron/main.kcl)
-#### [dual-basin-utility-sink](dual-basin-utility-sink/main.kcl) ([screenshot](screenshots/dual-basin-utility-sink.png))
-[![dual-basin-utility-sink](screenshots/dual-basin-utility-sink.png)](dual-basin-utility-sink/main.kcl)
 #### [enclosure](enclosure/main.kcl) ([screenshot](screenshots/enclosure.png))
 [![enclosure](screenshots/enclosure.png)](enclosure/main.kcl)
 #### [exhaust-manifold](exhaust-manifold/main.kcl) ([screenshot](screenshots/exhaust-manifold.png))
@@ -77,8 +75,6 @@ When you submit a PR to add or modify KCL samples, images and STEP files will be
 [![kitt](screenshots/kitt.png)](kitt/main.kcl)
 #### [lego](lego/main.kcl) ([screenshot](screenshots/lego.png))
 [![lego](screenshots/lego.png)](lego/main.kcl)
-#### [makeup-mirror](makeup-mirror/main.kcl) ([screenshot](screenshots/makeup-mirror.png))
-[![makeup-mirror](screenshots/makeup-mirror.png)](makeup-mirror/main.kcl)
 #### [mounting-plate](mounting-plate/main.kcl) ([screenshot](screenshots/mounting-plate.png))
 [![mounting-plate](screenshots/mounting-plate.png)](mounting-plate/main.kcl)
 #### [multi-axis-robot](multi-axis-robot/main.kcl) ([screenshot](screenshots/multi-axis-robot.png))

public/kcl-samples/a-parametric-bearing-pillow-block/main.kcl

@@ -15,37 +15,57 @@ padding = 1.5
 bearingDia = 3
 
 // (Needs to be updated). Sketch the block and extrude up to where the counterbore diameter starts.
-extrude001 = startSketchOn(XY)
+extrude001 = startSketchOn('XY')
   |> startProfileAt([-width / 2, -length / 2], %)
   |> line(endAbsolute = [width / 2, -length / 2])
   |> line(endAbsolute = [width / 2, length / 2])
   |> line(endAbsolute = [-width / 2, length / 2])
   |> close()
   |> extrude(length = height)
+  
 extrude002 = startSketchOn(extrude001, 'end')
   |> circle(
-       center = [
+      center = [
          -(width / 2 - (padding / 2)),
          -(length / 2 - (padding / 2))
-       ],
-       radius = cbDia / 2,
+      ],
+      radius = cbDia / 2,
      )
-  |> patternLinear2d(instances = 2, distance = length - padding, axis = [0, 1])
-  |> patternLinear2d(instances = 2, distance = width - padding, axis = [1, 0])
+  |> patternLinear2d(
+      instances = 2,
+      distance = length - padding,
+      axis = [0, 1],
+     )
+  |> patternLinear2d(
+      instances = 2,
+      distance = width - padding,
+      axis = [1, 0],
+    )
   |> extrude(%, length = -cbDepth)
 
 extrude003 = startSketchOn(extrude001, 'start')
   |> circle(
-       center = [
-         -(width / 2 - (padding / 2)),
-         -(length / 2 - (padding / 2))
-       ],
-       radius = holeDia / 2,
+        center = [
+           -(width / 2 - (padding / 2)),
+           -(length / 2 - (padding / 2))
+        ],
+        radius = holeDia / 2,
      )
-  |> patternLinear2d(instances = 2, distance = length - padding, axis = [0, 1])
-  |> patternLinear2d(instances = 2, distance = width - padding, axis = [1, 0])
+  |> patternLinear2d(
+      instances = 2,
+      distance = length - padding,
+      axis = [0, 1],
+    )
+  |> patternLinear2d(
+      instances = 2,
+      distance = width - padding,
+      axis = [1, 0],
+    )
   |> extrude(length = -height + cbDepth)
 
 extrude004 = startSketchOn(extrude001, 'end')
-  |> circle(center = [0, 0], radius = bearingDia / 2)
-  |> extrude(length = -height)
+  |> circle(
+      center = [0, 0],
+      radius = bearingDia/2,
+    )
+  |> extrude(length = -height)

public/kcl-samples/ball-bearing/main.kcl

@@ -17,15 +17,21 @@ chainThickness = sphereDia / 8
 linkDiameter = sphereDia / 4
 
 // Sketch the inside bearing piece
-insideWallSketch = startSketchOn(offsetPlane(XY, offset = -overallThickness / 2))
-  |> circle(center = [0, 0], radius = shaftDia / 2 + wallThickness)
-  |> hole(circle(center = [0, 0], radius = shaftDia / 2), %)
+insideWallSketch = startSketchOn(offsetPlane("XY", offset = -overallThickness / 2))
+  |> circle(
+       center = [0, 0],
+       radius = shaftDia / 2 + wallThickness
+     )
+  |> hole(circle(
+       center = [0, 0],
+       radius = shaftDia / 2
+     ), %)
 
 // Extrude the inside bearing piece
 insideWall = extrude(insideWallSketch, length = overallThickness)
 
 // Create the sketch of one of the balls
-ballsSketch = startSketchOn(XY)
+ballsSketch = startSketchOn("XY")
   |> startProfileAt([shaftDia / 2 + wallThickness, 0.001], %)
   |> arc({
        angleEnd = 0,
@@ -41,11 +47,11 @@ balls = revolve(ballsSketch, axis = "X")
        axis = [0, 0, 1],
        center = [0, 0, 0],
        instances = nBalls,
-       rotateDuplicates = true,
+       rotateDuplicates = true
      )
 
 // Create the sketch for the chain around the balls
-chainSketch = startSketchOn(XY)
+chainSketch = startSketchOn("XY")
   |> startProfileAt([
        shaftDia / 2 + wallThickness + sphereDia / 2 - (chainWidth / 2),
        0.125 * sin(toRadians(60))
@@ -66,17 +72,17 @@ chainHead = revolve(chainSketch, axis = "X")
        axis = [0, 0, 1],
        center = [0, 0, 0],
        instances = nBalls,
-       rotateDuplicates = true,
+       rotateDuplicates = true
      )
 
 // Create the sketch for the links in between the chains
-linkSketch = startSketchOn(XZ)
+linkSketch = startSketchOn("XZ")
   |> circle(
        center = [
          shaftDia / 2 + wallThickness + sphereDia / 2,
          0
        ],
-       radius = linkDiameter / 2,
+       radius = linkDiameter / 2
      )
 
 // Revolve the link sketch
@@ -86,13 +92,19 @@ linkRevolve = revolve(linkSketch, axis = 'Y', angle = 360 / nBalls)
        axis = [0, 0, 1],
        center = [0, 0, 0],
        instances = nBalls,
-       rotateDuplicates = true,
+       rotateDuplicates = true
      )
 
 // Create the sketch for the outside walls
-outsideWallSketch = startSketchOn(offsetPlane(XY, offset = -overallThickness / 2))
-  |> circle(center = [0, 0], radius = outsideDiameter / 2)
-  |> hole(circle(center = [0, 0], radius = shaftDia / 2 + wallThickness + sphereDia), %)
+outsideWallSketch = startSketchOn(offsetPlane("XY", offset = -overallThickness / 2))
+  |> circle(
+       center = [0, 0],
+       radius = outsideDiameter / 2
+     )
+  |> hole(circle(
+       center = [0, 0],
+       radius = shaftDia / 2 + wallThickness + sphereDia
+     ), %)
 
 outsideWall = extrude(outsideWallSketch, length = overallThickness)
 

public/kcl-samples/bench/bench-parts.kcl

@@ -130,7 +130,7 @@ fn armRestProfile(plane, offset) {
 
 export fn armRest(plane, offset) {
   path = armRestPath(  offsetPlane(plane, offset = offset))
-  profile = armRestProfile(  offsetPlane(-XZ, offset = 20), offset)
+  profile = armRestProfile(  offsetPlane("-XZ", offset = 20), offset)
   sweep(profile, path = path)
   return 0
 }

public/kcl-samples/bench/main.kcl

@@ -16,19 +16,19 @@ import backSlats from "bench-parts.kcl"
 import armRest from "bench-parts.kcl"
 
 // Create the dividers, these hold the seat and back slats
-divider(YZ)
-divider(offsetPlane(-YZ, offset = benchLength / 2))
-divider(offsetPlane(YZ, offset = benchLength / 2))
+divider("YZ")
+divider(offsetPlane("-YZ", offset = benchLength / 2))
+divider(offsetPlane("YZ", offset = benchLength / 2))
 
 // Create the connectors to join the dividers
-connector(offsetPlane(YZ, offset = -benchLength / 2), benchLength)
+connector(offsetPlane("YZ", offset = -benchLength / 2), benchLength)
 
 // Create the seat slats
-seatSlats(offsetPlane(YZ, offset = -benchLength / 2 - (dividerThickness / 2)), benchLength + dividerThickness)
+seatSlats(offsetPlane("YZ", offset = -benchLength / 2 - dividerThickness / 2), benchLength + dividerThickness)
 
 // Create the back slats
-backSlats(offsetPlane(YZ, offset = -benchLength / 2 - (dividerThickness / 2)), benchLength + dividerThickness)
+backSlats(offsetPlane("YZ", offset = -benchLength / 2 - dividerThickness / 2), benchLength + dividerThickness)
 
 // Create the arm rests
-armRest(-YZ, benchLength / 2)
-armRest(-YZ, -benchLength / 2)
+armRest("-YZ", benchLength / 2)
+armRest("-YZ", -benchLength / 2)