CSC_FOR_PULL_REQUEST=true

To revert: force release build
Remove zoomToFit on extrude and revolve
2025-02-13 15:15:47 -05:00 · 2025-02-13 14:55:10 -05:00 · 2025-02-13 14:13:39 -05:00
2 changed files with 8 additions and 16 deletions
--- a/.github/workflows/build-apps.yml
+++ b/.github/workflows/build-apps.yml
@ -13,7 +13,8 @@ on:
  # Will checkout the last commit from the default branch (main as of 2023-10-04)

 env:
-  IS_RELEASE: ${{ github.ref_type == 'tag' }}
+  # IS_RELEASE: ${{ github.ref_type == 'tag' }}
+  IS_RELEASE: true
  IS_NIGHTLY: ${{ github.event_name == 'schedule' }}

 concurrency:
@ -51,11 +52,11 @@ jobs:
        if: ${{ env.IS_NIGHTLY == 'true' }}
        run: yarn files:flip-to-nightly

-      - name: Set release version
-        if: ${{ env.IS_RELEASE == 'true' }}
-        run: |
-          export VERSION=${GITHUB_REF_NAME#v}
-          yarn files:set-version
+      # - name: Set release version
+      #   if: ${{ env.IS_RELEASE == 'true' }}
+      #   run: |
+      #     export VERSION=${GITHUB_REF_NAME#v}
+      #     yarn files:set-version

      - uses: actions/upload-artifact@v4
        with:
@ -176,6 +177,7 @@ jobs:
          CSC_LINK: ${{ secrets.APPLE_CERTIFICATE }}
          CSC_KEY_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }}
          CSC_KEYCHAIN: ${{ secrets.APPLE_SIGNING_IDENTITY }}
+          CSC_FOR_PULL_REQUEST: true
          WINDOWS_CERTIFICATE_THUMBPRINT: ${{ secrets.WINDOWS_CERTIFICATE_THUMBPRINT }}
          DEBUG: "electron-notarize*"
        # TODO: Fix electron-notarize flakes. The logs above should help gather more data on failures
--- a/src/machines/modelingMachine.ts
+++ b/src/machines/modelingMachine.ts
@ -684,11 +684,6 @@ export const modelingMachine = setup({

        const updatedAst = await kclManager.updateAst(modifiedAst, true, {
          focusPath: [pathToRevolveArg],
-          zoomToFit: true,
-          zoomOnRangeAndType: {
-            range: selection.graphSelections[0]?.codeRef.range,
-            type: 'path',
-          },
        })

        await codeManager.updateEditorWithAstAndWriteToFile(updatedAst.newAst)
@ -1517,11 +1512,6 @@ export const modelingMachine = setup({

      const updatedAst = await kclManager.updateAst(modifiedAst, true, {
        focusPath: [pathToExtrudeArg],
-        zoomToFit: true,
-        zoomOnRangeAndType: {
-          range: selection.graphSelections[0]?.codeRef.range,
-          type: 'path',
-        },
      })

      await codeManager.updateEditorWithAstAndWriteToFile(updatedAst.newAst)
Author	SHA1	Message	Date
Pierre Jacquier	1591d2f5cb	CSC_FOR_PULL_REQUEST=true	2025-02-13 15:15:47 -05:00
Pierre Jacquier	6781f06492	To revert: force release build	2025-02-13 14:55:10 -05:00
Pierre Jacquier	71eaac98b1	Remove zoomToFit on extrude and revolve Could fix #5376	2025-02-13 14:13:39 -05:00