A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores)

Don't serialize "startNodes" if it's empty
This makes our snapshots and JSON less verbose.
2024-11-05 17:03:19 +00:00 · 2024-11-05 10:42:33 -06:00 · 2024-11-05 10:42:30 -06:00
20 changed files with 38 additions and 57 deletions
--- a/docs/kcl/std.json
+++ b/docs/kcl/std.json
@ -93200,8 +93200,7 @@
            "NonCodeMeta": {
              "type": "object",
              "required": [
-                "nonCodeNodes",
-                "startNodes"
+                "nonCodeNodes"
              ],
              "properties": {
                "nonCodeNodes": {
@ -96944,8 +96943,7 @@
            "NonCodeMeta": {
              "type": "object",
              "required": [
-                "nonCodeNodes",
-                "startNodes"
+                "nonCodeNodes"
              ],
              "properties": {
                "nonCodeNodes": {
@ -100692,8 +100690,7 @@
          "NonCodeMeta": {
            "type": "object",
            "required": [
-              "nonCodeNodes",
-              "startNodes"
+              "nonCodeNodes"
            ],
            "properties": {
              "nonCodeNodes": {
@ -130888,8 +130885,7 @@
            "NonCodeMeta": {
              "type": "object",
              "required": [
-                "nonCodeNodes",
-                "startNodes"
+                "nonCodeNodes"
              ],
              "properties": {
                "nonCodeNodes": {
@ -135023,8 +135019,7 @@
            "NonCodeMeta": {
              "type": "object",
              "required": [
-                "nonCodeNodes",
-                "startNodes"
+                "nonCodeNodes"
              ],
              "properties": {
                "nonCodeNodes": {
@ -138765,8 +138760,7 @@
          "NonCodeMeta": {
            "type": "object",
            "required": [
-              "nonCodeNodes",
-              "startNodes"
+              "nonCodeNodes"
            ],
            "properties": {
              "nonCodeNodes": {
@ -142918,8 +142912,7 @@
            "NonCodeMeta": {
              "type": "object",
              "required": [
-                "nonCodeNodes",
-                "startNodes"
+                "nonCodeNodes"
              ],
              "properties": {
                "nonCodeNodes": {
@ -147053,8 +147046,7 @@
            "NonCodeMeta": {
              "type": "object",
              "required": [
-                "nonCodeNodes",
-                "startNodes"
+                "nonCodeNodes"
              ],
              "properties": {
                "nonCodeNodes": {
@ -150797,8 +150789,7 @@
            "NonCodeMeta": {
              "type": "object",
              "required": [
-                "nonCodeNodes",
-                "startNodes"
+                "nonCodeNodes"
              ],
              "properties": {
                "nonCodeNodes": {
@ -154539,8 +154530,7 @@
          "NonCodeMeta": {
            "type": "object",
            "required": [
-              "nonCodeNodes",
-              "startNodes"
+              "nonCodeNodes"
            ],
            "properties": {
              "nonCodeNodes": {
--- a/e2e/playwright/snapshot-tests.spec.ts-snapshots/Zoom-to-fit-on-load---solid-2d-1-Google-Chrome-win32.png
+++ b/e2e/playwright/snapshot-tests.spec.ts-snapshots/Zoom-to-fit-on-load---solid-2d-1-Google-Chrome-win32.png
--- a/src/wasm-lib/kcl/src/ast/types.rs
+++ b/src/wasm-lib/kcl/src/ast/types.rs
@ -1029,6 +1029,7 @@ pub enum NonCodeValue {
 #[serde(rename_all = "camelCase")]
 pub struct NonCodeMeta {
    pub non_code_nodes: HashMap<usize, NodeList<NonCodeNode>>,
+    #[serde(default, skip_serializing_if = "Vec::is_empty")]
    pub start_nodes: NodeList<NonCodeNode>,

    #[serde(default, skip_serializing_if = "Option::is_none")]
@ -1059,6 +1060,7 @@ impl<'de> Deserialize<'de> for NonCodeMeta {
        #[serde(rename_all = "camelCase")]
        struct NonCodeMetaHelper {
            non_code_nodes: HashMap<String, NodeList<NonCodeNode>>,
+            #[serde(default, skip_serializing_if = "Vec::is_empty")]
            start_nodes: NodeList<NonCodeNode>,
        }

--- a/src/wasm-lib/kcl/src/ast/types/condition.rs
+++ b/src/wasm-lib/kcl/src/ast/types/condition.rs
@ -25,6 +25,8 @@ pub struct IfExpression {
    pub else_ifs: NodeList<ElseIf>,
    pub final_else: BoxNode<IfBlock>,

+    #[serde(default, skip_serializing_if = "Option::is_none")]
+    #[ts(optional)]
    pub digest: Option<Digest>,
 }

@ -36,6 +38,8 @@ pub struct ElseIf {
    pub cond: Expr,
    pub then_val: BoxNode<IfBlock>,

+    #[serde(default, skip_serializing_if = "Option::is_none")]
+    #[ts(optional)]
    pub digest: Option<Digest>,
 }

--- a/src/wasm-lib/kcl/src/parser/snapshots/kcl_libparserparser_impl__snapshot_tests__aw.snap
+++ b/src/wasm-lib/kcl/src/parser/snapshots/kcl_libparserparser_impl__snapshot_tests__aw.snap
@ -1,6 +1,7 @@
 ---
 source: kcl/src/parser/parser_impl.rs
 expression: actual
+snapshot_kind: text
 ---
 {
  "body": [
@ -60,8 +61,7 @@ expression: actual
                    }
                  }
                ]
-              },
-              "startNodes": []
+              }
            },
            "start": 14,
            "type": "ArrayExpression",
--- a/src/wasm-lib/kcl/src/parser/snapshots/kcl_libparserparser_impl__snapshot_tests__ax.snap
+++ b/src/wasm-lib/kcl/src/parser/snapshots/kcl_libparserparser_impl__snapshot_tests__ax.snap
@ -1,6 +1,7 @@
 ---
 source: kcl/src/parser/parser_impl.rs
 expression: actual
+snapshot_kind: text
 ---
 {
  "body": [
@ -60,8 +61,7 @@ expression: actual
                    }
                  }
                ]
-              },
-              "startNodes": []
+              }
            },
            "start": 14,
            "type": "ArrayExpression",
--- a/src/wasm-lib/kcl/src/parser/snapshots/kcl_libparserparser_impl__snapshot_tests__ay.snap
+++ b/src/wasm-lib/kcl/src/parser/snapshots/kcl_libparserparser_impl__snapshot_tests__ay.snap
@ -1,6 +1,7 @@
 ---
 source: kcl/src/parser/parser_impl.rs
 expression: actual
+snapshot_kind: text
 ---
 {
  "body": [
@ -30,8 +31,7 @@ expression: actual
                    }
                  }
                ]
-              },
-              "startNodes": []
+              }
            },
            "properties": [
              {
--- a/src/wasm-lib/kcl/src/parser/snapshots/kcl_libparserparser_impl__snapshot_tests__az.snap
+++ b/src/wasm-lib/kcl/src/parser/snapshots/kcl_libparserparser_impl__snapshot_tests__az.snap
@ -1,6 +1,7 @@
 ---
 source: kcl/src/parser/parser_impl.rs
 expression: actual
+snapshot_kind: text
 ---
 {
  "body": [
@ -30,8 +31,7 @@ expression: actual
                    }
                  }
                ]
-              },
-              "startNodes": []
+              }
            },
            "properties": [
              {
--- a/src/wasm-lib/kcl/src/parser/snapshots/kcl_libparserparser_impl__snapshot_tests__ba.snap
+++ b/src/wasm-lib/kcl/src/parser/snapshots/kcl_libparserparser_impl__snapshot_tests__ba.snap
@ -1,6 +1,7 @@
 ---
 source: kcl/src/parser/parser_impl.rs
 expression: actual
+snapshot_kind: text
 ---
 {
  "body": [
@ -106,8 +107,7 @@ expression: actual
                    }
                  }
                ]
-              },
-              "startNodes": []
+              }
            },
            "start": 19,
            "type": "PipeExpression",
--- a/src/wasm-lib/kcl/src/parser/snapshots/kcl_libparserparser_impl__snapshot_tests__bc.snap
+++ b/src/wasm-lib/kcl/src/parser/snapshots/kcl_libparserparser_impl__snapshot_tests__bc.snap
@ -1,6 +1,7 @@
 ---
 source: kcl/src/parser/parser_impl.rs
 expression: actual
+snapshot_kind: text
 ---
 {
  "body": [
@ -23,7 +24,6 @@ expression: actual
              "type": "Literal",
              "value": true
            },
-            "digest": null,
            "else_ifs": [],
            "end": 74,
            "final_else": {
--- a/src/wasm-lib/kcl/src/parser/snapshots/kcl_libparserparser_impl__snapshot_tests__bd.snap
+++ b/src/wasm-lib/kcl/src/parser/snapshots/kcl_libparserparser_impl__snapshot_tests__bd.snap
@ -1,6 +1,7 @@
 ---
 source: kcl/src/parser/parser_impl.rs
 expression: actual
+snapshot_kind: text
 ---
 {
  "body": [
@ -23,7 +24,6 @@ expression: actual
              "type": "Literal",
              "value": true
            },
-            "digest": null,
            "else_ifs": [
              {
                "cond": {
@ -48,7 +48,6 @@ expression: actual
                  "type": "CallExpression",
                  "type": "CallExpression"
                },
-                "digest": null,
                "end": 90,
                "start": 44,
                "then_val": {
--- a/src/wasm-lib/kcl/src/parser/snapshots/kcl_libparserparser_impl__snapshot_tests__f.snap
+++ b/src/wasm-lib/kcl/src/parser/snapshots/kcl_libparserparser_impl__snapshot_tests__f.snap
@ -1,6 +1,7 @@
 ---
 source: kcl/src/parser/parser_impl.rs
 expression: actual
+snapshot_kind: text
 ---
 {
  "body": [
@ -48,8 +49,7 @@ expression: actual
          }
        }
      ]
-    },
-    "startNodes": []
+    }
  },
  "start": 0
 }
--- a/src/wasm-lib/kcl/tests/add_lots/ast.snap
+++ b/src/wasm-lib/kcl/tests/add_lots/ast.snap
@ -3197,8 +3197,7 @@ snapshot_kind: text
            }
          }
        ]
-      },
-      "startNodes": []
+      }
    },
    "start": 0
  }
--- a/src/wasm-lib/kcl/tests/array_range_expr/ast.snap
+++ b/src/wasm-lib/kcl/tests/array_range_expr/ast.snap
@ -848,8 +848,7 @@ snapshot_kind: text
            }
          }
        ]
-      },
-      "startNodes": []
+      }
    },
    "start": 0
  }
--- a/src/wasm-lib/kcl/tests/comparisons/ast.snap
+++ b/src/wasm-lib/kcl/tests/comparisons/ast.snap
@ -651,8 +651,7 @@ snapshot_kind: text
            }
          }
        ]
-      },
-      "startNodes": []
+      }
    },
    "start": 0
  }
--- a/src/wasm-lib/kcl/tests/cube/ast.snap
+++ b/src/wasm-lib/kcl/tests/cube/ast.snap
@ -664,8 +664,7 @@ snapshot_kind: text
                        }
                      }
                    ]
-                  },
-                  "startNodes": []
+                  }
                },
                "start": 30
              },
@ -787,8 +786,7 @@ snapshot_kind: text
            }
          }
        ]
-      },
-      "startNodes": []
+      }
    },
    "start": 0
  }
--- a/src/wasm-lib/kcl/tests/cube/program_memory.snap
+++ b/src/wasm-lib/kcl/tests/cube/program_memory.snap
@ -681,8 +681,7 @@ snapshot_kind: text
                      }
                    }
                  ]
-                },
-                "startNodes": []
+                }
              },
              "start": 30
            },
--- a/src/wasm-lib/kcl/tests/double_map_fn/ast.snap
+++ b/src/wasm-lib/kcl/tests/double_map_fn/ast.snap
@ -226,8 +226,7 @@ snapshot_kind: text
            }
          }
        ]
-      },
-      "startNodes": []
+      }
    },
    "start": 0
  }
--- a/src/wasm-lib/kcl/tests/if_else/ast.snap
+++ b/src/wasm-lib/kcl/tests/if_else/ast.snap
@ -25,7 +25,6 @@ snapshot_kind: text
                "type": "Literal",
                "value": true
              },
-              "digest": null,
              "else_ifs": [
                {
                  "cond": {
@ -36,7 +35,6 @@ snapshot_kind: text
                    "type": "Literal",
                    "value": true
                  },
-                  "digest": null,
                  "end": 88,
                  "start": 68,
                  "then_val": {
@ -188,7 +186,6 @@ snapshot_kind: text
                "type": "Literal",
                "value": false
              },
-              "digest": null,
              "else_ifs": [
                {
                  "cond": {
@ -199,7 +196,6 @@ snapshot_kind: text
                    "type": "Literal",
                    "value": true
                  },
-                  "digest": null,
                  "end": 202,
                  "start": 182,
                  "then_val": {
@ -351,7 +347,6 @@ snapshot_kind: text
                "type": "Literal",
                "value": false
              },
-              "digest": null,
              "else_ifs": [
                {
                  "cond": {
@ -362,7 +357,6 @@ snapshot_kind: text
                    "type": "Literal",
                    "value": false
                  },
-                  "digest": null,
                  "end": 322,
                  "start": 301,
                  "then_val": {
--- a/src/wasm-lib/kcl/tests/sketch_in_object/ast.snap
+++ b/src/wasm-lib/kcl/tests/sketch_in_object/ast.snap
@ -837,8 +837,7 @@ snapshot_kind: text
            }
          }
        ]
-      },
-      "startNodes": []
+      }
    },
    "start": 0
  }
Author	SHA1	Message	Date
github-actions[bot]	47c78fe8a3	A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores)	2024-11-05 17:03:19 +00:00
Adam Chalmers	24faa9fb8c	Don't serialize "startNodes" if it's empty This makes our snapshots and JSON less verbose.	2024-11-05 10:42:33 -06:00
Adam Chalmers	d2ec1e5bd5	Don't serialize empty 'digest' on IfExprs	2024-11-05 10:42:30 -06:00