pierremtb/adhoc/quick-eval-stream-offset-impact-on-e2e

.github/workflows/e2e-tests.yml

@@ -4,6 +4,7 @@ on:
     branches:
       - main
       - all-e2e # this bypasses `fixme()` using `orRunWhenFullSuiteEnabled()`
+      - pierremtb/adhoc/quick-eval-stream-offset-impact-on-e2e
   pull_request:
   schedule:
     - cron: 0 * * * *  # hourly

e2e/playwright/can-create-sketches-on-all-planes-and-their-back-sides.spec.ts

@@ -21,7 +21,7 @@ test.describe(
       clickCoords: { x: number; y: number }
     ) => {
       const u = await getUtils(page)
-      await page.setBodyDimensions({ width: 1200, height: 500 })
+      await page.setBodyDimensions({ width: 1700, height: 500 })
 
       await homePage.goToModelingScene()
       const XYPlanRed: [number, number, number] = [98, 50, 51]

e2e/playwright/feature-tree-pane.spec.ts

@@ -406,6 +406,7 @@ profile003 = startProfileAt([0, -4.93], sketch001)
       await fsp.mkdir(testProject, { recursive: true })
       await fsp.writeFile(join(testProject, 'main.kcl'), beforeKclCode, 'utf-8')
     })
+    await page.setBodyDimensions({ width: 1500, height: 500 })
     // One dumb hardcoded screen pixel value
     const testPoint = { x: 650, y: 250 }
     const sketchColor: [number, number, number] = [149, 149, 149]

e2e/playwright/onboarding-tests.spec.ts

@@ -488,6 +488,7 @@ test('Restarting onboarding on desktop takes one attempt', async ({
       join(routerTemplateDir, 'main.kcl')
     )
   })
+  await page.setBodyDimensions({ width: 1500, height: 500 })
 
   // Our constants
   const u = await getUtils(page)

e2e/playwright/point-click-assemblies.spec.ts

@@ -87,7 +87,7 @@ test.describe('Point-and-click assemblies tests', () => {
             fsp.writeFile(path.join(bracketDir, 'main.kcl'), ''),
           ])
         })
-        await page.setBodyDimensions({ width: 1000, height: 500 })
+        await page.setBodyDimensions({ width: 1500, height: 500 })
         await homePage.openProject(projectName)
         await scene.settled(cmdBar)
         await toolbar.closePane('code')
@@ -225,7 +225,7 @@ test.describe('Point-and-click assemblies tests', () => {
             fsp.writeFile(path.join(bracketDir, 'main.kcl'), ''),
           ])
         })
-        await page.setBodyDimensions({ width: 1000, height: 500 })
+        await page.setBodyDimensions({ width: 1500, height: 500 })
         await homePage.openProject(projectName)
         await scene.settled(cmdBar)
         await toolbar.closePane('code')
@@ -403,7 +403,7 @@ test.describe('Point-and-click assemblies tests', () => {
             fsp.writeFile(path.join(bracketDir, 'main.kcl'), ''),
           ])
         })
-        await page.setBodyDimensions({ width: 1000, height: 500 })
+        await page.setBodyDimensions({ width: 1500, height: 500 })
         await homePage.openProject(projectName)
         await scene.settled(cmdBar)
         await toolbar.closePane('code')

e2e/playwright/point-click.spec.ts

@@ -203,7 +203,7 @@ test.describe('Point-and-click tests', () => {
       await context.addInitScript((file) => {
         localStorage.setItem('persistCode', file)
       }, file)
-      await page.setBodyDimensions({ width: 1000, height: 500 })
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await homePage.goToModelingScene()
       await scene.settled(cmdBar)
 
@@ -366,7 +366,7 @@ profile001 = startProfileAt([205.96, 254.59], sketch002)
       await context.addInitScript((file) => {
         localStorage.setItem('persistCode', file)
       }, file)
-      await page.setBodyDimensions({ width: 1000, height: 500 })
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await homePage.goToModelingScene()
 
       await scene.settled(cmdBar)
@@ -689,7 +689,7 @@ openSketch = startSketchOn(XY)
       await context.addInitScript((initialCode) => {
         localStorage.setItem('persistCode', initialCode)
       }, initialCode)
-      await page.setBodyDimensions({ width: 1000, height: 500 })
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await homePage.goToModelingScene()
 
       // Wait for the scene and stream to load
@@ -864,7 +864,7 @@ openSketch = startSketchOn(XY)
 
     // Setup
     await test.step(`Initial test setup`, async () => {
-      await page.setBodyDimensions({ width: 1000, height: 500 })
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await homePage.goToModelingScene()
 
       // Wait for the scene and stream to load
@@ -1215,7 +1215,7 @@ openSketch = startSketchOn(XY)
         await context.addInitScript((initialCode) => {
           localStorage.setItem('persistCode', initialCode)
         }, initialCode)
-        await page.setBodyDimensions({ width: 1000, height: 500 })
+        await page.setBodyDimensions({ width: 1500, height: 500 })
         await homePage.goToModelingScene()
         await scene.settled(cmdBar)
 
@@ -1360,7 +1360,7 @@ extrude001 = extrude(profile001, length = 100)
     await context.addInitScript((initialCode) => {
       localStorage.setItem('persistCode', initialCode)
     }, initialCode)
-    await page.setBodyDimensions({ width: 1000, height: 500 })
+    await page.setBodyDimensions({ width: 1500, height: 500 })
     await homePage.goToModelingScene()
     await scene.settled(cmdBar)
 
@@ -1496,7 +1496,7 @@ extrude001 = extrude(profile001, length = 100)
       await context.addInitScript((initialCode) => {
         localStorage.setItem('persistCode', initialCode)
       }, initialCode)
-      await page.setBodyDimensions({ width: 1000, height: 500 })
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await homePage.goToModelingScene()
 
       // One dumb hardcoded screen pixel value
@@ -1587,7 +1587,7 @@ loft001 = loft([sketch001, sketch002])
     await context.addInitScript((initialCode) => {
       localStorage.setItem('persistCode', initialCode)
     }, initialCode)
-    await page.setBodyDimensions({ width: 1000, height: 500 })
+    await page.setBodyDimensions({ width: 1500, height: 500 })
     await homePage.goToModelingScene()
     await scene.settled(cmdBar)
 
@@ -1676,7 +1676,7 @@ sketch002 = startSketchOn(XZ)
       await context.addInitScript((initialCode) => {
         localStorage.setItem('persistCode', initialCode)
       }, initialCode)
-      await page.setBodyDimensions({ width: 1000, height: 500 })
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await homePage.goToModelingScene()
       await scene.settled(cmdBar)
 
@@ -1818,7 +1818,7 @@ sketch002 = startSketchOn(XZ)
     await context.addInitScript((initialCode) => {
       localStorage.setItem('persistCode', initialCode)
     }, initialCode)
-    await page.setBodyDimensions({ width: 1000, height: 500 })
+    await page.setBodyDimensions({ width: 1500, height: 500 })
     await homePage.goToModelingScene()
     await scene.settled(cmdBar)
 
@@ -1924,7 +1924,7 @@ extrude001 = extrude(sketch001, length = -12)
       await context.addInitScript((initialCode) => {
         localStorage.setItem('persistCode', initialCode)
       }, initialCode)
-      await page.setBodyDimensions({ width: 1000, height: 500 })
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await homePage.goToModelingScene()
 
       // verify modeling scene is loaded
@@ -2199,7 +2199,7 @@ fillet001 = fillet(extrude001, radius = 5, tags = [getOppositeEdge(seg01)])
     await context.addInitScript((initialCode) => {
       localStorage.setItem('persistCode', initialCode)
     }, initialCode)
-    await page.setBodyDimensions({ width: 1000, height: 500 })
+    await page.setBodyDimensions({ width: 1500, height: 500 })
     await homePage.goToModelingScene()
     await scene.settled(cmdBar)
 
@@ -2263,7 +2263,7 @@ fillet04 = fillet(extrude001, radius = 5, tags = [getOppositeEdge(seg02)])
       await context.addInitScript((initialCode) => {
         localStorage.setItem('persistCode', initialCode)
       }, initialCode)
-      await page.setBodyDimensions({ width: 1000, height: 500 })
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await homePage.goToModelingScene()
 
       // verify modeling scene is loaded
@@ -2397,7 +2397,7 @@ extrude001 = extrude(profile001, length = 5)
       await context.addInitScript((initialCode) => {
         localStorage.setItem('persistCode', initialCode)
       }, initialCode)
-      await page.setBodyDimensions({ width: 1000, height: 500 })
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await homePage.goToModelingScene()
 
       // verify modeling scene is loaded
@@ -2520,7 +2520,7 @@ extrude001 = extrude(sketch001, length = -12)
       await context.addInitScript((initialCode) => {
         localStorage.setItem('persistCode', initialCode)
       }, initialCode)
-      await page.setBodyDimensions({ width: 1000, height: 500 })
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await homePage.goToModelingScene()
       await scene.settled(cmdBar)
     })
@@ -2821,7 +2821,7 @@ chamfer04 = chamfer(extrude001, length = 5, tags = [getOppositeEdge(seg02)])
       await context.addInitScript((initialCode) => {
         localStorage.setItem('persistCode', initialCode)
       }, initialCode)
-      await page.setBodyDimensions({ width: 1000, height: 500 })
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await homePage.goToModelingScene()
       await scene.settled(cmdBar)
 
@@ -2946,7 +2946,7 @@ extrude001 = extrude(sketch001, length = 30)
         localStorage.setItem('persistCode', initialCode)
       }, initialCode)
 
-      await page.setBodyDimensions({ width: 1000, height: 500 })
+      await page.setBodyDimensions({ width: 1500, height: 500 })
 
       await homePage.goToModelingScene()
       await scene.connectionEstablished()
@@ -3089,7 +3089,7 @@ extrude001 = extrude(sketch001, length = 40)
     await context.addInitScript((initialCode) => {
       localStorage.setItem('persistCode', initialCode)
     }, initialCode)
-    await page.setBodyDimensions({ width: 1000, height: 500 })
+    await page.setBodyDimensions({ width: 1500, height: 500 })
     await homePage.goToModelingScene()
     await scene.settled(cmdBar)
 
@@ -3236,7 +3236,7 @@ extrude002 = extrude(sketch002, length = 50)
       await context.addInitScript((initialCode) => {
         localStorage.setItem('persistCode', initialCode)
       }, initialCode)
-      await page.setBodyDimensions({ width: 1200, height: 500 })
+      await page.setBodyDimensions({ width: 1700, height: 500 })
       await homePage.goToModelingScene()
       await scene.settled(cmdBar)
 
@@ -3325,7 +3325,7 @@ profile001 = startProfileAt([-20, 20], sketch001)
       await context.addInitScript((initialCode) => {
         localStorage.setItem('persistCode', initialCode)
       }, initialCode)
-      await page.setBodyDimensions({ width: 1000, height: 500 })
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await homePage.goToModelingScene()
       await scene.settled(cmdBar)
       await toolbar.openPane('feature-tree')
@@ -3405,7 +3405,7 @@ sweep001 = sweep(sketch001, path = sketch002)
     await context.addInitScript((initialCode) => {
       localStorage.setItem('persistCode', initialCode)
     }, initialCode)
-    await page.setBodyDimensions({ width: 1000, height: 500 })
+    await page.setBodyDimensions({ width: 1500, height: 500 })
     await homePage.goToModelingScene()
     await scene.settled(cmdBar)
 
@@ -3487,7 +3487,7 @@ tag=$rectangleSegmentC002,
       await context.addInitScript((initialCode) => {
         localStorage.setItem('persistCode', initialCode)
       }, initialCode)
-      await page.setBodyDimensions({ width: 1000, height: 500 })
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await homePage.goToModelingScene()
       await scene.settled(cmdBar)
 
@@ -3565,7 +3565,7 @@ sketch002 = startSketchOn(extrude001, face = rectangleSegmentA001)
       await context.addInitScript((initialCode) => {
         localStorage.setItem('persistCode', initialCode)
       }, initialCode)
-      await page.setBodyDimensions({ width: 1000, height: 500 })
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await homePage.goToModelingScene()
       await scene.connectionEstablished()
       await scene.settled(cmdBar)
@@ -3656,7 +3656,7 @@ sketch002 = startSketchOn(extrude001, face = rectangleSegmentA001)
       await context.addInitScript((initialCode) => {
         localStorage.setItem('persistCode', initialCode)
       }, initialCode)
-      await page.setBodyDimensions({ width: 1000, height: 500 })
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await homePage.goToModelingScene()
       await scene.connectionEstablished()
       await scene.settled(cmdBar)
@@ -3736,7 +3736,7 @@ extrude001 = extrude(profile001, length = 100)
     await context.addInitScript((initialCode) => {
       localStorage.setItem('persistCode', initialCode)
     }, initialCode)
-    await page.setBodyDimensions({ width: 1000, height: 500 })
+    await page.setBodyDimensions({ width: 1500, height: 500 })
     await homePage.goToModelingScene()
     await scene.settled(cmdBar)
 
@@ -3867,7 +3867,7 @@ extrude001 = extrude(profile001, length = 100)
       await context.addInitScript((initialCode) => {
         localStorage.setItem('persistCode', initialCode)
       }, initialCode)
-      await page.setBodyDimensions({ width: 1000, height: 500 })
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await homePage.goToModelingScene()
       await scene.settled(cmdBar)
 
@@ -4023,7 +4023,7 @@ extrude001 = extrude(profile001, length = 100)
       await context.addInitScript((initialCode) => {
         localStorage.setItem('persistCode', initialCode)
       }, initialCode)
-      await page.setBodyDimensions({ width: 1000, height: 500 })
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await homePage.goToModelingScene()
       await scene.settled(cmdBar)
 
@@ -4152,7 +4152,7 @@ extrude001 = extrude(profile001, length = 1)
     await context.addInitScript((initialCode) => {
       localStorage.setItem('persistCode', initialCode)
     }, initialCode)
-    await page.setBodyDimensions({ width: 1000, height: 500 })
+    await page.setBodyDimensions({ width: 1500, height: 500 })
     await homePage.goToModelingScene()
     await scene.settled(cmdBar)
 

e2e/playwright/prompt-to-edit.spec.ts

@@ -53,6 +53,7 @@ test.describe('Prompt-to-edit tests', { tag: '@skipWin' }, () => {
         await context.addInitScript((file) => {
           localStorage.setItem('persistCode', file)
         }, file)
+        await page.setBodyDimensions({ width: 1500, height: 500 })
         await homePage.goToModelingScene()
         await scene.settled(cmdBar)
 
@@ -148,6 +149,7 @@ test.describe('Prompt-to-edit tests', { tag: '@skipWin' }, () => {
     await context.addInitScript((file) => {
       localStorage.setItem('persistCode', file)
     }, file)
+    await page.setBodyDimensions({ width: 1500, height: 500 })
     await homePage.goToModelingScene()
     await scene.settled(cmdBar)
 
@@ -203,6 +205,7 @@ test.describe('Prompt-to-edit tests', { tag: '@skipWin' }, () => {
     await context.addInitScript((file) => {
       localStorage.setItem('persistCode', file)
     }, file)
+    await page.setBodyDimensions({ width: 1500, height: 500 })
     await homePage.goToModelingScene()
     await scene.settled(cmdBar)
 
@@ -272,6 +275,7 @@ test.describe('Prompt-to-edit tests', { tag: '@skipWin' }, () => {
     await context.addInitScript((file) => {
       localStorage.setItem('persistCode', file)
     }, file)
+    await page.setBodyDimensions({ width: 1500, height: 500 })
     await homePage.goToModelingScene()
     await scene.settled(cmdBar)
 

e2e/playwright/regression-tests.spec.ts

@@ -343,7 +343,7 @@ extrude002 = extrude(profile002, length = 150)
       )
 
       const websocketPromise = page.waitForEvent('websocket')
-      await page.setBodyDimensions({ width: 500, height: 500 })
+      await page.setBodyDimensions({ width: 1000, height: 500 })
 
       await homePage.goToModelingScene()
       const websocket = await websocketPromise
@@ -679,10 +679,12 @@ extrude002 = extrude(profile002, length = 150)
     scene,
     toolbar,
     viewport,
+    page,
   }) => {
     await context.folderSetupFn(async (dir) => {
       const legoDir = path.join(dir, 'lego')
       await fsp.mkdir(legoDir, { recursive: true })
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await fsp.copyFile(
         executorInputPath('e2e-can-sketch-on-chamfer.kcl'),
         path.join(legoDir, 'main.kcl')

e2e/playwright/sketch-tests.spec.ts

@@ -115,6 +115,7 @@ sketch001 = startSketchOn(XZ)
       )
     })
 
+    await page.setBodyDimensions({ width: 1500, height: 500 })
     await homePage.goToModelingScene()
     await scene.settled(cmdBar)
 
@@ -1541,6 +1542,7 @@ profile003 = startProfileAt([206.63, -56.73], sketch001)
         )
       })
 
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await homePage.goToModelingScene()
       await scene.settled(cmdBar)
 
@@ -2230,7 +2232,7 @@ profile003 = circle(sketch001, center = [6.92, -4.2], radius = 3.16)
         )
       })
 
-      await page.setBodyDimensions({ width: 1000, height: 500 })
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await homePage.goToModelingScene()
       await scene.settled(cmdBar)
       await expect(
@@ -2339,7 +2341,7 @@ extrude001 = extrude(profile003, length = 5)
         )
       })
 
-      await page.setBodyDimensions({ width: 1000, height: 500 })
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await homePage.goToModelingScene()
       await scene.connectionEstablished()
       await scene.settled(cmdBar)
@@ -2437,7 +2439,7 @@ profile002 = startProfileAt([85.81, 52.55], sketch002)
         )
       })
 
-      await page.setBodyDimensions({ width: 1000, height: 500 })
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await homePage.goToModelingScene()
       await expect(
         page.getByRole('button', { name: 'Start Sketch' })
@@ -2595,7 +2597,7 @@ extrude003 = extrude(profile011, length = 2.5)
         )
       })
 
-      await page.setBodyDimensions({ width: 1000, height: 500 })
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await homePage.goToModelingScene()
       await scene.connectionEstablished()
       await scene.settled(cmdBar)
@@ -2710,7 +2712,7 @@ loft([profile001, profile002])
         )
       })
 
-      await page.setBodyDimensions({ width: 1000, height: 500 })
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await homePage.goToModelingScene()
       await expect(
         page.getByRole('button', { name: 'Start Sketch' })
@@ -2768,7 +2770,7 @@ loft([profile001, profile002])
       )
     })
 
-    await page.setBodyDimensions({ width: 1000, height: 500 })
+    await page.setBodyDimensions({ width: 1500, height: 500 })
     await homePage.goToModelingScene()
     await expect(
       page.getByRole('button', { name: 'Start Sketch' })
@@ -3260,6 +3262,7 @@ profile003 = startProfileAt([-201.08, 254.17], sketch002)
       await context.addInitScript((file) => {
         localStorage.setItem('persistCode', file)
       }, file)
+      await page.setBodyDimensions({ width: 1500, height: 500 })
       await homePage.goToModelingScene()
 
       const [objClick] = scene.makeMouseHelpers(600, 250)

src/components/EngineStream.tsx

@@ -391,6 +391,7 @@ export const EngineStream = (props: {
     <div
       ref={videoWrapperRef}
       className="absolute inset-0 z-0"
+      style={{ paddingLeft: '500px' }}
       id="stream"
       data-testid="stream"
       onMouseUp={handleMouseUp}

src/components/ModelingSidebar/ModelingSidebar.tsx

@@ -215,7 +215,7 @@ export function ModelingSidebar({ paneOpacity }: ModelingSidebarProps) {
     <Resizable
       className={`group flex-1 flex flex-col z-10 my-2 pr-1 ${paneOpacity} ${pointerEventsCssClass}`}
       defaultSize={{
-        width: '550px',
+        width: '500px',
         height: 'auto',
       }}
       minWidth={200}

src/machines/engineStreamMachine.ts

@@ -166,7 +166,7 @@ export const engineStreamMachine = setup({
         if (!canvas) return
 
         const { width, height } = getDimensions(
-          window.innerWidth,
+          window.innerWidth - 500,
           window.innerHeight
         )