Compare commits
	
		
			22 Commits
		
	
	
		
			remove-unu
			...
			pierremtb/
		
	
	| Author | SHA1 | Date | |
|---|---|---|---|
| 578cc7304c | |||
| f79ee9bf75 | |||
| 7142a72674 | |||
| fc37b8a4bf | |||
| e2d3e00a2c | |||
| 2ea2ac570d | |||
| d9b053675d | |||
| b92cbd33fd | |||
| 2d71e0a31c | |||
| f11f72d48d | |||
| 780f62254f | |||
| 4890f74de8 | |||
| d7839978f8 | |||
| a7ef882dca | |||
| 738295f72a | |||
| f189e395b4 | |||
| af2bd8e7c3 | |||
| 0dec6a25e7 | |||
| d21002c652 | |||
| 3b547030f0 | |||
| 3f86d53d8c | |||
| 2f4fa89e0c | 
							
								
								
									
										54
									
								
								.github/workflows/e2e-tests.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						| @ -1,7 +1,7 @@ | ||||
| name: E2E Tests | ||||
| on: | ||||
|   push: | ||||
|     branches: [ main ] | ||||
|     branches: [ main, pierremtb/adhoc/use-less-namespace-resources-back-to-1-worker ] | ||||
|   pull_request: | ||||
|   schedule: | ||||
|     - cron: 0 * * * *  # hourly | ||||
| @ -75,7 +75,7 @@ jobs: | ||||
|  | ||||
|   prepare-wasm: | ||||
|     # seperate job on Ubuntu to build or fetch the wasm blob once on the fastest runner | ||||
|     runs-on: namespace-profile-ubuntu-8-cores | ||||
|     runs-on: runs-on=${{ github.run_id }}/family=i7ie.2xlarge/image=ubuntu22-full-x64 | ||||
|     needs: conditions | ||||
|     steps: | ||||
|       - uses: actions/checkout@v4 | ||||
| @ -163,7 +163,7 @@ jobs: | ||||
|  | ||||
|   snapshots: | ||||
|     name: playwright:snapshots:ubuntu | ||||
|     runs-on: namespace-profile-ubuntu-8-cores | ||||
|     runs-on: runs-on=${{ github.run_id }}/family=i7ie.2xlarge/image=ubuntu22-full-x64 | ||||
|     needs: [conditions, prepare-wasm] | ||||
|     steps: | ||||
|       - uses: actions/create-github-app-token@v1 | ||||
| @ -237,19 +237,14 @@ jobs: | ||||
|       - uses: actions/upload-artifact@v4 | ||||
|         if: ${{ needs.conditions.outputs.should-run == 'true' && !cancelled() && (success() || failure()) }} | ||||
|         with: | ||||
|           name: playwright-report-snapshots-${{ matrix.os }}-snapshot-${{ matrix.shardIndex }}-${{ github.sha }} | ||||
|           name: playwright-report-ubuntu-snapshot-${{ github.sha }} | ||||
|           path: playwright-report/ | ||||
|           include-hidden-files: true | ||||
|           retention-days: 30 | ||||
|           overwrite: true | ||||
|  | ||||
|       - name: Clean up test-results | ||||
|         if: ${{ needs.conditions.outputs.should-run == 'true' && !cancelled() && (success() || failure()) }} | ||||
|         continue-on-error: true | ||||
|         run: rm -r test-results | ||||
|  | ||||
|       - name: check for changes | ||||
|         if: ${{ needs.conditions.outputs.should-run == 'true' && matrix.os == 'namespace-profile-ubuntu-8-cores' && matrix.shardIndex == 1 && github.ref != 'refs/heads/main' }} | ||||
|         if: ${{ needs.conditions.outputs.should-run == 'true' && github.ref != 'refs/heads/main' }} | ||||
|         shell: bash | ||||
|         id: git-check | ||||
|         run: | | ||||
| @ -270,31 +265,26 @@ jobs: | ||||
|           git fetch origin | ||||
|           echo ${{ github.head_ref }} | ||||
|           git checkout ${{ github.head_ref }} | ||||
|           git commit -m "A snapshot a day keeps the bugs away! 📷🐛 (OS: ${{matrix.os}})" || true | ||||
|           git commit -m "A snapshot a day keeps the bugs away! 📷🐛" || true | ||||
|           git push | ||||
|           git push origin ${{ github.head_ref }} | ||||
|  | ||||
|       # only upload artifacts if there's actually changes | ||||
|       - uses: actions/upload-artifact@v4 | ||||
|         if: ${{ needs.conditions.outputs.should-run == 'true' && steps.git-check.outputs.modified == 'true' }} | ||||
|         with: | ||||
|           name: playwright-report-ubuntu-${{ github.sha }} | ||||
|           path: playwright-report/ | ||||
|           include-hidden-files: true | ||||
|           retention-days: 30 | ||||
|  | ||||
|  | ||||
|   electron: | ||||
|     needs: [conditions, prepare-wasm] | ||||
|     timeout-minutes: 60 | ||||
|     name: playwright:electron:${{ matrix.os }} ${{ matrix.shardIndex }} ${{ matrix.shardTotal }} | ||||
|     env: | ||||
|       OS_NAME: ${{ contains(matrix.os, 'ubuntu') && 'ubuntu' || (contains(matrix.os, 'windows') && 'windows' || 'macos') }} | ||||
|     name: playwright:electron:${{ contains(matrix.os, 'ubuntu') && 'ubuntu' || (contains(matrix.os, 'windows') && 'windows' || 'macos') }}:${{ matrix.shardIndex }}:${{ matrix.shardTotal }} | ||||
|     strategy: | ||||
|       fail-fast: false | ||||
|       matrix: | ||||
|         # TODO: enable namespace-profile-windows-8-cores once available | ||||
|         os: [namespace-profile-ubuntu-8-cores, namespace-profile-macos-8-cores, windows-16-cores] | ||||
|         shardIndex: [1, 2, 3, 4, 5, 6, 7, 8] | ||||
|         shardTotal: [8] | ||||
|         # TODO: enable namespace-profile-windows-latest once available | ||||
|         os: | ||||
|           - "runs-on=${{ github.run_id }}/family=i7ie.2xlarge/image=ubuntu22-full-x64" | ||||
|           - namespace-profile-macos-8-cores | ||||
|           - windows-latest | ||||
|         shardIndex: [1, 2, 3, 4] | ||||
|         shardTotal: [4] | ||||
|         # Disable macos and windows tests on hourly e2e tests since we only care | ||||
|         # about server side changes. | ||||
|         # Technique from https://github.com/joaomcteixeira/python-project-skeleton/pull/31/files | ||||
| @ -303,7 +293,7 @@ jobs: | ||||
|         exclude: | ||||
|           - os: namespace-profile-macos-8-cores | ||||
|             isScheduled: true | ||||
|           - os: windows-16-cores | ||||
|           - os: windows-latest | ||||
|             isScheduled: true | ||||
|         # TODO: add ref here for main and latest release tag | ||||
|     runs-on: ${{ matrix.os }} | ||||
| @ -361,7 +351,7 @@ jobs: | ||||
|         if: ${{ needs.conditions.outputs.should-run == 'true' && !cancelled() && (success() || failure()) }} | ||||
|         continue-on-error: true | ||||
|         with: | ||||
|           name: test-results-${{ matrix.os }}-${{ matrix.shardIndex }}-${{ github.sha }} | ||||
|           name: test-results-${{ env.OS_NAME }}-${{ matrix.shardIndex }}-${{ github.sha }} | ||||
|           path: test-results/ | ||||
|  | ||||
|       - name: Run playwright/electron flow (with retries) | ||||
| @ -370,8 +360,8 @@ jobs: | ||||
|         uses: nick-fields/retry@v3.0.2 | ||||
|         with: | ||||
|           shell: bash | ||||
|           command: .github/ci-cd-scripts/playwright-electron.sh ${{matrix.shardIndex}} ${{matrix.shardTotal}} ${{matrix.os}} | ||||
|           timeout_minutes: 30 | ||||
|           command: .github/ci-cd-scripts/playwright-electron.sh ${{matrix.shardIndex}} ${{matrix.shardTotal}} ${{ env.OS_NAME }} | ||||
|           timeout_minutes: 45 | ||||
|           max_attempts: 15 | ||||
|         env: | ||||
|           CI: true | ||||
| @ -384,7 +374,7 @@ jobs: | ||||
|       - uses: actions/upload-artifact@v4 | ||||
|         if: ${{ needs.conditions.outputs.should-run == 'true' && always() }} | ||||
|         with: | ||||
|           name: test-results-${{ matrix.os }}-${{ matrix.shardIndex }}-${{ github.sha }} | ||||
|           name: test-results-${{ env.OS_NAME }}-${{ matrix.shardIndex }}-${{ github.sha }} | ||||
|           path: test-results/ | ||||
|           include-hidden-files: true | ||||
|           retention-days: 30 | ||||
| @ -393,7 +383,7 @@ jobs: | ||||
|       - uses: actions/upload-artifact@v4 | ||||
|         if: ${{ needs.conditions.outputs.should-run == 'true' && always() }} | ||||
|         with: | ||||
|           name: playwright-report-${{ matrix.os }}-${{ matrix.shardIndex }}-${{ github.sha }} | ||||
|           name: playwright-report-${{ env.OS_NAME }}-${{ matrix.shardIndex }}-${{ github.sha }} | ||||
|           path: playwright-report/ | ||||
|           include-hidden-files: true | ||||
|           retention-days: 30 | ||||
|  | ||||
| Before Width: | Height: | Size: 54 KiB After Width: | Height: | Size: 52 KiB | 
| Before Width: | Height: | Size: 55 KiB After Width: | Height: | Size: 53 KiB | 
| Before Width: | Height: | Size: 50 KiB After Width: | Height: | Size: 49 KiB | 
| Before Width: | Height: | Size: 55 KiB After Width: | Height: | Size: 55 KiB | 
| Before Width: | Height: | Size: 69 KiB After Width: | Height: | Size: 67 KiB | 
| Before Width: | Height: | Size: 145 KiB After Width: | Height: | Size: 143 KiB | 
| Before Width: | Height: | Size: 128 KiB After Width: | Height: | Size: 127 KiB | 
| Before Width: | Height: | Size: 54 KiB After Width: | Height: | Size: 69 KiB | 
| @ -29,5 +29,5 @@ | ||||
|       } | ||||
|     } | ||||
|   ], | ||||
|   "kcl_version": "0.2.47" | ||||
|   "kcl_version": "0.2.50" | ||||
| } | ||||
| @ -1,4 +1,5 @@ | ||||
| import { defineConfig, devices } from '@playwright/test' | ||||
| import { platform } from 'os' | ||||
|  | ||||
| /** | ||||
|  * See https://playwright.dev/docs/test-configuration. | ||||
| @ -12,7 +13,7 @@ export default defineConfig({ | ||||
|   forbidOnly: true, | ||||
|   /* Do not retry */ | ||||
|   retries: 0, | ||||
|   /* Different amount of parallelism on CI and local. */ | ||||
|   /* Both on CI and local. */ | ||||
|   workers: 1, | ||||
|   /* Reporter to use. See https://playwright.dev/docs/test-reporters */ | ||||
|   reporter: [ | ||||
|  | ||||
